My favorites ▼ | Sign in
Logo
Project Home
  
Downloads
  
Wiki
  
Issues
    
New issue | Search
for
| Advanced search | Search tips
Issue 8669: Can't drag and drop a URL/bookmarks on title bar.
6 people starred this issue and may be notified of changes. Back to list
 
Reported by venkataramana@chromium.org, Mar 11, 2009 
Reproduces on 2.0.169.0 (Official Build 11238) and also on Trunk (r11449)
Works fine on stable.

-Drag a URL/Bookmark from B'bar/Local file to empty tile bar (blue bar),
[your mouse pointer should be after "+" [new tab] button and should be
horizontally at center/just above ] and drop it.
The drop event is ignored.

If you drop it, just above the Omnibox, then it works fine in un-maximized
window only and this also no use in maximized window.
Comment 1 by dhhwai, Mar 11, 2009 
[Confirmed] in Chrome 2.0.169.0 (Official Build 11238).

This must be fixed quickly!
Comment 2 by sky@chromium.org, Mar 11, 2009 
This probably has to do with recent nonclient area changes.
Owner: s...@chromium.org
Comment 3 by jon@chromium.org, Mar 11, 2009 
(No comment was entered for this change.)
Status: Assigned
Labels: Mstone-2.0
Comment 4 by bugdroid1@chromium.org, Mar 13, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11666 

------------------------------------------------------------------------
r11666 | sky@google.com | 2009-03-13 13:30:35 -0700 (Fri, 13 Mar 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_views.vcproj?r1=11666&r2=11665
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_frame.cc?r1=11666&r2=11665
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_frame.h?r1=11666&r2=11665
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_root_view.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_root_view.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=11666&r2=11665
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.h?r1=11666&r2=11665
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h?r1=11666&r2=11665
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/non_client_view.h?r1=11666&r2=11665

Makes drops above the tabstrip work again. This stopped working
because of changes to the view hiearchy.

BUG=8669
TEST=see bug

Review URL: http://codereview.chromium.org/42176
------------------------------------------------------------------------
Comment 5 by sky@chromium.org, Mar 13, 2009 
(No comment was entered for this change.)
Status: Fixed
Comment 6 by sky@chromium.org, Mar 16, 2009 
 Issue 8834  has been merged into this issue.
Comment 7 by venkataramana@chromium.org, Mar 17, 2009 
Works fine in 2.0.170.0 (Official Build 11755).

-Venkat.
Status: Verified
Comment 8 by bugdroid1@chromium.org, Mar 17, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11947 

------------------------------------------------------------------------
r11947 | mal@chromium.org | 2009-03-17 21:58:08 -0700 (Tue, 17 Mar 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/browser_views.vcproj?r1=11947&r2=11946
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/browser_frame.cc?r1=11947&r2=11946
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/browser_frame.h?r1=11947&r2=11946
   A http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/browser_root_view.cc
   A http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/browser_root_view.h
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/browser_view.cc?r1=11947&r2=11946
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/browser_view.h?r1=11947&r2=11946
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/glass_browser_frame_view.h?r1=11947&r2=11946
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/views/non_client_view.h?r1=11947&r2=11946

Merge r11666.

Makes drops above the tabstrip work again. This stopped working
because of changes to the view hiearchy.

BUG=8669
TEST=see bug

Original Review URL: http://codereview.chromium.org/42176

TBR= sky

Review URL: http://codereview.chromium.org/42318
------------------------------------------------------------------------
► Sign in to add a comment

Powered by Google Project Hosting