| Issue 8526: | Glass screwed up when returning from other resolution | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Launch in Aero glass and maximize. Start an app that runs in another resolution (I used Starcraft) alt-tab out of that app. Note the glass is invisible and if you restore the window the glass area is drawn as all black. This is almost certainly due to my don't-hide-taskbars fix. |
||||||||||||||||||||
,
Mar 09, 2009
Lowering to P2 since with the revert of r10845 this should no longer actually be visible, but not closing so I know I need to prevent this from happening again.
Labels: -Pri-1 Pri-2
|
|||||||||||||||||||||
,
Mar 09, 2009
Not fixed by reverting r10845. I now think this was due to Ben's changes to handle DWM toggling on/off, especially since I found comments in the code about "becoming unhappy and painting black behind the client area" which is pretty much precisely what's happening here.
Owner: b...@chromium.org
Cc: pkast...@chromium.org Labels: -Pri-2 Pri-1 |
|||||||||||||||||||||
,
Mar 09, 2009
Indeed, can be reproduced by switching DWM on and off when window maximized, no need for starcraft (starcraft triggers Windows' compat mode which forces all apps on system into non-glass, which we don't recover from well in when maximized for some as yet unknown reason)... |
|||||||||||||||||||||
,
Mar 10, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=11401
------------------------------------------------------------------------
r11401 | ben@chromium.org | 2009-03-10 16:32:33 -0700 (Tue, 10 Mar 2009) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/non_client_view.cc?r1=11401&r2=11400
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/widget_win.h?r1=11401&r2=11400
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/window.cc?r1=11401&r2=11400
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/window.h?r1=11401&r2=11400
Fix black titlebar rendering when toggling DWM when the window is maximized:
- restore window after hiding it, since our hide hack only works for non-maximized windows
- handle WM_WINDOWPOSCHANGING in this case to make sure the window isn't made visible by the restore action
http://crbug.com/8526
Review URL: http://codereview.chromium.org/43052
------------------------------------------------------------------------
|
|||||||||||||||||||||
,
Mar 10, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||||
,
Mar 10, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=11419
------------------------------------------------------------------------
r11419 | mal@chromium.org | 2009-03-10 20:32:09 -0700 (Tue, 10 Mar 2009) | 13 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/views/non_client_view.cc?r1=11419&r2=11418
M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/views/widget_win.h?r1=11419&r2=11418
M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/views/window.cc?r1=11419&r2=11418
M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/views/window.h?r1=11419&r2=11418
Merge r11401.
Fix black titlebar rendering when toggling DWM when the window is maximized:
- restore window after hiding it, since our hide hack only works for non-maximized windows
- handle WM_WINDOWPOSCHANGING in this case to make sure the window isn't made visible by the restore action
http://crbug.com/8526
Original Review URL: http://codereview.chromium.org/43052
TBR=ben
Review URL: http://codereview.chromium.org/42060
------------------------------------------------------------------------
|
|||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||