Issue 8519 - chromium - REGRESSION: Hovering last tab does not show title

Issue 8519:	REGRESSION: Hovering last tab does not show title
	2 people starred this issue and may be notified of changes.	Back to list

Status:	Verified
Owner:	ben.at.chromium.org
Closed:	Mar 2009
Type-Bug
Pri-2
OS-All
Area-BrowserUI
Mstone-2.0
Regression

Reported by pkasting@chromium.org, Mar 07, 2009

Hovering the last tab in the last window does not show the tab title in a 
tooltip (assuming the title is long enough to warrant this).  When there is 
more than one tab, things work.

Left this as pri 2 because it shouldn't block beta IMO

Comment 1 by sky@chromium.org, Mar 09, 2009

(No comment was entered for this change.)

Status: Assigned
Owner: s...@chromium.org

Comment 2 by sky@chromium.org, Mar 09, 2009

While we're not sure what the issue is here, the consensus seems to be to not treat 
one window with one tab case specially (NCCLIENT), which should cause the bug to go 
away. Ben says he'll do it, so assigning to him.

Owner: b...@chromium.org

Comment 3 by bugdroid1@chromium.org, Mar 09, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11299 

------------------------------------------------------------------------
r11299 | ben@chromium.org | 2009-03-09 15:29:01 -0700 (Mon, 09 Mar 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab.cc?r1=11299&r2=11298
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_strip.cc?r1=11299&r2=11298

Make the last tab part of the client area instead of the non-client as it is now.

Remove some stupid code in the Tab's mouse pressed handler that was duplicating the nc-hittest handler. o_O.

http://crbug.com/8519

Review URL: http://codereview.chromium.org/41018
------------------------------------------------------------------------

Comment 4 by ben.at.chromium.org, Mar 09, 2009

(No comment was entered for this change.)

Status: Fixed

Comment 5 by bugdroid1@chromium.org, Mar 10, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11427 

------------------------------------------------------------------------
r11427 | mal@chromium.org | 2009-03-10 21:50:53 -0700 (Tue, 10 Mar 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/tabs/tab.cc?r1=11427&r2=11426
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/tabs/tab_strip.cc?r1=11427&r2=11426

Merge r11299.

Make the last tab part of the client area instead of the non-client as it is now.

Remove some stupid code in the Tab's mouse pressed handler that was duplicating the nc-hittest handler. o_O.

BUG= 8519
TBR= ben


Review URL: http://codereview.chromium.org/42063
------------------------------------------------------------------------

Comment 6 by mberkow...@chromium.org, Mar 11, 2009

Verified in Chrome 2.0.169.1 (Official Build 11427), Chromium 2.0.170.0 (Developer
Build 11440).

Status: Verified

Comment 7 by venkataramana@chromium.org, Mar 17, 2009

Works fine in 2.0.170.0 (Official Build 11755) too.

► Sign in to add a comment