Issue 8456 - chromium - History tab search tab eats every alternate clicks

Issue 8456:	History tab search tab eats every alternate clicks
	2 people starred this issue and may be notified of changes.	Back to list

Status:	Verified
Owner:	glen@chromium.org
Closed:	Mar 2009
Cc:	laforge@chromium.org, anantha@chromium.org
Type-Bug
Pri-2
OS-All
Area-BrowserUI
Regression

Reported by venkataramana@chromium.org, Mar 05, 2009

Trunk r11074.

-Go to History tab and type a search term in the search box
-Hit Return Key/Click on the search button.

Looks like every alternate click is ate.  You will get the search results
only for 2nd click.

Comment 1 by venkataramana@chromium.org, Mar 05, 2009

Instead of filing a new issue, I'm adding similar problem with Downloads page too.

There are no issues with searching in downloads tab. But the similar problem raises
with Confirmation bar.

[On clean profile]
-Go to downloads.com pge & click middle click on few link on "Most popular downloads"
section and start download them and don't respond to dangerous downloads confirmation
bar. 
-Go to Downloads page (make you count total number downloads you kicked in)and click
on "Discard" button. For 1st click, it item is not discarded. But works fine if you
repro for 2nd time.

Summary: History tab search tab eats every alternate clicks

Comment 2 by glen@chromium.org, Mar 09, 2009

(No comment was entered for this change.)

Owner: g...@chromium.org
Cc: -g...@chromium.org

Comment 3 by bugdroid1@chromium.org, Mar 10, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11411 

------------------------------------------------------------------------
r11411 | glen@chromium.org | 2009-03-10 18:24:08 -0700 (Tue, 10 Mar 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/history_ui.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/history_ui.h?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.h?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_querying_unittest.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.h?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.h?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/history.html?r1=11411&r2=11410

Stop history search going on beyond the start of history.
Stop losing first-searches on history page due to 

BUG=8438,8456

Review URL: http://codereview.chromium.org/43054
------------------------------------------------------------------------

Comment 4 by glen@chromium.org, Mar 10, 2009

(No comment was entered for this change.)

Status: Fixed

Comment 5 by venkataramana@chromium.org, Mar 10, 2009

This rocks in r11412. We are back on track with history page again !!

Status: Verified

Comment 6 by bugdroid1@chromium.org, Mar 10, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11420 

------------------------------------------------------------------------
r11420 | mal@chromium.org | 2009-03-10 20:36:15 -0700 (Tue, 10 Mar 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/dom_ui/dom_ui_contents.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/dom_ui/history_ui.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/dom_ui/history_ui.h?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_backend.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_backend.h?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_querying_unittest.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_types.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_types.h?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/visit_database.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/visit_database.h?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/resources/history.html?r1=11420&r2=11419

Merge r11411.

Stop history search going on beyond the start of history.
Stop losing first-searches on history page due to 

BUG=8438,8456

Original Review URL: http://codereview.chromium.org/43054
TBR= glen
Review URL: http://codereview.chromium.org/43067
------------------------------------------------------------------------

► Sign in to add a comment