My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 8438: CPU pegged if history page can't be filled.
5 people starred this issue and may be notified of changes. Back to list
 
Reported by venkataramana@chromium.org, Mar 05, 2009
Trunk (r11008)

-Open history page.
-Try to execute any manu commands (Thr Page or Wrench)

The browser simply hangs there. If I close the History page, then things
looks good.

Another issue:
[With out history page] If I clear browsing history and navigate to history
page, It always says "loading.." with empty history. Looks like this is
what causing the problem ??


Comment 1 by venkataramana@chromium.org, Mar 05, 2009
Okey..here is the deal...

To better reproduce the issue, Clear browsing data for Everything and follow those
repro steps.

Summary: Browser hangs, If history page is opened after clear browsing data.
Comment 2 by laforge@chromium.org, Mar 06, 2009
(No comment was entered for this change.)
Status: Assigned
Owner: g...@chromium.org
Labels: Mstone-2.0
Comment 3 by glen@chromium.org, Mar 06, 2009
Is this a hang (browser unresponsive) or is the page just not doing anything? If you 
have no history, it spends a lot of time looking for it (long load), but shouldn't be 
unresponsive.
Comment 4 by venkataramana@chromium.org, Mar 06, 2009
It's kind of unresponsiveness. 
-Having history page opened
Try to execute any menu commands from Wrench/Page..It's hard to get them executed as
long as history tab there!!.

-Venkat.
Comment 5 by glen@chromium.org, Mar 10, 2009
 Issue 8608  has been merged into this issue.
Comment 6 by glen@chromium.org, Mar 10, 2009
(No comment was entered for this change.)
Summary: CPU pegged if history page can't be filled.
Comment 7 by pinkerton@chromium.org, Mar 10, 2009
I've seen this even when you have history (ie, you didn't just clear it) and it is
displayed correctly. The page pegs the CPU executing javascript (specifically a call
to getHistory in the browser c++). The page is respsonive and clicking history links
works, but the CPU is still pretty active. Closing the page returns cpu to normal.
Comment 8 by bugdroid1@chromium.org, Mar 10, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11411 

------------------------------------------------------------------------
r11411 | glen@chromium.org | 2009-03-10 18:24:08 -0700 (Tue, 10 Mar 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_contents.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/history_ui.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/history_ui.h?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_backend.h?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_querying_unittest.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/history_types.h?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.cc?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/visit_database.h?r1=11411&r2=11410
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/history.html?r1=11411&r2=11410

Stop history search going on beyond the start of history.
Stop losing first-searches on history page due to 

BUG=8438,8456

Review URL: http://codereview.chromium.org/43054
------------------------------------------------------------------------

Comment 9 by glen@chromium.org, Mar 10, 2009
(No comment was entered for this change.)
Status: Fixed
Comment 10 by venkataramana@chromium.org, Mar 10, 2009
This rocks in r11412. We are back on track with history page again !!

Status: Verified
Comment 11 by bugdroid1@chromium.org, Mar 10, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11420 

------------------------------------------------------------------------
r11420 | mal@chromium.org | 2009-03-10 20:36:15 -0700 (Tue, 10 Mar 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/dom_ui/dom_ui_contents.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/dom_ui/history_ui.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/dom_ui/history_ui.h?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_backend.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_backend.h?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_querying_unittest.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_types.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/history_types.h?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/visit_database.cc?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/history/visit_database.h?r1=11420&r2=11419
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/resources/history.html?r1=11420&r2=11419

Merge r11411.

Stop history search going on beyond the start of history.
Stop losing first-searches on history page due to 

BUG=8438,8456

Original Review URL: http://codereview.chromium.org/43054
TBR= glen
Review URL: http://codereview.chromium.org/43067
------------------------------------------------------------------------

Sign in to add a comment

Powered by Google Project Hosting