Issue 8410 - chromium - Omnibox editable area floats after returning from a locked screen.

Status:	Verified
Owner:	pkasting@chromium.org
Closed:	Mar 2009
Type-Bug
Pri-2
OS-All
Area-BrowserUI
Regression
Mstone-2.0

Sign in to add a comment

Reported by laforge@chromium.org, Mar 04, 2009

Chrome Version: 2.0.168.0 (Developer Build 10924)

What steps will reproduce the problem?
1. Open Chrome
2. Open a url like cnn.com
3. Lock your screen
4. Unlock your screen

What is the expected output? What do you see instead?

Editable area in Omnibox is floating higher (and outside of) each time the 
screen is locked and unlocked... see attached screenshot.

Expected Results:

Editable area should be within the bounds of the Omnibox.

	floating omnibox 2.png 20.7 KB View Download

	floating omnibox.png 17.2 KB View Download

Comment 1 by laforge@chromium.org, Mar 04, 2009

After testing a bunch of Chromium builds, I found that I need to add one more step... 
browser needs to be full screen.

Comment 2 by laforge@chromium.org, Mar 04, 2009

Happened after 10844.
Found in 10885.

So it happened between 5PM on the 3rd and midnight.  I'll try and isolate more after 
dinner.

Comment 3 by laforge@chromium.org, Mar 04, 2009

- To narrow things down (happened between r10844 and r10859)

- Reverting 10850, 10848, and 10845 off of ToT got rid of the problem on my local 
build, so my guess is these are the cause.

Owner: pkast...@chromium.org
Labels: -Pri-2 Pri-1

Comment 4 by jon@chromium.org, Mar 05, 2009

Should not block beta.

Labels: -Pri-1 Pri-2

Comment 5 by venkataramana@chromium.org, Mar 05, 2009

Build: 2.0.169.0 (Developer Build 11008)

Just an update:

Also notice the '+' button issue and the right and bottom sides of the window are
covered by black background.
Screenshot attached.

Comment 6 by venkataramana@chromium.org, Mar 05, 2009

This time with attachment :)

	8410.PNG 377 KB View Download

Comment 7 by pkasting@chromium.org, Mar 09, 2009

(No comment was entered for this change.)

Labels: -Pri-2 Pri-1

Comment 8 by pkasting@chromium.org, Mar 09, 2009

Lowering to P2 since with the revert of r10845 this should no longer actually be 
visible, but not closing so I know I need to prevent this from happening again.

Labels: -Pri-1 Pri-2

Comment 9 by bugdroid1@chromium.org, Mar 10, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11355 

------------------------------------------------------------------------
r11355 | pkasting@chromium.org | 2009-03-10 12:09:07 -0700 (Tue, 10 Mar 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_frame.cc?r1=11355&r2=11354
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_frame.h?r1=11355&r2=11354
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/glass_browser_frame_view.cc?r1=11355&r2=11354
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/glass_browser_frame_view.h?r1=11355&r2=11354
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/opaque_browser_frame_view.cc?r1=11355&r2=11354
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/win_util.cc?r1=11355&r2=11354
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/win_util.h?r1=11355&r2=11354
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/window.cc?r1=11355&r2=11354

Make Chromium windows not hide auto-hide taskbars, take 2.

This is very similar to r10845, but also includes a regression fix for  issue 8410 , where locking and unlocking the screen would cause mispositioning of child content.

BUG=20,8410

Review URL: http://codereview.chromium.org/42027
------------------------------------------------------------------------

Comment 10 by pkasting@chromium.org, Mar 10, 2009

Fixed in r11355.

Status: Fixed

Comment 11 by bugdroid1@chromium.org, Mar 10, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=11416 

------------------------------------------------------------------------
r11416 | mal@chromium.org | 2009-03-10 20:12:28 -0700 (Tue, 10 Mar 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/browser_frame.cc?r1=11416&r2=11415
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/browser_frame.h?r1=11416&r2=11415
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/glass_browser_frame_view.cc?r1=11416&r2=11415
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/glass_browser_frame_view.h?r1=11416&r2=11415
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/browser/views/frame/opaque_browser_frame_view.cc?r1=11416&r2=11415
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/common/win_util.cc?r1=11416&r2=11415
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/common/win_util.h?r1=11416&r2=11415
   M http://src.chromium.org/viewvc/chrome/branches/169/src/chrome/views/window.cc?r1=11416&r2=11415

Merge r11355

Make Chromium windows not hide auto-hide taskbars, take 2.

This is very similar to r10845, but also includes a regression fix for  issue 8410 , where locking and unlocking the screen would cause mispositioning of child content.

Original Review URL: http://codereview.chromium.org/42027

BUG=20,8410
TBR= pkasting
Review URL: http://codereview.chromium.org/43066
------------------------------------------------------------------------

Comment 12 by venkataramana@chromium.org, Mar 12, 2009

 Issue 8699  has been merged into this issue.

Comment 13 by venkataramana@chromium.org, Mar 17, 2009

Works fine in 2.0.170.0 (Official Build 11755).

Status: Verified

Issue 8410:	Omnibox editable area floats after returning from a locked screen.
	2 people starred this issue and may be notified of changes.	Back to list