(No comment was entered for this change.)

(No comment was entered for this change.)

(No comment was entered for this change.)

(No comment was entered for this change.)

Removing mstone:mac label and applying mstone:macdev label.  MacDev indicates 
that this issue is required for Chrome for Mac to be released to testers and 
eventually the Dev Channel.  Mston:Mac is no longer used.

(No comment was entered for this change.)

Adding the releasenotes label, in hopes of making this a tracking bug for the Mac OS
known issue:
The Bookmarks toolbar is not populated, though sites will show up in the Bookmarks
menu in the menu bar if you star them.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=18340 

------------------------------------------------------------------------
r18340 | jrg@chromium.org | 2009-06-12 17:53:18 -0700 (Fri, 12 Jun 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=18340&r2=18339
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cocoa_utils.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cocoa_utils.mm
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cocoa_utils_unittest.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=18340&r2=18339
   M http://src.chromium.org/viewvc/chrome/trunk/src/skia/skia.gyp?r1=18340&r2=18339

Add favicons to Mac bookmark bar.
BUG=8381

TEST=Open bookmark bar (Cmd-B).  Add some bookmarks with sites that
have favicons (cnn.com).  See icons in bookmark buttons.  Make sure
color is correct.

Review URL: http://codereview.chromium.org/125061
------------------------------------------------------------------------

Should have been a P1.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20244 

------------------------------------------------------------------------
r20244 | jrg@chromium.org | 2009-07-08 21:45:07 -0700 (Wed, 08 Jul 2009) | 25 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=20244&r2=20243
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=20244&r2=20243

- Fix janklist issue #1: "there is a pixel line below the main
  toolbar. The main toolbar should blend in with the bookmark bar when
  it's open"
- Fix janklist  issue #2 : "It's way too tall - the distance from the
  bottom of the bar to a bookmark button bottom edge should be the
  same as the distance from the omnibox to the bookmark button top
  edge (this will probably mean that the bar has to overlap the
  toolbar)."
- Fix janklist  issue #4  (first part): "the bookmark bar bookmark buttons
  have a frame around them ... "
- Fix janklist  issue #9 : "the show/hide animation is very janky... I see
  a dark gray area behind".  Even with animators the grey is gone, but
  animators are disabled for now due to races.
- Fix unlisted jank related to 9: don't use animator when opening bar on
  launch.
- Also chipped away on unit tests.

TEST=Launch with bookmark bar both open and closed.  Make sure OK on launch.
In each case open and close a few times fast.
Repeat with multiple windows open.
Sanity check jank descriptions listed above are fixed.

BUG=crbug.com/14139, crbug.com/8381, crbug.com/14724

Review URL: http://codereview.chromium.org/149308
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20591 

------------------------------------------------------------------------
r20591 | jrg@chromium.org | 2009-07-13 17:58:17 -0700 (Mon, 13 Jul 2009) | 32 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/en.lproj/BookmarkBar.xib
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.h?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_view.h?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_button_cell_unittest.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell.h?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell_unittest.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_window_controller.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=20591&r2=20590
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=20591&r2=20590

More bookmark bar changes.

* Applied memory cleanliness fix in unit test; follow-up from
  http://codereview.chromium.org/149308.
* Move bookmark bar into it's own nib; minor code refactor to
  accomodate.
* The toolbar STAR button somehow lost it's action; added it back in.
* Implemented delete bookmark notification callback so we behave
  (remove button from the screen) when a bookmark is deleted.
* Added context menus for the bookmark bar and bookmark buttons.
* Hooked up a handful of these menu items.  E.g. 
 - open in new tab, window, incog window
 - delete bookmark (finally)
 - bookmark manager (which then hits a NOTIMPLEMENTED())
 - always show bookmark bar
* Truncate bookmark button text on end, not on middle.
  Experimental to look more like Windows.  
  It looks cleaner but is less Mac-like.
* Add "draws border when mouse goes over" for bookmark buttons.  Need
  to do it by hand since we have a custom button drawing method.

BUG=crbug.com/8381

TEST=Here's a list:
- Make sure the bookmark buttons don't have a border unless the mouse is over them
- Toolbar "STAR" should now add bookmarks when clicked
- Test context menus on bookmark buttons, and the bar itself
- Confirm a few of the behaviors as listed in the 'what I hooked up'; e.g.
  Right click on bookmark --> delete menu item should delete button


Review URL: http://codereview.chromium.org/155358
------------------------------------------------------------------------

For me, all 4 tests pass successfully.

May I suggest adapting the width used by each bookmark so that there isn't so much  
blank space between bookmarks with short names? See attached image.

	bookmarks bar build 20848.jpg 59.9 KB   View   Download

lucky0, it's on the TODO list.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=21241 

------------------------------------------------------------------------
r21241 | jrg@chromium.org | 2009-07-21 16:57:19 -0700 (Tue, 21 Jul 2009) | 14 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkBar.xib?r1=21241&r2=21240
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkEditor.xib
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=21241&r2=21240
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=21241&r2=21240
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=21241&r2=21240
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_controller.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=21241&r2=21240

Implement bookmark editor.  No tree display or hierarchy movement, but
name/url editing works.  Get to the edotir from a context menu (Edit,
Add Page).  Also Implement Open All Bookmarks menu item.

BUG=http://crbug.com/8381, http://crbug.com/17006 

TEST=Add some bookmarks.  
Right-click on a bookmark and pick Edit.
Test editing the name and URL.  Make sure you can't add a bogus URL.
Right-click on a bookmark or the bar and Add Page.
Fill in name and URL fields to add a new bookmark.
Right-click Open All Bookmarks and make sure it hoses your machine.

Review URL: http://codereview.chromium.org/155874
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=21479 

------------------------------------------------------------------------
r21479 | jrg@chromium.org | 2009-07-23 16:56:19 -0700 (Thu, 23 Jul 2009) | 28 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkBar.xib?r1=21479&r2=21478
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=21479&r2=21478
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=21479&r2=21478
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=21479&r2=21478
   D /trunk/src/chrome/browser/cocoa/bookmark_bar_view.h
   D /trunk/src/chrome/browser/cocoa/bookmark_bar_view.mm
   D /trunk/src/chrome/browser/cocoa/bookmark_bar_view_unittest.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_menu_bridge.mm?r1=21479&r2=21478
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.h?r1=21479&r2=21478
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_menu_cocoa_controller.mm?r1=21479&r2=21478
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=21479&r2=21478

Added menus for bookmark bar folders.  This is NOT based on the Cole
prototype; it is an attempt to get something functional in the short
term, and have a visual baseline before doing something new.

Added folder icons for bookmark bar folder buttons.  Added an "off the
side" button/menu for bookmark buttons which don't fit on the bar.
Updated "Add page..." item to allow creating bookmarks in the folders
(if selected over a folder button).

BUG=http://crbug.com/8381

TEST=Here we go:
1) Make sure bookmark bar folders have the "folder" icon.
2) Right click on a folder --> Add Page, and add a bookmark.
   Make sure bookmark is now in the folder, not at the top level.
3) (Oh, you just implicitly verified you can open bookmark folders!)
4) Add 5 bookmarks then shrink the window thinner so all bookmark
  buttons don't fit.  Make sure "off the right" button gets enabled
  (on right side of bar) and shows bookmarks in a pop-up menu (when
  clicked) that don't completely fit on the bar.
5) Make it super-wide so the all fit and make sure "off the right"
  button is disabled.
6) Add a bunch of bookmarks to a folder; make sure they all work.
7) Add nested folders (by editing the bookmark pref file and restarting
   Chrome) and make sure bookmark folder buttons have nested/cascading
   menus.

Review URL: http://codereview.chromium.org/159286
------------------------------------------------------------------------

This is a release blocker for Mac Beta.

We are deprecating the MacBeta milestone in favor of ReleaseBlock-Beta and 
a milestone.

We assume BMB is implemented. For individual problems, we have filed bugs so closing
this.