My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 7851: AddSearchProvider parses name and keyword from description address not the described address
8 people starred this issue and may be notified of changes. Back to list
Status:  Available
Owner:  ----
Cc:  sky@chromium.org
Type-Bug
Pri-2
OS-All
Area-BrowserUI
Mstone-X
Feature-Omnibox


Sign in to add a comment
 
Reported by mycroft.mozdev.org, Feb 19, 2009
Chrome Version       : 1.0.154.48
URLs (if applicable) : eg http://mycroft.mozdev.org/youtube-search-plugins.html
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 3:
    Firefox 3: OK
         IE 7: OK

What steps will reproduce the problem?
1. Visit http://mycroft.mozdev.org/youtube-search-plugins.html
2. Click on 'YouTube' to install Youtube search provider.
3. Note Name and Keyword filled with mycroft.mozdev.org

What is the expected result?
Name and Keyword filled with YouTube

What happens instead?

Please provide any additional information below. Attach a screenshot if
possible.

Comment 1 by mycroft.mozdev.org, Feb 19, 2009
Also in 2.0.164.0
Comment 2 by bhb123, Jun 23, 2009
This still seems to be a problem.
Comment 3 by phajdan...@chromium.org, Nov 16, 2009
Chrome 3.0.195.33 indeed behaves in the described way.

pkasting, could you triage this?
Status: Untriaged
Owner: pkast...@chromium.org
Labels: -Area-Misc Area-BrowserUI Feature-Omnibox
Comment 4 by pkasting@chromium.org, Nov 16, 2009
Looks like a bug to me.  The relevant OSDD is at
view-source:http://mycroft.mozdev.org/installos.php/13110/youtube.xml

We at least should be setting the Keyword to "youtube.com" from the <Url>.  I am not 
sure whether we should also set the Name to "YouTube" from the <ShortName>.  It would 
be a good thing in this case, maybe a bad thing on some autodetected OSDDs.  Perhaps we 
should use the short name iff we're getting an AddSearchProvider() call directly?
Owner: s...@chromium.org
Labels: -Feature-Omnibox
Comment 5 by mycroft.mozdev.org, Nov 16, 2009
I'm not sure in what circumstances parsing a name from the description address is
going to be better than using the ShortName... At the very least parse the url in the
description.

Also, the icon (in edit search engines) seems to be picked up from the favicon of the
url rather than looking at the image tag in the description. Want me to file a
separate issue for that?
Comment 6 by laforge@chromium.org, Nov 17, 2009
(No comment was entered for this change.)
Labels: Mstone-X
Comment 7 by alexb17, Nov 22 (2 days ago)
This issue is still relevant, even in the latest dev release (4.0.249.4).
Comment 8 by laforge@chromium.org, Today (15 hours ago)
(No comment was entered for this change.)
Status: Available
Owner: ---
Cc: s...@chromium.org
Labels: Feature-Omnibox
Sign in to add a comment