| Issue 7673: | Sad face not displayed after a plugin crash | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Chrome 2.0.163.0 (9655) What steps will reproduce the problem? 1. Go to a page using a plugin i.e. http://go/compat/plugins_testing/QT_HTML_param_testcases/AutoHREF_True.html or youtube.com 2. Bring up the task manager and end the process for the plugin What is the expected output? A sad face should be seen. In case of youtube, the main video using flash doesn't show the sad face but the ad on side shows the sad face. What do you see instead? Nothing Please use labels and text to provide additional information.
Comment
1
by
aoca...@chromium.org,
Feb 19, 2009
,
Mar 4, 2009
(No comment was entered for this change.)
Status: Started
Owner: ana...@chromium.org
,
Mar 4, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=10960
------------------------------------------------------------------------
r10960 | ananta@chromium.org | 2009-03-04 18:07:18 -0800 (Wed, 04 Mar 2009) | 10 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.cc?r1=10960&r2=10959
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.h?r1=10960&r2=10959
Ensure that we display a sad face for a windowed plugin when the plugin process crashes. This was a regression introduced by creating the plugin parent on the browser UI thread, which remains valid when the plugin process crashes.
The fix is to track plugin wrapper windows in the PluginProcessHost class and destroy any remaining windows in the destructor. Removed the DestroyWindowTask
which destroys the windows on the UI thread. We can achieve the same result by posting WM_CLOSE messages to these windows.
This fixes http://code.google.com/p/chromium/issues/detail?id=7673
Bug=7673
Review URL: http://codereview.chromium.org/40120
------------------------------------------------------------------------
,
Mar 4, 2009
(No comment was entered for this change.)
Status: Fixed
,
Mar 5, 2009
Verified on 2.0.268.0 (10990)
Status: Verified
,
Dec 18, 2009
(No comment was entered for this change.)
Labels: -Area-Plugins Area-Internals Internals-Plugins
,
Mar 18, 2011
Chrome 2.0.163.0 (9655) <b>What steps will reproduce the problem?</b> 1. Go to a page using a plugin i.e. http://go/compat/plugins_testing/QT_HTML_param_testcases/AutoHREF_True.html or youtube.com 2. Bring up the task manager and end the process for the plugin What is the expected output? A sad face should be seen. In case of youtube, the main video using flash doesn't show the sad face but the ad on side shows the sad face. What do you see instead? Nothing <b>Please use labels and text to provide additional information.</b>
Labels: -Regression bulkmove Type-Regression
|
||||||||||
| ► Sign in to add a comment | |||||||||||