My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 6125: [edit search engines] after hitting right ctrl+shift, can't change insersion point with the mouse
2 people starred this issue and may be notified of changes. Back to list
Status:  Verified
Owner:  x...@chromium.org
Closed:  Apr 2009
Cc:  id...@chromium.org, jeremy@chromium.org, xlyuan@chromium.org, jshin@chromium.org, hb...@chromium.org, x...@chromium.org
RTL

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by x...@chromium.org, Jan 7, 2009
<see b\1329600>

What steps will reproduce the problem?
1) Open Chrome, Hebrew UI
2) right click on the omni bar, and select "edit search engines"
3) select any search engine and click "edit"
4) hit right + ctrl shift, in the name or keyword area, to set the box to
RTL mode
5) try to change the location of the insertion point by clicking with the
mouse at the middle or the end of the text


What is the expected output? What do you see instead?
actual result:
after hitting right ctrl shift, insertion point from the mouse is always
the rightmost one

expected result:
user should be able to click anywhere to change insertion point

Please use labels and text to provide additional information.
* moving the insertion point with the keyboard works as expected
* hitting left ctrl +shift (for LTR) does not cause a similar problem
* Wordpad works ok for the above keyboard/mouse movement.



Jan 8, 2009
#1 x...@chromium.org
(No comment was entered for this change.)
Cc: id...@chromium.org jer...@chromium.org xly...@chromium.org js...@chromium.org hb...@chromium.org x...@chromium.org
Labels: I18N RTL
Jan 22, 2009
#2 x...@chromium.org
(No comment was entered for this change.)
Status: Assigned
Apr 15, 2009
#3 prog...@gmail.com
very much like  Issue 8686 
Apr 15, 2009
#4 x...@chromium.org
progame, yes, you are right.
they are both text field, which is CRichEditCtrl, and there is problem in cursor 
positioning and cursor selection in the presence of RTL characters.
Apr 21, 2009
#5 x...@chromium.org
review URL:
http://codereview.chromium.org/86003

fixed in r14158
Status: Fixed
Apr 21, 2009
#6 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=14158 

------------------------------------------------------------------------
r14158 | xji@chromium.org | 2009-04-21 16:44:02 -0700 (Tue, 21 Apr 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc?r1=14158&r2=14157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/controls/text_field.cc?r1=14158&r2=14157

This CL fixes 
 issue 6125  - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse
and 
 issue 8686  - RTL: Can't select RTL text from Chrome UI boxes

The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout).

The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in  https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605

BUG=6125
BUG=8686

Review URL: http://codereview.chromium.org/86003
------------------------------------------------------------------------

Apr 23, 2009
#7 xlyuan@chromium.org
Verified on 2.0.176.0 (Official Build ), fixed.
Status: Verified
May 1, 2009
#8 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=15136 

------------------------------------------------------------------------
r15136 | mal@chromium.org | 2009-05-01 23:47:30 -0700 (Fri, 01 May 2009) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/browser/autocomplete/autocomplete_edit_view_win.cc?r1=15136&r2=15135
   M http://src.chromium.org/viewvc/chrome/branches/172/src/chrome/views/controls/text_field.cc?r1=15136&r2=15135

Merge r14158.

This CL fixes 
 issue 6125  - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse
and 
 issue 8686  - RTL: Can't select RTL text from Chrome UI boxes

The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout).

The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in  https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605

BUG=6125
BUG=8686
TBR= xji

Review URL: http://codereview.chromium.org/100296
------------------------------------------------------------------------

Mar 18, 2011
#9 lafo...@chromium.org
&lt;see b\1329600&gt;

<b>What steps will reproduce the problem?</b>
1) Open Chrome, Hebrew UI
2) right click on the omni bar, and select &quot;edit search engines&quot;
3) select any search engine and click &quot;edit&quot;
4) hit right + ctrl shift, in the name or keyword area, to set the box to
RTL mode
5) try to change the location of the insertion point by clicking with the
mouse at the middle or the end of the text


<b>What is the expected output? What do you see instead?</b>
actual result:
after hitting right ctrl shift, insertion point from the mouse is always
the rightmost one

expected result:
user should be able to click anywhere to change insertion point

<b>Please use labels and text to provide additional information.</b>
* moving the insertion point with the keyboard works as expected
* hitting left ctrl +shift (for LTR) does not cause a similar problem
* Wordpad works ok for the above keyboard/mouse movement.
Labels: -I18N bulkmove Feature-I18N
Oct 12, 2012
#10 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#11 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Feature-I18N Cr-UI-I18N
Mar 20, 2013
#12 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-UI-I18N Cr-UI-Internationalization
Sign in to add a comment

Powered by Google Project Hosting