My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 6103: Individual download items on the download shelf are not mirrored on RTL locales
3 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  x...@chromium.org
Closed:  Jun 2009
Cc:  id...@chromium.org, jeremy@chromium.org, xlyuan@chromium.org, jshin@chromium.org, hb...@chromium.org
RTL

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by x...@chromium.org, Jan 7, 2009
<see b\1163334>

What steps will reproduce the problem?
run RTL Chrome and download a file 

What is the expected output? What do you see instead?
When running the Hebrew version on Chrome and downloading files, download 
items on the download shelf correctly appear from right to left. However, 
each individual item is not mirrored. Specifically:

1) The item drop down arrow resides on the right hand side of the item and 
not the left hand side.
2) The animation is drawn on the left and side instead of the right hand 
side.


Please use labels and text to provide additional information.


Jan 13, 2009
#1 lafo...@chromium.org
(No comment was entered for this change.)
Status: Assigned
Owner: id...@chromium.org
Apr 22, 2009
#2 jeremy@chromium.org
(No comment was entered for this change.)
Cc: x...@chromium.org
May 19, 2009
#3 yusukes+personal@google.com
Hi Idan,
Can I work on this? If you already created patches for this, please let me know.


Status: Started
Owner: yusu...@google.com
May 19, 2009
#4 jeremy@chromium.org
In general if the bug isn't marked as started you can change the status and add yourself 
as an owner, then it's all yours! :)
Thanks for tackling this issue!
May 19, 2009
#5 x...@chromium.org
Thanks for working on this!

In case you did not notice. 
There are 2 comments about this bug in download_item_view.cc. You can search for 
1163334 for the comments.

One comments mentioned the following which I did not quite understand. Please make 
sure you understand it and keep the animation works when fixing it.

  // We explicitly disable mirroring for the item because the code that draws
  // the download progress animation relies on the View's UI layout setting
  // when positioning the animation so we should make sure that code doesn't
  // treat our View as a mirrored View.
May 21, 2009
#6 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=16616 

------------------------------------------------------------------------
r16616 | xji@chromium.org | 2009-05-21 10:11:21 -0700 (Thu, 21 May 2009) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/download_started_animation_win.cc?r1=16616&r2=16615

This is the merge of Yusuke's patch at:
http://codereview.chromium.org/113583

Draw the big arrow animation on the right side on RTL locales.

1) The item drop down arrow resides on the right hand side of the item and 
not the left hand side.
2) The animation is drawn on the left and side instead of the right hand
side.

This patch only fixes the  issue 2 ) above. I'll fix 1) in separate change list.

BUG=http://crbug.com/6103
TBR=Yusuke
Review URL: http://codereview.chromium.org/115609
------------------------------------------------------------------------

Jun 3, 2009
#7 yusukes+personal@google.com
(No comment was entered for this change.)
Owner: x...@chromium.org
Cc: -x...@chromium.org yusu...@google.com
Jun 12, 2009
#8 x...@chromium.org
Review URL: http://codereview.chromium.org/118260
fixed in r18292
Status: Fixed
Cc: -yusu...@google.com
Mar 18, 2011
#9 lafo...@chromium.org
(No comment was entered for this change.)
Labels: -I18N bulkmove Feature-I18N
Oct 12, 2012
#10 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#11 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Feature-I18N Cr-UI-I18N
Mar 20, 2013
#12 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-UI-I18N Cr-UI-Internationalization
Sign in to add a comment

Powered by Google Project Hosting