My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 55165: third_party/libvpx has unclear license
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  fbarch...@chromium.org
Closed:  Nov 2010
Cc:  scherkus@chromium.org
M-9

Blocking:
issue 28291

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Project Member Reported by phajdan.jr@chromium.org, Sep 10, 2010
$ tools/licenses.py scan
third_party/libvpx: License file not found. Either add a file named LICENSE, import upstream's COPYING if available, or add a 'License File:' line to README.chromium with the appropriate path.

Sep 14, 2010
#1 phajdan.jr@chromium.org
(No comment was entered for this change.)
Owner: fbarch...@chromium.org
Cc: scher...@chromium.org
Sep 14, 2010
#2 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59444

------------------------------------------------------------------------
r59444 | fbarchard@chromium.org | Tue Sep 14 15:48:49 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/libvpx/README.chromium?r1=59444&r2=59443&pathrev=59444

add reference to license file for libvpx
BUG=55165
TEST=none

Review URL: http://codereview.chromium.org/3449002
------------------------------------------------------------------------
Sep 14, 2010
#3 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59445

------------------------------------------------------------------------
r59445 | tomfinegan@google.com | Tue Sep 14 15:50:03 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/libvpx/README.chromium?r1=59445&r2=59444&pathrev=59445

Add path to license file, and link to webmproject.org.

TBR=fbarchard
BUG=55165
TEST=none

Review URL: http://codereview.chromium.org/3433007
------------------------------------------------------------------------
Sep 14, 2010
#4 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59450

------------------------------------------------------------------------
r59450 | fbarchard@chromium.org | Tue Sep 14 16:16:41 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=59450&r2=59449&pathrev=59450

libvpx roll for readme to point to license file
BUG=55165
TEST=none

Review URL: http://codereview.chromium.org/3426004
------------------------------------------------------------------------
Sep 14, 2010
#5 fbarch...@chromium.org
(No comment was entered for this change.)
Status: Fixed
Sep 15, 2010
#6 phajdan.jr@chromium.org
I think that README.chromium is not fetched via DEPS, only lib and include directories. Could you take another look? Also, please verify via tools/licenses.py scan whether there are no more problems with this directory.
Status: Assigned
Nov 2, 2010
#7 fbarch...@chromium.org
@phajdan.jr you're right.
Status: Started
Labels: -Area-Undefined Area-WebKit Feature-Media webm Mstone-9
Nov 2, 2010
#8 fbarch...@chromium.org
pulling in full libvpx fixes the issue.

before
third_party\libvpx: missing README.chromium
after
(no warning)


Nov 3, 2010
#9 fbarch...@chromium.org
fixed in CL64923
Status: Fixed
Nov 3, 2010
#10 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=64923

------------------------------------------------------------------------
r64923 | fbarchard@chromium.org | Wed Nov 03 09:45:13 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=64923&r2=64922&pathrev=64923

pull in full libvpx tree from deps to include license
BUG=55165
TEST=tools/licenses.py 
Review URL: http://codereview.chromium.org/4345001
------------------------------------------------------------------------
Nov 3, 2010
#11 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=64927

------------------------------------------------------------------------
r64927 | rafaelw@chromium.org | Wed Nov 03 09:58:24 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=64927&r2=64926&pathrev=64927

Revert 64923 - pull in full libvpx tree from deps to include license
BUG=55165
TEST=tools/licenses.py 
Review URL: http://codereview.chromium.org/4345001

TBR=fbarchard@chromium.org
Review URL: http://codereview.chromium.org/4365002
------------------------------------------------------------------------
Nov 3, 2010
#12 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=64931

------------------------------------------------------------------------
r64931 | fbarchard@chromium.org | Wed Nov 03 10:34:40 PDT 2010

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/libvpx/libvpx.gyp?r1=64931&r2=64930&pathrev=64931

move full libvpx tree into deps to include license and gyp
BUG=55165
TEST=tools/licenses.py

Review URL: http://codereview.chromium.org/4272004
------------------------------------------------------------------------
Nov 3, 2010
#13 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=64996

------------------------------------------------------------------------
r64996 | fbarchard@chromium.org | Wed Nov 03 17:08:47 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=64996&r2=64995&pathrev=64996
 D http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libvpx?r1=64996&r2=64995&pathrev=64996

move full libvpx tree into deps to include license and gyp
BUG=55165
TEST=tools/licenses.py

Review URL: http://codereview.chromium.org/4341005
------------------------------------------------------------------------
Oct 12, 2012
#14 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Blocking: -chromium:28291 chromium:28291
Mar 10, 2013
#15 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-WebKit -Feature-Media -Mstone-9 Cr-Content Cr-Internals-Media M-9
Mar 13, 2013
#16 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Apr 5, 2013
#17 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content Cr-Blink
Sign in to add a comment

Powered by Google Project Hosting