My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 5490: "http://тест" and "http://тест(" displayed very differently in Omnibox dropdown
7 people starred this issue and may be notified of changes. Back to list
 
Reported by mahaniok, Dec 13, 2008
Chrome Version       : 0.4.154.33
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 3:
Firefox 3:
IE 7:

What steps will reproduce the problem?
1. Start typing "(тест" into an address bar. 

What is the expected result?
Should suggest to go to "%28тест" site.

What happens instead?
Chrome suggests to go to "ɢ%2ɢ8ɚɢ/" site.

Please provide any additional information below. Attach a screenshot if 
possible.

So, if you start typing with a punctuation symbol (e.g. '(', ')', '"') and 
after that type Cyrillics, it provides messed up suggestion (wrong 
encoding, %28 are dispersed in it). Works ok with Latin letters.

This is mostly visible when trying to construct complex search query.

See screenshot.
Fullscreen capture 13.12.2008 134819.jpg
32.0 KB   View   Download
Comment 1 by xlyuan@chromium.org, Dec 18, 2008
I am able to reproduce this on the latest branch and trunk build, another similar
bug:  issue 4953 

Checked on:
1.0.154.39 (Official Build 7051)
1.0.155.0  (Developer Build 7219)
Status: Untriaged
Cc: js...@chromium.org pkast...@chromium.org hb...@chromium.org
Labels: I18N
Comment 2 by pkasting@chromium.org, Dec 18, 2008
Might be a GURL issue (haven't checked)
Cc: bre...@chromium.org
Comment 3 by laforge@chromium.org, Jan 27, 2009
(No comment was entered for this change.)
Status: Assigned
Owner: js...@chromium.org
Labels: Mstone-2.0
Comment 4 by laforge@chromium.org, Jan 27, 2009
(No comment was entered for this change.)
Labels: -Area-Misc Area-BrowserUI
Comment 5 by jon@chromium.org, Apr 03, 2009
Moving from milestone 2 to milestone 2.1.
Labels: JonMoved Mstone-2.1
Comment 6 by mal.chromium, May 20, 2009
(No comment was entered for this change.)
Labels: 2.1-I18N-Candidates
Comment 7 by laforge@chromium.org, May 22, 2009
(No comment was entered for this change.)
Labels: -jonmoved
Comment 8 by laforge@chromium.org, May 22, 2009
(No comment was entered for this change.)
Labels: -mstone-2.1 mstone-3
Comment 9 by rymboy, Jun 10, 2009
If i'm not mistaken this is just the Unicode (not sure) character of the parenthesis 
(which is U+0028 or %28) It's the same as when you enter a space in an address you will 
get %20. Also when you're using the search function you can always add a question mark 
in front of your sentence, so Chrome wont try to look for a website.
Comment 10 by pkasting@chromium.org, Jun 10, 2009
At this point the repro steps have changed slightly.  Prepend a scheme.  Changing 
summary to match.

This looks like some sort of strangeness with escaping or unescaping.  Brett is the 
most appropriate person to look.
Summary: "http://тест" and "http://тест(" displayed very differently in Omnibox dropdown
Owner: bre...@chromium.org
Cc: -js...@chromium.org -pkast...@chromium.org -hb...@chromium.org -bre...@chromium.org
Comment 11 by jshin@chromium.org, Jun 25, 2009
(No comment was entered for this change.)
Cc: c...@chromium.org js...@chromium.org
Comment 12 by laforge@chromium.org, Jul 15, 2009
(No comment was entered for this change.)
Owner: xly...@chromium.org
Comment 13 by xlyuan@chromium.org, Jul 16, 2009
In Chrome build 2.X, when type a key word in Omnibox, Chrome suggests http://keyword as 
the second item under Omnibox auto-complete pop-up, and it has problem if the keyword 
contains punctuations.

But we removed this suggestion on Omnibox2, so this bug is not valid anymore (Please 
refer to my screenshot attached), and I am closing this bug now.
 
Suggestion_Removed.jpg
240 KB   View   Download
Status: WontFix
Comment 14 by mahaniok, Jul 16, 2009
Xlyuan, this bug is very valid in Omnibox2. Notice that the description of the bug 
speaks about "http://тест("; try entering it, it still shows the bug in 3.0.193.0. 
Please reopen the bug.
Comment 15 by xlyuan@chromium.org, Jul 17, 2009
Ah, you are right, thanks for your update, I am reopening this bug now :-)

Sorry, I missed this because I just tried typing тест(
Status: Untriaged
Owner: bre...@chromium.org
Comment 16 by jshin@chromium.org, Jul 29, 2009
Brett must be too busy. 

Cira, can you take a look at it? I think it might not be that hard to get to the bottom of 
this. 
Owner: c...@chromium.org
Cc: -c...@chromium.org bre...@chromium.org pkast...@chromium.org
Comment 17 by jshin@chromium.org, Jul 31, 2009
Cira identified the cause and began to work on a fix. 

Status: Started
Comment 18 by c...@chromium.org, Jul 31, 2009
We were escaping punicode string after it was created (url_canon_host.cc, DoIDNHost). 
Mailed patch to Brett couple minutes ago.
Comment 20 by jshin@chromium.org, Aug 11, 2009
 Issue 4953  has been merged into this issue.
Cc: tak...@google.com thatan...@google.com hb...@chromium.org xly...@chromium.org
Comment 21 by jshin@chromium.org, Aug 12, 2009
Cira, can you point to Anthony in what revision of googleurl has your fix? Or, you can 
update the entry for googleurl in our DEPS file once it's checked in googleurl. 

Then, that DEPS change need  be picked up by 3.0 branch. 
Labels: -2.1-I18N-Candidates
Comment 22 by brettw, Aug 13, 2009
I haven't checked it in yet, will do so today.
Comment 23 by c...@chromium.org, Aug 14, 2009
Just ping me when you do.
Comment 25 by bugdroid1@chromium.org, Aug 21, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=23965 

------------------------------------------------------------------------
r23965 | cira@chromium.org | 2009-08-21 09:35:17 -0700 (Fri, 21 Aug 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=23965&r2=23964
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/temp_gyp/googleurl.gyp?r1=23965&r2=23964
   M http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_transaction_unittest.cc?r1=23965&r2=23964

Pulling new version of googleurl into the tree.
Fixing a net_unittest case that wasn't updated when googleurl code was changed (but not down integrated to chrome).

BUG=5490

Review URL: http://codereview.chromium.org/174093
------------------------------------------------------------------------

Comment 26 by bugdroid1@chromium.org, Aug 26, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=24464 

------------------------------------------------------------------------
r24464 | laforge@chromium.org | 2009-08-26 10:30:58 -0700 (Wed, 26 Aug 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/195/src/DEPS?r1=24464&r2=24463
   M http://src.chromium.org/viewvc/chrome/branches/195/src/build/temp_gyp/googleurl.gyp?r1=24464&r2=24463
   M http://src.chromium.org/viewvc/chrome/branches/195/src/net/http/http_network_transaction_unittest.cc?r1=24464&r2=24463

Merge 23965 - Pulling new version of googleurl into the tree.
Fixing a net_unittest case that wasn't updated when googleurl code was changed (but not down integrated to chrome).

BUG=5490

Review URL: http://codereview.chromium.org/174093

TBR=cira@chromium.org

Review URL: http://codereview.chromium.org/174535
------------------------------------------------------------------------

Comment 27 by c...@chromium.org, Aug 26, 2009
(No comment was entered for this change.)
Status: Fixed
Comment 28 by mattm@chromium.org, Sep 17, 2009
Coverity found a bug (CID 5991) in that googleurl change:
if (source <= 0x80) {
 should be
if (source < 0x80) {

Comment 29 by bugdroid1@chromium.org, Sep 24, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27110 

------------------------------------------------------------------------
r27110 | mattm@chromium.org | 2009-09-24 12:50:26 -0700 (Thu, 24 Sep 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=27110&r2=27109

Update googleurl to 118.

BUG=5490

Review URL: http://codereview.chromium.org/219015
------------------------------------------------------------------------

Sign in to add a comment

Powered by Google Project Hosting