(No comment was entered for this change.)

(No comment was entered for this change.)

We can mitigate this at launch by not providing the checkbox on the EULA page. 

Not saying it's the best fix, but something to think about when deciding whether this blocks a Stable release.

Actually, on second thought, i don't think this is a releaseblock.  Here's my thinking:

- The user already has Chrome (5.0) and it's not the default browser.  That seems intentional; it seems like an edge case that the user would want to set it as default when downloading, but not before.
- There are simple work-arounds to set chrome as default: the butter bar, options dialog, etc.

Jeff, let me know if you feel differently.

Note: This is different than  issue 53655  (I was confused at first).

This bug isn't as bad as the other one ( issue 53655 ), since it just means the checkbox is non-functional (as opposed to doing the "wrong" thing). So I agree we don't need to make this a stable release blocker.

But since there's multiple bugs with the EULA page checkbox, maybe Mark's suggestion is easiest/best.

(No comment was entered for this change.)

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58280 

------------------------------------------------------------------------
r58280 | mirandac@chromium.org | 2010-09-01 17:21:56 -0700 (Wed, 01 Sep 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/setup/install.cc?r1=58280&r2=58279

Allow download Chrome page to set Chrome as default even if it is not a new install.

Read "make_default_for_user" preference from master_preferences file and set Chrome to default in installer if we are updating Chrome instead of installing a new version.
The problem here is that now that we set the default browser preference from a web page, we are using master_preferences to communicate this desire to the browser.
Because the user already has Chrome installed on his/her machine, the master_preferences file will not be written to their machine.
Instead, we check for this preference in the installer itself, and set Chrome to be default for the user here.

BUG=53656
TEST=Have Chrome installed on your machine, but *not* default browser.  Run setup.exe to install a new version of Chrome, with a master_preferences file that includes the distribution preference "make_default_for_user":true. (This reflects what happens when the user downloads Chrome with the "make default" option checked).
Chrome should be default browser.

Review URL: http://codereview.chromium.org/3342002
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58288 

------------------------------------------------------------------------
r58288 | mirandac@chromium.org | 2010-09-01 18:02:43 -0700 (Wed, 01 Sep 2010) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/installer/setup/install.cc?r1=58288&r2=58287

Merge 58280 - Allow download Chrome page to set Chrome as default even if it is not a new install.

Read "make_default_for_user" preference from master_preferences file and set Chrome to default in installer if we are updating Chrome instead of installing a new version.
The problem here is that now that we set the default browser preference from a web page, we are using master_preferences to communicate this desire to the browser.
Because the user already has Chrome installed on his/her machine, the master_preferences file will not be written to their machine.
Instead, we check for this preference in the installer itself, and set Chrome to be default for the user here.

BUG=53656
TEST=Have Chrome installed on your machine, but *not* default browser.  Run setup.exe to install a new version of Chrome, with a master_preferences file that includes the distribution preference "make_default_for_user":true. (This reflects what happens when the user downloads Chrome with the "make default" option checked).
Chrome should be default browser.

Review URL: http://codereview.chromium.org/3342002

TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/3359003
------------------------------------------------------------------------

(No comment was entered for this change.)