(No comment was entered for this change.)

(No comment was entered for this change.)

We can mitigate this at launch by not providing the checkbox on the EULA page. 

Not saying it's the best fix, but something to think about when deciding whether this blocks a Stable release.

Hmmm.. yeah, I think Mike Leotta would be able to push out a change to the EULA page fairly quickly if necessary. Removing the checkbox obviously removes the ability for people to easily set Chrome as default browser, but it could be a temporary removal so that we can still get the stable release out on time and then push the fix later. I'm not sure how easy/hard this fix is, but I'm assuming there's no time for another QA cycle. Or is there?

Miranda, Brian, thoughts?

I take back my comment about not being able to "easily set Chrome as default browser", since I believe there's still the infobar and options dialog.

It does seem like it would be annoying for all your history/settings to be imported from the "wrong" browser though.

So maybe we should just remove the EULA page checkbox temporarily as Mark suggested.

++ to Mark's suggestion.

This specific issue (importing data from Firefox, if that was the previous default, when Chrome is set as the default) is probably fixable in the code (I'm going through it right now), but the other bug under discussion is not, as Mark pointed out in another email.  

The problem in the second bug is that our new plan of having the checkbox on the download page to set default means that the installer creates a master_preferences file to determine whether to set Chrome as the default browser.  But if Chrome is installed on a machine where it already exists, the installer says "hey, we already have a master_preferences file, we don't need to create this new one," so the information we just encoded there never gets added, and the Chrome code never gets a chance to see it.  Fixing this would require a scary systemic change in both the installer and the browser code -- not something that should be done quickly.

(Also, Jeff is right that the "Make Chrome default?" infobar will pop up immediately on first run in this case.)

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58176 

------------------------------------------------------------------------
r58176 | mirandac@chromium.org | 2010-09-01 08:57:50 -0700 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.cc?r1=58176&r2=58175
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run/first_run.cc?r1=58176&r2=58175
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run/first_run.h?r1=58176&r2=58175

Set default browser AFTER import.

BUG=53655
TEST=set Firefox as default browser on Windows. Run Chrome with a fresh profile.  Import from FF should occur.

Review URL: http://codereview.chromium.org/3298004
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58190 

------------------------------------------------------------------------
r58190 | mirandac@chromium.org | 2010-09-01 10:02:35 -0700 (Wed, 01 Sep 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/browser_main.cc?r1=58190&r2=58189
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/first_run.h?r1=58190&r2=58189
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/first_run_win.cc?r1=58190&r2=58189

Merge r58176: Set default browser after import (OS Win).

see http://codereview.chromium.org/3298004


BUG=53655
TEST=Set Firefox as default browser on Windows. Run Chrome with a fresh profile (or force import). Import from FF should occur. All other import works as well.
Review URL: http://codereview.chromium.org/3343001
------------------------------------------------------------------------

(No comment was entered for this change.)

Verified in build: 7.0.517.24 beta
Platform: Win 7
Verified Fixed: Y
Fix works on 7.0.517 with a clean profile for Google chrome