My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 53548: fast/js/parser-xml-close-comment.html failing on chromium
3 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  lrn%chro...@gtempaccount.com
Closed:  Sep 2010
Cc:  ager@chromium.org
M-8

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Project Member Reported by d...@chromium.org, Aug 26, 2010
fast/js/parser-xml-close-comment.html was added in http://trac.webkit.org/changeset/66135 and has been failing since then. Looks like a javascript parsing issue. Mads, can you please take a look at the bug and assign it as appropriate? Or let me know if you think the output we produce is OK and I'll rebaseline this test.

Diff from the WebKit canary bots:

--- c:\b\slave\webkit-rel-webkit-org\build\src\webkit\Release\..\../../layout-test-results\fast/js/parser-xml-close-comment-expected.txt 
+++ c:\b\slave\webkit-rel-webkit-org\build\src\webkit\Release\..\../../layout-test-results\fast/js/parser-xml-close-comment-actual.txt 
@@ -3,15 +3,15 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS 'should be a syntax error' --> threw exception SyntaxError: Parse error.
-PASS /**/ 1 --> threw exception SyntaxError: Parse error.
-PASS 1 /**/ --> threw exception SyntaxError: Parse error.
+PASS 'should be a syntax error' --> threw exception SyntaxError: Unexpected end of input.
+PASS /**/ 1 --> threw exception SyntaxError: Unexpected end of input.
+PASS 1 /**/ --> threw exception SyntaxError: Unexpected end of input.
 PASS 1/*
-*/--> threw exception SyntaxError: Parse error.
+*/--> threw exception SyntaxError: Unexpected end of input.
 PASS --> is undefined.
-PASS /**/--> is undefined.
-PASS /*
-*/--> is undefined.
+FAIL /**/--> should be undefined. Threw exception SyntaxError: Unexpected token >
+FAIL /*
+*/--> should be undefined. Threw exception SyntaxError: Unexpected token >
 PASS successfullyParsed is true
 
 TEST COMPLETE
Aug 26, 2010
#1 d...@chromium.org
 Issue 53544  has been merged into this issue.
Aug 26, 2010
#2 ager@chromium.org
This looks like a parsing change that we should follow. Lasse, can you take a look?
Owner: LasseReichsteinHolstNielsen
Cc: a...@chromium.org
Labels: -Area-Undefined Area-WebKit WebKit-JavaScript
Aug 30, 2010
#3 lrn%chro...@gtempaccount.com
Seems to be a bug in our parser. We accept "/*..*/ -->" on a line as starting a line comment, *except* on the first line of a script.
It's an easy patch.
Sep 8, 2010
#4 ka...@chromium.org
(No comment was entered for this change.)
Labels: Mstone-8
Sep 9, 2010
#5 ager@chromium.org
This has been fixed. The layout test needs rebaselining. I will do that now.
Status: Fixed
Oct 12, 2012
#6 bugdroid1@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#7 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-WebKit -WebKit-JavaScript -Mstone-8 Cr-Content M-8 Cr-Content-JavaScript
Mar 13, 2013
#8 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Apr 5, 2013
#9 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content Cr-Blink
Apr 5, 2013
#10 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content-JavaScript Cr-Blink-JavaScript
Sign in to add a comment

Powered by Google Project Hosting