My favorites ▼ | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 53399: about:labs for chrome
23 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  thakis@chromium.org
Closed:  Aug 2010
Cc:  mirandac@chromium.org, viettrun...@chromium.org

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by thakis@chromium.org, Aug 25, 2010 
Implement about:labs for chrome.

about:labs should list a (small) set of experimental features. Every feature has an "enable?" checkbox. When at least one checkbox has been changed, a "Restart chrome to let changes take effect" button becomes active.

Every feature should roughly correspond to a commandline flag.

chromeos already has a kind of about:labs feature, but it depends on the tabbed options, and is a bit more complex because they don't require a restart. For m7, the chromeos guys and I agreed that a separate implementation for chrome makes the most sense; for m8 we will check if merging makes sense.
Aug 25, 2010
#1 thakis@chromium.org 
Oh, and about:labs should be supported only in the dev and beta channels, not in stable (labs features should always be disabled on stable)

Rough design:

* Have a list of lab features in some cc file. The list has
+ user-visible feature name
+ internal feature name
+ list of OSs where the feature's available on
+ feature description?
+ feature icon?
* A list of (internal feature name, feature enabled?) is stored under some prefs key
* Somewhere early in startup, this feature list is loaded and converted to flags (if the feature is supported on the current platform), which are added to the commandline flags object (huh, i need the flags to open the profile due to --user-data-dir; i sure hope that flags object is mutable). Any internal feature names in the profile that are not in the labs feature list are removed from the list (if a lab feature graduates for example)
* The supported OSs must be flags instead of command line flags due to prefs sync
* There will be a domui handler that bridges the (name, enabled) list together with metadata (name, icon?, description?) to js, where the user can modify it.
Aug 25, 2010
#2 viettrun...@chromium.org 
SGTM for the most part. I suggest we keep things maximally simple.

- skip the icon
- internal feature name = string without spaces; flag becomes "--enable-" + internal feature name; keeps things simple and consistent with predominant practice
- list in prefs should just be enabled_labs (or whatever), just a list of internal names
- user-visible name and description are not localized
- obviously labs can't deal with features which must be initialized before the profile is loaded
- you make the domui stuff sound so complicated (but it isn't)
Aug 25, 2010
#3 viettrun...@chromium.org 
(No comment was entered for this change.)
Cc: viettrun...@chromium.org
Aug 25, 2010
#4 viettrun...@chromium.org 
Maybe the about:labs in the stable version should offer download links to dev and beta channels!
Aug 25, 2010
#5 thakis@google.com 
"- internal feature name = string without spaces; flag becomes "--enable-" + internal feature name; keeps things simple and consistent with predominant practice". Sounds reasonable, might become a teeny bit more complex once/if the first labsy flag gets renamed to --disable. But good enough for now.

"- user-visible name and description are not localized" Localization is practically free and doesn't make things a lot harder, so I'd like to localize these.

skipping the icon and enabled_labs sgtm
Aug 25, 2010
#6 thakis@chromium.org 
CommandLine has AppendSwitch(), hooray.
Aug 25, 2010
#7 viettrun...@chromium.org 
In the case (localized stuff), you only need an integer or two (string IDs).

I just wonder if we'd ever bother getting labs names/descriptions translated, but as you said it's free to build in that capability.
Aug 25, 2010
#8 thakis@chromium.org 
 Issue 50450  has been merged into this issue.
Aug 26, 2010
#9 thakis@chromium.org 
http://codereview.chromium.org/3152055/show

cl out for review
Status: Started
Aug 26, 2010
#10 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57635 

------------------------------------------------------------------------
r57635 | thakis@chromium.org | 2010-08-26 21:11:14 -0700 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_controller_mac.mm?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.cc?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc?r1=57635&r2=57634
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/labs_ui.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/labs_ui.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/plugins_ui.cc?r1=57635&r2=57634
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/labs.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/labs.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/browser_prefs.cc?r1=57635&r2=57634
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/labs.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.cc?r1=57635&r2=57634
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.h?r1=57635&r2=57634

Implement about:labs

Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet.

BUG=53399
TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation)

Review URL: http://codereview.chromium.org/3152055
------------------------------------------------------------------------
Aug 26, 2010
#11 thakis@chromium.org 
Nearly all done. Currently, every platform only shows the experiments it supports. Jeff prefers if all platforms show all experiments, with a list of supported platforms per experiment, and with not supported experiments greyed out (like I described in comment 1, now that I look at it).

Maybe I'll get to that too for m7, but not sure. If someone wants to pick up that part, that's fine with me.
Status: Assigned
Aug 26, 2010
#12 thakis@chromium.org 
Let's close this. I filed  issue 53560  for what I just claimed is left. Jeff, can you triage that new issue?
Status: Fixed
Cc: jeffr...@chromium.org
Aug 27, 2010
#13 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57664 

------------------------------------------------------------------------
r57664 | dpolukhin@chromium.org | 2010-08-27 04:44:36 -0700 (Fri, 27 Aug 2010) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_controller_mac.mm?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.cc?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc?r1=57664&r2=57663
   D /trunk/src/chrome/browser/dom_ui/labs_ui.cc
   D /trunk/src/chrome/browser/dom_ui/labs_ui.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/plugins_ui.cc?r1=57664&r2=57663
   D /trunk/src/chrome/browser/labs.cc
   D /trunk/src/chrome/browser/labs.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/browser_prefs.cc?r1=57664&r2=57663
   D /trunk/src/chrome/browser/resources/labs.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.cc?r1=57664&r2=57663
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.h?r1=57664&r2=57663

Revert 57635: Implement about:labs

Original CL: http://codereview.chromium.org/3152055

Implement about:labs

Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet.

BUG=53399
TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation)
TBR=thakis@chromium.org

Review URL: http://codereview.chromium.org/3256001
------------------------------------------------------------------------
Aug 27, 2010
#14 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57670 

------------------------------------------------------------------------
r57670 | thakis@chromium.org | 2010-08-27 06:19:05 -0700 (Fri, 27 Aug 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_controller_mac.mm?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.cc?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_resources.grd?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc?r1=57670&r2=57669
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/labs_ui.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/labs_ui.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/plugins_ui.cc?r1=57670&r2=57669
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/labs.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/labs.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/prefs/browser_prefs.cc?r1=57670&r2=57669
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/labs.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.cc?r1=57670&r2=57669
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.h?r1=57670&r2=57669

Implement about:labs

Tabpose is currently the only lab on mac, tabs-on-left the only lab on windows. Nothing for linux yet.

BUG=53399
TEST=Go to about:labs. Should have one feature on windows and osx each, none on linux yet. about:labs should not be visible on the stable channel. Labs that were enabled on the dev channel should not be enabled on the stable channel. about:labs in chromeos should still work (they use a different implementation)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57635

Review URL: http://codereview.chromium.org/3152055
------------------------------------------------------------------------
Aug 30, 2010
#15 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57911 

------------------------------------------------------------------------
r57911 | thakis@chromium.org | 2010-08-30 14:27:39 -0700 (Mon, 30 Aug 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/labs.png?r1=57911&r2=57910
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/labs_section.png

Icons for about:labs

BUG=53399
TEST=none
TBR=trungl
------------------------------------------------------------------------
Aug 30, 2010
#16 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57917 

------------------------------------------------------------------------
r57917 | thakis@chromium.org | 2010-08-30 15:17:18 -0700 (Mon, 30 Aug 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/labs.html?r1=57917&r2=57916

Use new labs_section on about:labs

BUG=53399
TEST=none
TBR=trungl
------------------------------------------------------------------------
Oct 14, 2010
#17 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=62624

------------------------------------------------------------------------
r62624 | thakis@chromium.org | Thu Oct 14 12:52:12 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.cc?r1=62624&r2=62623&pathrev=62624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.h?r1=62624&r2=62623&pathrev=62624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=62624&r2=62623&pathrev=62624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/labs_ui.cc?r1=62624&r2=62623&pathrev=62624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/labs.html?r1=62624&r2=62623&pathrev=62624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=62624&r2=62623&pathrev=62624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_factory.cc?r1=62624&r2=62623&pathrev=62624
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/labs.cc?r1=62624&r2=62623&pathrev=62624

Rename about:labs to about:flags, step 1/3

This changes the url and the text on about:flags to a bit more scary.

The text is taken from https://docs.google.com/a/google.com/document/d/1VRZjR3GGX2FJFsAe8AKMAYRNPMp-sH2cefU0KvaQo0M/edit?hl=en#

BUG=59139,53399
TEST=about:labs doesn't do anything any more. about:flags does.

Review URL: http://codereview.chromium.org/3817004
------------------------------------------------------------------------
Oct 14, 2010
#18 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=62686

------------------------------------------------------------------------
r62686 | thakis@chromium.org | Thu Oct 14 17:49:49 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/common/url_constants.h?r1=62686&r2=62685&pathrev=62686
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/browser/browser_about_handler.cc?r1=62686&r2=62685&pathrev=62686
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/browser/dom_ui/labs_ui.cc?r1=62686&r2=62685&pathrev=62686
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/browser/resources/labs.html?r1=62686&r2=62685&pathrev=62686
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/app/generated_resources.grd?r1=62686&r2=62685&pathrev=62686
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/browser/dom_ui/dom_ui_factory.cc?r1=62686&r2=62685&pathrev=62686
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/browser/labs.cc?r1=62686&r2=62685&pathrev=62686
 M http://src.chromium.org/viewvc/chrome/branches/552/src/chrome/common/url_constants.cc?r1=62686&r2=62685&pathrev=62686

Merge 62624 - Rename about:labs to about:flags, step 1/3

This changes the url and the text on about:flags to a bit more scary.

The text is taken from https://docs.google.com/a/google.com/document/d/1VRZjR3GGX2FJFsAe8AKMAYRNPMp-sH2cefU0KvaQo0M/edit?hl=en#

BUG=59139,53399
TEST=about:labs doesn't do anything any more. about:flags does.

Review URL: http://codereview.chromium.org/3817004

TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/3776005
------------------------------------------------------------------------
Jul 28, 2011
#19 arku1...@wp.pl 
Mozilla/4.0 (compatible; QweR 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; FDM; Alexa Toolbar)
Oct 12, 2012
#20 bugdroid1@chromium.org 
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#21 bugdroid1@chromium.org 
(No comment was entered for this change.)
Labels: -Area-UI Cr-UI
Jul 24, 2013
#22 lafo...@google.com 
(No comment was entered for this change.)
Cc: -jeffr...@chromium.org
► Sign in to add a comment

Powered by Google Project Hosting