Issue 52916 - chromium - Improved SSL status dialogs - An open-source browser project to help move the web forward.

Issue 52916:	Improved SSL status dialogs
	15 people starred this issue and may be notified of changes.	Back to list

Status:	Verified
Owner:	fin...@chromium.org
Closed:	Oct 2010
Cc:	rsesek@chromium.org, ian.chromium@gmail.com, mattm@chromium.org, ben@chromium.org, avi@chromium.org, jcive...@chromium.org, viettrun...@chromium.org
Type-Feature Pri-2 Area-UI Feature-Browser Mstone-8 Hotlist-ConOps-...Priority

Blocking:
issue 52430

Reported by project member jeffr...@chromium.org, Aug 20, 2010


Mocks: http://folder/alcor/c/Mocks/Page_info

Spec: https://docs1.google.com/a/google.com/document/edit?id=1hJPs8FChk1LD4kT37TxuWt3pVGFwDlaJWRqE2zEDHTA&hl=en#


rsesek@ also working on this.


Let's try to get into M7, but M8 is ok too.

As usual, please develop behind a flag!

Comment 1 by bugdroid1@gmail.com, Aug 24, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57158 

------------------------------------------------------------------------
r57158 | finnur@chromium.org | 2010-08-24 02:05:36 -0700 (Tue, 24 Aug 2010) | 14 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings.grd?r1=57158&r2=57157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_window.h?r1=57158&r2=57157
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=57158&r2=57157
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=57158&r2=57157

First pass at convert the SSL dialogs into InfoBubbles.

This just converts it from being a dialog to being a bubble, with no significant changes to the content.

This is only active on Windows, so I'm leaving the old dialog implementation behind.

Known issues: 
- View certificate not there yet. 
- Doesn't look exactly like the mocks.

BUG=http://crbug.com/52916
TEST=None

Review URL: http://codereview.chromium.org/3136027
------------------------------------------------------------------------

Comment 2 by bugdroid1@gmail.com, Aug 24, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57187 

------------------------------------------------------------------------
r57187 | finnur@chromium.org | 2010-08-24 08:35:27 -0700 (Tue, 24 Aug 2010) | 7 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_connection_bad.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_connection_good.png

Adding a couple of binary files to hopefully get a good try run on my next changlist.

TBR=jcivelli
TEST=None
BUG=52916

Review URL: http://codereview.chromium.org/3120028
------------------------------------------------------------------------

Comment 3 by bugdroid1@gmail.com, Aug 24, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57198 

------------------------------------------------------------------------
r57198 | finnur@chromium.org | 2010-08-24 09:59:23 -0700 (Tue, 24 Aug 2010) | 12 lines
Changed paths:
   D /trunk/src/chrome/app/theme/pageinfo_connection_bad.png
   D /trunk/src/chrome/app/theme/pageinfo_connection_good.png

Revert 57187 - Adding a couple of binary files to hopefully get a good try run on my next changlist.

(I thought we wanted separate sets for Identity and Connect column, but UI leads said we should consolidate here)

TBR=jcivelli
TEST=None
BUG=52916

Review URL: http://codereview.chromium.org/3120028

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3162035
------------------------------------------------------------------------

Comment 4 by bugdroid1@gmail.com, Aug 25, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57311 

------------------------------------------------------------------------
r57311 | finnur@chromium.org | 2010-08-25 03:25:31 -0700 (Wed, 25 Aug 2010) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_bad.png?r1=57311&r2=57310
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_good.png?r1=57311&r2=57310
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=57311&r2=57310
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.h?r1=57311&r2=57310
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.cc?r1=57311&r2=57310
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.h?r1=57311&r2=57310
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_window_view.cc?r1=57311&r2=57310

Part 2 of the SSL InfoBubble.

- Added Certificate Information link.

- Changed iconography to be:
  Identity  : Green check mark vs. Red skull and bones
  Connection: Green padlock vs. Orange exclamation point.
  (This used to be Green checkmark and Orange Exclamation point for both sections.

- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.

BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.

Review URL: http://codereview.chromium.org/3136031
------------------------------------------------------------------------

Comment 5 by bugdroid1@gmail.com, Aug 25, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57314 

------------------------------------------------------------------------
r57314 | finnur@chromium.org | 2010-08-25 03:40:25 -0700 (Wed, 25 Aug 2010) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_bad.png?r1=57314&r2=57313
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_good.png?r1=57314&r2=57313
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=57314&r2=57313
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.h?r1=57314&r2=57313
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.cc?r1=57314&r2=57313
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.h?r1=57314&r2=57313
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_window_view.cc?r1=57314&r2=57313

Revert 57311 - Part 2 of the SSL InfoBubble.

- Added Certificate Information link.

- Changed iconography to be:
  Identity  : Green check mark vs. Red skull and bones
  Connection: Green padlock vs. Orange exclamation point.
  (This used to be Green checkmark and Orange Exclamation point for both sections.

- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.

BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.

Review URL: http://codereview.chromium.org/3136031

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3170043
------------------------------------------------------------------------

Comment 6 by bugdroid1@gmail.com, Aug 25, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57358 

------------------------------------------------------------------------
r57358 | rsesek@chromium.org | 2010-08-25 11:45:12 -0700 (Wed, 25 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm?r1=57358&r2=57357
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_mac.h?r1=57358&r2=57357
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_mac.mm?r1=57358&r2=57357
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=57358&r2=57357
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/page_info_window_gtk.cc?r1=57358&r2=57357
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=57358&r2=57357
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.cc?r1=57358&r2=57357
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=57358&r2=57357
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=57358&r2=57357
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=57358&r2=57357

Add a flag for the showing the Page Info dialog as a bubble. This adds stubs for all platforms.

BUG=52916
TEST=Compile.  Page Info works as before.

Review URL: http://codereview.chromium.org/3175037
------------------------------------------------------------------------

Comment 7 by bugdroid1@gmail.com, Aug 26, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57498 

------------------------------------------------------------------------
r57498 | finnur@chromium.org | 2010-08-26 02:00:00 -0700 (Thu, 26 Aug 2010) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_bad.png?r1=57498&r2=57497
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_good.png?r1=57498&r2=57497
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_mac_unittest.mm?r1=57498&r2=57497
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/page_info_window_gtk.cc?r1=57498&r2=57497
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=57498&r2=57497
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.h?r1=57498&r2=57497
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.cc?r1=57498&r2=57497
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.h?r1=57498&r2=57497
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_window_view.cc?r1=57498&r2=57497

Part 2 of the SSL InfoBubble. 2nd try, this time with test fixed.

- Added Certificate Information link.

- Changed iconography to be:
 Identity  : Green check mark vs. Red skull and bones
 Connection: Green padlock vs. Orange exclamation point.
 (This used to be Green checkmark and Orange Exclamation point for both sections.

- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.

BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.

Review URL: http://codereview.chromium.org/3187019
------------------------------------------------------------------------

Comment 8 by bugdroid1@gmail.com, Aug 26, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57516 

------------------------------------------------------------------------
r57516 | finnur@chromium.org | 2010-08-26 07:22:27 -0700 (Thu, 26 Aug 2010) | 8 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_mixed.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=57516&r2=57515

Adding image to the repository to facilitate successful try for my next changelist.

This is not the final image, just a placeholder for alcor to replace.

BUG=52916
TEST=None
TBR=jcivelli
Review URL: http://codereview.chromium.org/3191028
------------------------------------------------------------------------

Comment 9 by bugdroid1@gmail.com, Aug 27, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57654 

------------------------------------------------------------------------
r57654 | finnur@chromium.org | 2010-08-27 02:28:24 -0700 (Fri, 27 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=57654&r2=57653
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_mac_unittest.mm?r1=57654&r2=57653
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=57654&r2=57653
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.h?r1=57654&r2=57653
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.cc?r1=57654&r2=57653
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_window_view.cc?r1=57654&r2=57653

Add mixed content warning to the Page Info bubble.

BUG=http://crbug.com/52916
TEST=Navigate to a page with mixed http and https content. The gray padlock should appear in the Omnibox icon and in the infobubble when you click it.

Review URL: http://codereview.chromium.org/3171031
------------------------------------------------------------------------

Comment 10 by bugdroid1@gmail.com, Aug 30, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57936 

------------------------------------------------------------------------
r57936 | mattm@chromium.org | 2010-08-30 19:36:38 -0700 (Mon, 30 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_mac.mm?r1=57936&r2=57935
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/page_info_window_gtk.cc?r1=57936&r2=57935

Fix linux and mac page info windows showing wrong status icons.

BUG=52916
TEST=load https://www.google.com, click on page info

Review URL: http://codereview.chromium.org/3250009
------------------------------------------------------------------------

Comment 11 by mattm@chromium.org, Aug 30, 2010

Adding myself since I'm working on the Gtk impl.

FYI, in views the bubble shows up in the wrong place in RTL languages.

Cc: ma...@chromium.org

Comment 12 by bugdroid1@gmail.com, Aug 31, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57970 

------------------------------------------------------------------------
r57970 | finnur@chromium.org | 2010-08-31 01:44:43 -0700 (Tue, 31 Aug 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=57970&r2=57969
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings.grd?r1=57970&r2=57969
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=57970&r2=57969
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.cc?r1=57970&r2=57969
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.h?r1=57970&r2=57969

Tweaks to the SSL InfoBubble dialog.

Fixed the mixed state icon not showing for section Connection. I overlooked the fact that we already check for mixed content, but reported state as error (whereas now we want warning).

Added link to help center explaining what this dialog means.

BUG=http://crbug.com/52916
TEST=SSL Infobubble should show link to help center and should show mixed content icon when, for example, you open an email in Gmail with an external image embedded in it.

Review URL: http://codereview.chromium.org/3221005
------------------------------------------------------------------------

Comment 13 by bugdroid1@gmail.com, Aug 31, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58003 

------------------------------------------------------------------------
r58003 | finnur@chromium.org | 2010-08-31 09:00:08 -0700 (Tue, 31 Aug 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_bad.png?r1=58003&r2=58002
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_good.png?r1=58003&r2=58002
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_info.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_mixed.png?r1=58003&r2=58002

New images for the page info ssl bubble.

BUG=http://crbug.com/52916
TEST=None
TBR=alcor

Review URL: http://codereview.chromium.org/3271003
------------------------------------------------------------------------

Comment 14 by bugdroid1@gmail.com, Sep 1, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58150 

------------------------------------------------------------------------
r58150 | finnur@chromium.org | 2010-09-01 01:55:53 -0700 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_mac.mm?r1=58150&r2=58149
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/page_info_window_gtk.cc?r1=58150&r2=58149
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.cc?r1=58150&r2=58149
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_window_view.cc?r1=58150&r2=58149

Show Page Info InfoBubble on the right side for RTL languages and make sure Warning is treated as error in old dialog (which is how it was before).

BUG=http://crbug.com/52916
TEST=Open SSL Infobubble on RTL languages, make sure it points to the right location. Then open a gmail containing an external image (not attached, but embedded) and make sure the old SSL dialog (not the infobubble) shows an error for mixed content, not the green icon.

Review URL: http://codereview.chromium.org/3245012
------------------------------------------------------------------------

Comment 15 by bugdroid1@gmail.com, Sep 1, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58151 

------------------------------------------------------------------------
r58151 | finnur@chromium.org | 2010-09-01 01:56:08 -0700 (Wed, 01 Sep 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_bad.png?r1=58151&r2=58150

Updated pageinfo_bad.png.

TBR=alcor
BUG=http://crbug.com/52916
TEST=None

Review URL: http://codereview.chromium.org/3215011
------------------------------------------------------------------------

Comment 16 by bugdroid1@gmail.com, Sep 1, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58249 

------------------------------------------------------------------------
r58249 | mattm@chromium.org | 2010-09-01 15:23:03 -0700 (Wed, 01 Sep 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.h?r1=58249&r2=58248
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/page_info_bubble_gtk.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/page_info_window_gtk.cc?r1=58249&r2=58248
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=58249&r2=58248

Gtk page info bubble.

BUG=52916
TEST=run chrome with --enable-new-page-info-bubble, click on page info

Review URL: http://codereview.chromium.org/3310002
------------------------------------------------------------------------

Comment 17 by fin...@chromium.org, Sep 10, 2010

I just checked in my change, which includes a misleading description (since the patch changed while in review). 

It should read:

InfoBubble now shows red skull and bones on ran_insecure_content

not...

InfoBubble now shows red skull and bones on security style AuthenticationBroken.

Status: Started

Comment 18 by bugdroid1@gmail.com, Sep 10, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59088

------------------------------------------------------------------------
r59088 | finnur@chromium.org | Fri Sep 10 06:22:05 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=59088&r2=59087&pathrev=59088
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_window_view.cc?r1=59088&r2=59087&pathrev=59088
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=59088&r2=59087&pathrev=59088
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.h?r1=59088&r2=59087&pathrev=59088
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/page_info_bubble_view.cc?r1=59088&r2=59087&pathrev=59088
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=59088&r2=59087&pathrev=59088
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/page_info_bubble_gtk.cc?r1=59088&r2=59087&pathrev=59088

Page info model now shows red skull and crossbones on SECURITY_STYLE_AUTHENTICATION_BROKEN, like the Omnibox does.

Started using...
a) the Info icon (blue i) for the first visit section and 
b) the yellow exclamation point for http connections (instead of the skull and crossbones).

BUG=http://crbug.com/52916
TEST=None

Review URL: http://codereview.chromium.org/3367007
------------------------------------------------------------------------

Comment 19 by bugdroid1@gmail.com, Sep 10, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59103

------------------------------------------------------------------------
r59103 | finnur@chromium.org | Fri Sep 10 09:52:19 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=59103&r2=59102&pathrev=59103
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_warning_major.png?r1=59103&r2=59102&pathrev=59103 (from /trunk/src/chrome/app/theme/pageinfo_warning.png revision 59086)
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_warning.png?r1=59103&r2=59102&pathrev=59103
 D http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_mixed.png?r1=59103&r2=59102&pathrev=59103
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_warning_minor.png?r1=59103&r2=59102&pathrev=59103 (from /trunk/src/chrome/app/theme/pageinfo_mixed.png revision 59086)

Rename pngs to correspond with enums better, as suggested
by wtc (but I excluded from cl so I could still use the try
servers for that cl).

TBR=wtc
BUG=http://crbug.com/52916
TEST=None

Review URL: http://codereview.chromium.org/3292017
------------------------------------------------------------------------

Comment 20 by pkasting@chromium.org, Sep 10, 2010

 Issue 55075  has been merged into this issue.

Comment 21 by jeffr...@chromium.org, Sep 10, 2010

(No comment was entered for this change.)

Labels: -Mstone-7 Mstone-8

Comment 22 by bugdroid1@gmail.com, Sep 14, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59357

------------------------------------------------------------------------
r59357 | tfarina@chromium.org | Tue Sep 14 05:12:01 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/page_info_bubble_gtk.cc?r1=59357&r2=59356&pathrev=59357

gtk: Show the page info icon for the first visit on Page Info Bubble.

BUG=52916
TEST=out/Debug/chrome --enable-new-page-info-bubble. Go to https://google.com,
     click on the omnibox icon, see the icon is showed for the the First Visit
     section.

Review URL: http://codereview.chromium.org/3364018
------------------------------------------------------------------------

Comment 23 by bugdroid1@gmail.com, Sep 14, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59360

------------------------------------------------------------------------
r59360 | finnur@chromium.org | Tue Sep 14 06:05:04 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=59360&r2=59359&pathrev=59360
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=59360&r2=59359&pathrev=59360

Show these two cert errors as warnings, not errors (as requested by Ian):

CERT_STATUS_UNABLE_TO_CHECK_REVOCATION
CERT_STATUS_NO_REVOCATION_MECHANISM

Note: The Omnibox shows no_revocation_mechanism as skull and bones, but that's a separate issue.

BUG=http://crbug.com/52916
TEST=Requires server with cert errors.

Review URL: http://codereview.chromium.org/3293019
------------------------------------------------------------------------

Comment 24 by bugdroid1@gmail.com, Sep 15, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59554

------------------------------------------------------------------------
r59554 | finnur@chromium.org | Wed Sep 15 14:19:30 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=59554&r2=59553&pathrev=59554
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_warning.pdf?r1=59554&r2=59553&pathrev=59554
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_invalid.pdf?r1=59554&r2=59553&pathrev=59554
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_warning.png?r1=59554&r2=59553&pathrev=59554
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_invalid.png?r1=59554&r2=59553&pathrev=59554

Adding new Omnibox images from Cole for the SSL warning and errors.

BUG=52916
TEST=Manual inspection of new bitmaps when showing both active (scripts) and inactive (images) mixed content

Review URL: http://codereview.chromium.org/3405007
------------------------------------------------------------------------

Comment 25 by bugdroid1@gmail.com, Sep 15, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59556

------------------------------------------------------------------------
r59556 | finnur@chromium.org | Wed Sep 15 14:26:05 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/517/src/chrome/app/theme/omnibox_https_warning.pdf?r1=59556&r2=59555&pathrev=59556
 M http://src.chromium.org/viewvc/chrome/branches/517/src/chrome/app/theme/omnibox_https_invalid.pdf?r1=59556&r2=59555&pathrev=59556
 M http://src.chromium.org/viewvc/chrome/branches/517/src/chrome/app/theme/omnibox_https_warning.png?r1=59556&r2=59555&pathrev=59556
 M http://src.chromium.org/viewvc/chrome/branches/517/src/chrome/app/theme/omnibox_https_invalid.png?r1=59556&r2=59555&pathrev=59556
 M http://src.chromium.org/viewvc/chrome/branches/517/src/chrome/app/theme/theme_resources.grd?r1=59556&r2=59555&pathrev=59556

Merge 59554 - Adding new Omnibox images from Cole for the SSL warning and errors.

BUG=52916
TEST=Manual inspection of new bitmaps when showing both active (scripts) and inactive (images) mixed content

Review URL: http://codereview.chromium.org/3405007

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3384008
------------------------------------------------------------------------

Comment 26 by bugdroid1@gmail.com, Sep 15, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59557

------------------------------------------------------------------------
r59557 | finnur@chromium.org | Wed Sep 15 14:27:11 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_https_warning.pdf?r1=59557&r2=59556&pathrev=59557
 M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_https_invalid.pdf?r1=59557&r2=59556&pathrev=59557
 M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_https_warning.png?r1=59557&r2=59556&pathrev=59557
 M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_https_invalid.png?r1=59557&r2=59556&pathrev=59557
 M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/theme_resources.grd?r1=59557&r2=59556&pathrev=59557

Merge 59554 - Adding new Omnibox images from Cole for the SSL warning and errors.

BUG=52916
TEST=Manual inspection of new bitmaps when showing both active (scripts) and inactive (images) mixed content

Review URL: http://codereview.chromium.org/3405007

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3458001
------------------------------------------------------------------------

Comment 27 by thakis@chromium.org, Sep 27, 2010

 Issue 57078  has been merged into this issue.

Comment 28 by csilv@chromium.org, Sep 27, 2010

 Issue 51530  has been merged into this issue.

Comment 29 by bugdroid1@gmail.com, Sep 27, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=60730

------------------------------------------------------------------------
r60730 | csilv@chromium.org | Mon Sep 27 16:59:19 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/page_info_window_gtk.cc?r1=60730&r2=60729&pathrev=60730

[gtk] Update page-info icons to match behavior in page_info_window_view.cc.

BUG=52916
TEST=Verify correct page-info icons in GTK.
Review URL: http://codereview.chromium.org/3502007
------------------------------------------------------------------------

Comment 30 by bugdroid1@gmail.com, Sep 30, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=61077

------------------------------------------------------------------------
r61077 | rsesek@chromium.org | Thu Sep 30 10:32:28 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_mac.mm?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.h?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.h?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.h?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/location_icon_decoration.mm?r1=61077&r2=61076&pathrev=61077
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_bubble_controller.h?r1=61077&r2=61076&pathrev=61077
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_bubble_controller_unittest.mm?r1=61077&r2=61076&pathrev=61077
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_bubble_controller.mm?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/base_bubble_controller.h?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/base_bubble_controller.mm?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=61077&r2=61076&pathrev=61077
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/labs.cc?r1=61077&r2=61076&pathrev=61077

[Mac] Convert the page info window to a bubble.

BUG=52430,52916
TEST=Enable Page Info Bubble in about:labs and click on the lock icon.

Review URL: http://codereview.chromium.org/3461016
------------------------------------------------------------------------

Comment 31 by bugdroid1@gmail.com, Oct 6, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=61627

------------------------------------------------------------------------
r61627 | finnur@chromium.org | Wed Oct 06 05:54:33 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_bad.png?r1=61627&r2=61626&pathrev=61627
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/pageinfo_warning_minor.png?r1=61627&r2=61626&pathrev=61627

Replace the icons for the Page Info Bubble warnings and errors.

Instead of red padlock warning, we now have gray padlock with yellow triangle over it.
Instead of skull and bones error, we now have red padlock with x over it.

This matches better with the icons in the Omnibox.

BUG=52916
TEST=Visual inspection.

Review URL: http://codereview.chromium.org/3520016
------------------------------------------------------------------------

Comment 32 by suna...@chromium.org, Oct 7, 2010

Navigate to sourceforge.net and click on the icon(representing http) to bring up security information dialog.

This still show skull and cross bones in Google Chrome 7.0.517.36 (Official Build 61761)

Comment 33 by jeffr...@chromium.org, Oct 7, 2010

The skull&crossbones are *not* there in 7.0.544.0 dev.

Comment 34 by bugdroid1@gmail.com, Oct 8, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=61932

------------------------------------------------------------------------
r61932 | finnur@chromium.org | Fri Oct 08 02:12:56 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=61932&r2=61931&pathrev=61932
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=61932&r2=61931&pathrev=61932
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm?r1=61932&r2=61931&pathrev=61932
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/page_info_model.cc?r1=61932&r2=61931&pathrev=61932
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=61932&r2=61931&pathrev=61932
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=61932&r2=61931&pathrev=61932
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=61932&r2=61931&pathrev=61932
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/labs.cc?r1=61932&r2=61931&pathrev=61932

Enable the new page info bubble by default.

BUG=52916
TEST=None

Review URL: http://codereview.chromium.org/3519016
------------------------------------------------------------------------

Comment 35 by fin...@chromium.org, Oct 8, 2010

I'm calling this done. I've turned the new bubble on by default and removed the lab experiment. I'll remove the old dialog implementation some time next week once the dust settles.

We can treat the remaining issues as separate bugs. I know rsesek is adding the link to the help center article (CL has been LG'ed) and there is one issue ( issue 58162 ) which I'm working on (and probably also applies to the old implementation anyway).

Status: Fixed

Comment 36 by cl...@chromium.org, Feb 17, 2011

(No comment was entered for this change.)

Labels: ConOps

Comment 37 by j...@chromium.org, Mar 23, 2011

(No comment was entered for this change.)

Labels: -ConOps Hotlist-ConOps-TopPriority

Comment 38 by mberkow...@chromium.org, Jul 8, 2011

Verified in 14.0.803.0 (Official Build 90483).

Status: Verified

► Sign in to add a comment