| Issue 52746: | UITest should recover more gracefully if we fail to WaitForInitialLoads, etc. | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Restricted
Sign in to add a comment
|
UITest should recover more gracefully if we fail to WaitForInitialLoads, etc. We should kill the browser and start it again, a few times before we give up.
Sep 1, 2010
(No comment was entered for this change.)
Status:
Fixed
Sep 13, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=59315
------------------------------------------------------------------------
r59315 | phajdan.jr@chromium.org | Mon Sep 13 18:22:11 PDT 2010
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/ui_test.cc?r1=59315&r2=59314&pathrev=59315
Revert 57897 - GTTF: Retry launching the browser a few times in UITest.
This should help us with some temporary bad conditions
on the bots. The browser shouldn't fail to start
three times in a row.
TEST=ui_tests
BUG=52746, 54453
Review URL: http://codereview.chromium.org/3126034
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3404001
------------------------------------------------------------------------
Sep 15, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=59609
------------------------------------------------------------------------
r59609 | shess@chromium.org | Wed Sep 15 19:36:12 PDT 2010
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/517/src/chrome/test/ui/ui_test.cc?r1=59609&r2=59608&pathrev=59609
Merge 59315 - Revert 57897 - GTTF: Retry launching the browser a few times in UITest.
Merge comment: This was causing crashes on chromebot. Should be no
impact on end-users.
Original comment:
This should help us with some temporary bad conditions
on the bots. The browser shouldn't fail to start
three times in a row.
TEST=ui_tests
BUG=52746, 54453
Review URL: http://codereview.chromium.org/3126034
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3404001
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3411009
------------------------------------------------------------------------
Mar 18, 2011
UITest should recover more gracefully if we fail to WaitForInitialLoads, etc. We should kill the browser and start it again, a few times before we give up.
Labels:
-GreenTreeTaskForce bulkmove TaskForce-GreenTree
Oct 12, 2012
This issue has been closed for some time. No one will pay attention to new comments. If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels:
Restrict-AddIssueComment-Commit
Blocking: -chromium:52858 chromium:52858
Mar 10, 2013
(No comment was entered for this change.)
Labels:
-Area-Undefined
|
||||||||
| ► Sign in to add a comment | |||||||||
The following revision refers to this bug: http://src.chromium.org/viewvc/chrome?view=rev&revision=57897 ------------------------------------------------------------------------ r57897 | phajdan.jr@chromium.org | 2010-08-30 13:15:53 -0700 (Mon, 30 Aug 2010) | 10 lines Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/ui_test.cc?r1=57897&r2=57896 GTTF: Retry launching the browser a few times in UITest. This should help us with some temporary bad conditions on the bots. The browser shouldn't fail to start three times in a row. TEST=ui_tests BUG=52746 Review URL: http://codereview.chromium.org/3126034 ------------------------------------------------------------------------