My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 52096: updating v8 from 5214 to 5242 causes LastPass SHA256 hashing code to fail
218 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  erik.corry
Closed:  Aug 2010
Cc:  sgjesse@chromium.org, ager@chromium.org
M-6

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Project Member Reported by asargent@chromium.org, Aug 13, 2010
http://groups.google.com/a/chromium.org/group/chromium-extensions/browse_thread/thread/4326be8ce8a523e5

The test page is here:

https://rodan.lastpass.com/dev/nightly_problem.php

They claim that if that page reports "incorrect: 0" at the bottom, then that means the bug is present. I used our build/build-bisect.py script to track this down to:

http://src.chromium.org/viewvc/chrome?view=rev&revision=55850

which updates v8 in DEPS from 5214 to 5242


Aug 14, 2010
#1 ager@chromium.org
Erik, could you have a look at this one? Could this be related to your ia32 bit ops changes?
Owner: erik.corry
Cc: a...@chromium.org
Aug 15, 2010
#2 stuartmorgan@chromium.org
 Issue 52183  has been merged into this issue.
Aug 17, 2010
#3 moore.br...@gmail.com
Is there any movement on this?
Aug 17, 2010
#4 ager@chromium.org
The fix for this has just been pushed to tip of tree chromium this morning.
Status: Fixed
Aug 17, 2010
#5 stuartmorgan@chromium.org
 Issue 52214  has been merged into this issue.
Aug 17, 2010
#6 stuartmorgan@chromium.org
 Issue 52490  has been merged into this issue.
Aug 17, 2010
#7 joe-...@lastpass.com
Pushing this bug into the latest Dev channel release is very frustrating.  Would you consider saving us hundreds of support hours and tons of user frustration by fixing this sooner rather than later in the dev channel?  Is it going to be pushed to the beta channel too? 
Aug 17, 2010
#8 robert.b...@gmail.com
We are now getting many many support emails that people are now experiencing this with 6.0.495.0 dev.

Did the fix make it into that build?
If so, then it does not fix the problem.

Personally, I can now log into LastPass, but the test page mentioned above still fails.

Is there a way to escalate this problem, we are really being impacted badly by it.
Aug 17, 2010
#10 matrix0...@gmail.com
Here's a solution that worked for me for a temporary workaround.  Either sync your settings or save a backup copy of your Default User Date File, on xp it's at C:\Documents and Settings\%user%\Local Settings\Application Data\Google\Chrome\User Data\Default and then go to filehippo.com (they have previous versions of dev/beta and stable releases). Uninstall your current version first. I am sticking with dev version 6.0.427.33 for now as I am confident that it works perfectly with last pass.  Hope this helps.
Aug 17, 2010
#13 joe-...@lastpass.com
We've pushed LastPass version 1.69.8+ which will inform you when you're using a browser with this bug.
Aug 17, 2010
#16 joe-...@lastpass.com
The Javascript engine can't do math correctly so you shouldn't use this version of the browser -- please update to 1.69.8+ and restart chrome and hopefully you'll get a notice if there's an issue with your browser
Aug 17, 2010
#20 sTraTosPheRe.programming@gmail.com
When can we expect an update to Chrome/Chromium to be pushed out to fix this issue?  It's getting extremely aggravating.

Additionally, to the lastpass guys, can you warn people on your site's login area about this issue, or at least have a warning display to anyone with a chrome 6 user agent?  It'd save you guys a few emails, that's for sure.
Aug 17, 2010
#34 Mathemat...@gmail.com
To people who say that this is not fixed: Yes it is. Try the latest version of Chromium.
Aug 17, 2010
#35 ora...@gmail.com
EXPECT things break now and then. Screaming and ranting about problems on a dev channel is evidence that you should not be using a dev channel.

Fixes get made in CHROMIUM and rolled to the Google CHROME dev channel later.
Aug 17, 2010
#36 grimmy....@gmail.com
I can confirm that the problem goes away for me in the nightly Chromium (7.0.498.0 (56485))
Aug 17, 2010
#37 the.orig...@gmail.com
Yup, confirmed fixed in every case on chromium nightly 7.0.498.0 (56483), thanks Erik.
Aug 18, 2010
#54 ionutale...@gmail.com
If you use Windows:

Uninstall the dev build.
Install the latest stable build from http://www.google.com/chrome
Install Chrome Canary from http://tools.google.com/dlpage/chromesxs (more frequently updated than the dev channel, runs side by side with any other Chrome build)


Aug 18, 2010
#58 ager@chromium.org
This was fixed in V8 version 2.3.8. As far as we know, only V8 version 2.3.7 has this problem. It was fixed in chromium in revision 56316. This issue has therefore been fixed and marked as such. It will hit the releases soon.

If you have a problem with V8 2.3.8 or 2.2.x.y, please file a separate bug report and cc me on it (ager@chromium.org).

Thanks.
Aug 18, 2010
#67 stuartmorgan@chromium.org
 Issue 52559  has been merged into this issue.
Aug 18, 2010
#68 stuartmorgan@chromium.org
 Issue 52571  has been merged into this issue.
Aug 18, 2010
#87 stuartmorgan@chromium.org
 Issue 52640  has been merged into this issue.
Oct 12, 2012
#88 bugdroid1@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#89 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-Internals -Mstone-6 Cr-Internals M-6
Mar 13, 2013
#90 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment

Powered by Google Project Hosting