My favorites | Sign in
Project Home Downloads Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 51643: Custom cells in wrench should have highlighted state on hover
6 people starred this issue and may be notified of changes. Back to list
Status:  Verified
Owner:  rsesek@chromium.org
Closed:  Aug 2010


Sign in to add a comment
 
Reported by project member thakis@chromium.org, Aug 9, 2010
What steps will reproduce the problem?
1. Open wrench menu, keep mouse down
2. Drag to the "Copy" button

What is the expected result?

The "Copy" button should look active, like normal popup menu items do, too.

What happens instead?

It's only shown as active when the mouse button is released.

Comment 1 by rsesek@chromium.org, Aug 11, 2010
This should happen in all hover states, not just click-drag-release.
Summary: Custom cells in wrench should have highlighted state on hover
Status: Assigned
Comment 2 by rsesek@chromium.org, Aug 16, 2010
(No comment was entered for this change.)
Labels: -Mstone-6 Mstone-7
Comment 3 by rsesek@chromium.org, Aug 16, 2010
 Issue 52336  has been merged into this issue.
Comment 4 by rsesek@chromium.org, Aug 17, 2010
(No comment was entered for this change.)
Status: Started
Comment 5 by bugdroid1@gmail.com, Aug 17, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=56430 

------------------------------------------------------------------------
r56430 | rsesek@chromium.org | 2010-08-17 15:39:59 -0700 (Tue, 17 Aug 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_tracked_button.h?r1=56430&r2=56429
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_tracked_button.mm?r1=56430&r2=56429

[Mac] Implement highlight-on-hover for the Wrench menu buttons.

R=pinkerton, shess, mark
BUG=51643
TEST=Open Wrench menu in sticky and non-sticky mode. Hover over buttons and they highlight.

Review URL: http://codereview.chromium.org/3137013
------------------------------------------------------------------------

Comment 6 by rsesek@chromium.org, Aug 17, 2010
Fix is on 10.6 only.  There's a bug in the way 10.5 draws the parts of the custom button cell that makes the highlighted state look terrible, so it's explicitly disabled.
Status: Fixed
Comment 7 by bugdroid1@gmail.com, Aug 17, 2010
Verified label updated by AutoAllocator, contact AmolK or KrisR for details
Labels: Verifier-Deepakg
Comment 8 by deep...@chromium.org, Aug 24, 2010
Verified in 7.0.503.0 (Official Build 57033) dev on 10.6.4.
Status: Verified
Sign in to add a comment

Powered by Google Project Hosting