My favorites | Sign in
Project Home Downloads Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 51597: Plugin grouping (about:plugins) broke flash development
16 people starred this issue and may be notified of changes. Back to list
 
Reported by project member cpu@chromium.org, Aug 9, 2010
People that develop using Adobe tools should be able to debug flash movies hosted in chrome.

So when you install say CS5, it installs the 'debugger' version of the plugin. Now you need to be able to disable the built-in plugin and enable the debugger one.

This is no longer possible given the grouping of plugins enable/disable.

When fixing this take in consideration the Adobe's technical note about this
http://kb2.adobe.com/cps/839/cpsid_83950.html

Note the changes so the instructions can be adjusted as needed.

Comment 1 by cpu@chromium.org, Aug 9, 2010
I've been told the grouping accomplishes some other goals, so instead of reverting _it_ seems we need to find a way to have the cake and eat it too.

In any case this needs to be sorted ASAP
Owner: m...@chromium.org
Cc: lafo...@chromium.org ben.at.chromium.org
Comment 2 by mal@google.com, Aug 9, 2010
It looks like the plugin coalescing was implemented by mavrommatis with review from jam@. jam@ is out of the office for a few weeks, so I've also cc'd bauerb@ and viettrungluu@ who might know something about the code here.
Status: Assigned
Owner: mavrommatis
Cc: bau...@chromium.org viettrun...@chromium.org m...@chromium.org j...@chromium.org
Labels: ReleaseBlock-Stable Mstone-6
Comment 3 by bauerb@google.com, Aug 9, 2010
In theory, if you click on "Details" at the top right of about:plugins, there should be a link to enable/disable individual plug-ins. Not sure why it doesn't show up though.
Comment 4 by bauerb@chromium.org, Aug 9, 2010
Looks like a stray tag in the HTML file.
Status: Started
Owner: bau...@chromium.org
Cc: mavrommatis
Labels: -Area-Undefined
Comment 5 by bugdroid1@gmail.com, Aug 10, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55541 

------------------------------------------------------------------------
r55541 | bauerb@chromium.org | 2010-08-10 01:30:21 -0700 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/plugins.html?r1=55541&r2=55540
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/plugin_group.cc?r1=55541&r2=55540

Re-enable the link to disable invididual plug-ins in a group.

BUG=51597
TEST=In about:plugins, click on "Details". There should be a link to enable/disable each individual plug-in in a plug-in group.

Review URL: http://codereview.chromium.org/3038055
------------------------------------------------------------------------

Comment 6 by bugdroid1@gmail.com, Aug 10, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55562 

------------------------------------------------------------------------
r55562 | bauerb@chromium.org | 2010-08-10 06:05:32 -0700 (Tue, 10 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/resources/plugins.html?r1=55562&r2=55561
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/common/plugin_group.cc?r1=55562&r2=55561

Merge 55541 - Re-enable the link to disable invididual plug-ins in a group.

BUG=51597
TEST=In about:plugins, click on "Details". There should be a link to enable/disable each individual plug-in in a plug-in group.

Review URL: http://codereview.chromium.org/3038055

TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/3146006
------------------------------------------------------------------------

Comment 7 by bauerb@chromium.org, Aug 10, 2010
(No comment was entered for this change.)
Status: Fixed
Comment 8 by mal@google.com, Aug 13, 2010
 Issue 49867  has been merged into this issue.
Cc: anan...@chromium.org
Comment 9 by stuartmorgan@chromium.org, Aug 13, 2010
 Issue 52068  has been merged into this issue.
Comment 10 by dhw@chromium.org, Aug 14, 2010
 Issue 52146  has been merged into this issue.
Comment 11 by chrisobr...@gmail.com, Aug 14, 2010
disable is now listed twice for every plugin unnecessarily 
Comment 12 by bauerb@chromium.org, Aug 14, 2010
There is one link for each plug-in in a group to disable it, and one
link to disable the whole group at once. If the group consists only of
one plug-in, these two links of course do the same.
Sign in to add a comment

Powered by Google Project Hosting