| Issue 51430: | Tab outline displayed incorrectly with dark themes | |
| 4 people starred this issue and may be notified of changes. | Back to list |
Restricted
Sign in to add a comment
|
Chrome Version : 6.0.472.22 dev URLs (if applicable) : n/a OS version : 10.6.3 build 10D573 What steps will reproduce the problem? 1. Install Tiësto theme. 2. Open a chrome window 3. Observe UI flaw What is the expected result? The chrome tabs should be outlined according to the theme. What happens instead? The chrome tabs are outlined with bright white lines. It is distracting. Notes: * Any sufficiently dark theme will display this way in the new build. * Attached screenshots of stable channel (5.0.375.125 - correct) and dev channel (6.0.472.22 - incorrect) builds. * Clearing user settings (~/Library/Application Support/Google/Chrome) and reinstalling does not result in improvement.
Aug 6, 2010
#1
bugdroid1@gmail.com
Labels:
Verifier-Deepakg
Aug 6, 2010
(No comment was entered for this change.)
Cc:
andyb...@chromium.org
Labels: -Area-Undefined Area-UI Feature-TabStrip
Aug 8, 2010
(No comment was entered for this change.)
Status:
Untriaged
Aug 8, 2010
6.0.472.25 dev as well.
Aug 9, 2010
(No comment was entered for this change.)
Status:
Assigned
Owner: andyb...@chromium.org Cc: -andyb...@chromium.org pinker...@chromium.org Labels: Mstone-6 ReleaseBlock-Stable
Aug 12, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=55906
------------------------------------------------------------------------
r55906 | andybons@chromium.org | 2010-08-12 11:04:17 -0700 (Thu, 12 Aug 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=55906&r2=55905
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.h?r1=55906&r2=55905
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell.mm?r1=55906&r2=55905
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/styled_text_field_cell.mm?r1=55906&r2=55905
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_view.mm?r1=55906&r2=55905
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_view.mm?r1=55906&r2=55905
[Mac] Fix aesthetic issues with themes given the new TopChrome changes.
o Just use the provided toolbar background color as the "highlight" color in most cases and don't draw a bevel on the templated buttons.
BUG=51430
TEST=see bug. make sure no jank.
Review URL: http://codereview.chromium.org/3140009
------------------------------------------------------------------------
Aug 12, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=55929
------------------------------------------------------------------------
r55929 | andybons@chromium.org | 2010-08-12 13:27:08 -0700 (Thu, 12 Aug 2010) | 9 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/browser_theme_provider.cc?r1=55929&r2=55928
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/browser_theme_provider.h?r1=55929&r2=55928
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/gradient_button_cell.mm?r1=55929&r2=55928
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/styled_text_field_cell.mm?r1=55929&r2=55928
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/tab_strip_view.mm?r1=55929&r2=55928
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/tab_view.mm?r1=55929&r2=55928
Merge 55906 - [Mac] Fix aesthetic issues with themes given the new TopChrome changes.
o Just use the provided toolbar background color as the "highlight" color in most cases and don't draw a bevel on the templated buttons.
BUG=51430
TEST=see bug. make sure no jank.
Review URL: http://codereview.chromium.org/3140009
TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/3152014
------------------------------------------------------------------------
Aug 12, 2010
(No comment was entered for this change.)
Status:
Fixed
Aug 12, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=55949
------------------------------------------------------------------------
r55949 | mark@chromium.org | 2010-08-12 14:22:09 -0700 (Thu, 12 Aug 2010) | 10 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/gradient_button_cell.mm?r1=55949&r2=55948
10.6 SDK compatibility fix for GradientButtonCell following r55906.
See r26348, "Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize
conversions": The SDK has gotten stupider in 10.6, and has conspired with the
compiler, which now thinks that when the receiver is held in a scoped_nsobject,
NSColor and NSSize arguments should be converted to their CG cousins.
BUG=51430
TEST=10.6 SDK build (mac_sdk=10.6)
Review URL: http://codereview.chromium.org/3162008
------------------------------------------------------------------------
Aug 16, 2010
Verified in 6.0.496.0 (Official Build 56183) dev
Status:
Verified
Oct 12, 2012
This issue has been closed for some time. No one will pay attention to new comments. If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels:
Restrict-AddIssueComment-Commit
Mar 10, 2013
(No comment was entered for this change.)
Labels:
-Area-UI -Feature-TabStrip -Mstone-6 Cr-UI-Browser-TabStrip M-6 Cr-UI
Mar 13, 2013
(No comment was entered for this change.)
Labels:
-Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
|
||||||||||
| ► Sign in to add a comment | |||||||||||
