Issue 51014 - chromium - WebM/VP8 video plays too fast on certain content - An open-source browser project to help move the web forward.

Issue 51014:	WebM/VP8 video plays too fast on certain content
	2 people starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	fgalli...@chromium.org
Closed:	Aug 2010
Cc:	ka...@chromium.org, feature-...@chromium.org
Type-Bug Pri-1 Area-WebKit Feature-Media OS-All Mstone-6 ReleaseBlock-Stable

Reported by project member scherkus@chromium.org, Aug 2, 2010

YouTube WebM content seems to be created correctly and plays back properly.

Other content such as our sync test content was created using different tools, resulting in video that plays back too fast.

Works properly in Firefox and Opera.  We should be able to play back all WebM content regardless of tools used to create the content.

Comment 1 by fgalli...@chromium.org, Aug 3, 2010

The problem is the altref frames were getting decoded but not producing a valid video_frame, so video_frame.get() would return false and the pts_heap_ would never get popped.

Here is a CL for the fix http://codereview.chromium.org/3086009

Comment 2 by scherkus@chromium.org, Aug 3, 2010

Cool -- assigning to you as you have a fix.

Once tested + committed please merge into 472 branch using drover.

Status: Started
Owner: fgalli...@chromium.org

Comment 3 by bugdroid1@gmail.com, Aug 10, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55596 

------------------------------------------------------------------------
r55596 | fgalligan@chromium.org | 2010-08-10 11:58:05 -0700 (Tue, 10 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_video_decode_engine.cc?r1=55596&r2=55595
   M http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/ffmpeg_video_decode_engine_unittest.cc?r1=55596&r2=55595

Fix av sync for webm files with altref video frames. Altref frames
need to be decoded but they do not produce a valid output frame. The
pts_heap_ was not getting popped for altref frames.

BUG=51014
TEST=Play content form sync test and make sure the content plays
back in sync.

Review URL: http://codereview.chromium.org/3086009
------------------------------------------------------------------------

Comment 4 by bugdroid1@gmail.com, Aug 12, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55905 

------------------------------------------------------------------------
r55905 | fgalligan@chromium.org | 2010-08-12 10:59:09 -0700 (Thu, 12 Aug 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/media/filters/ffmpeg_video_decode_engine.cc?r1=55905&r2=55904
   M http://src.chromium.org/viewvc/chrome/branches/472/src/media/filters/ffmpeg_video_decode_engine_unittest.cc?r1=55905&r2=55904

Merge 55596 - Fix av sync for webm files with altref video frames. Altref frames
need to be decoded but they do not produce a valid output frame. The
pts_heap_ was not getting popped for altref frames.

BUG=51014
TEST=Play content form sync test and make sure the content plays
back in sync.

Review URL: http://codereview.chromium.org/3086009

TBR=fgalligan@chromium.org
Review URL: http://codereview.chromium.org/3169009
------------------------------------------------------------------------

Comment 5 by fgalli...@chromium.org, Aug 12, 2010

(No comment was entered for this change.)

Status: Fixed

► Sign in to add a comment