My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 50943: Notifications of web request and navigation
313 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  jochen@chromium.org
Closed:  Jan 2011
Cc:  rafaelw@chromium.org, asargent@chromium.org, a...@chromium.org, erik...@chromium.org, mpcomplete@chromium.org, jochen@chromium.org

Blocking:
issue 61934

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by jochen@chromium.org, Aug 2, 2010
Implement the extension API as described here:  http://www.chromium.org/developers/design-documents/extensions/notifications-of-web-request-and-navigation
Aug 3, 2010
#1 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54723 

------------------------------------------------------------------------
r54723 | jochen@chromium.org | 2010-08-03 01:55:01 -0700 (Tue, 03 Aug 2010) | 8 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webrequest_apitest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=54723&r2=54722
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=54723&r2=54722
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/experimental.html?r1=54723&r2=54722
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/experimental.webRequest.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/renderer_extension_bindings.js?r1=54723&r2=54722
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/api
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/api/manifest.json
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/api/test.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webrequest
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webrequest/api
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webrequest/api/manifest.json
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webrequest/api/test.html

Add the definition of the webRequest and webNavigation APIs.

The webRequest API doesn't support the planned filter and extraInfoSpec parameters yet, these will be added later.

BUG=50943
TEST=ExtensionApiTest.WebRequest,ExtensionApiTest.WebNavigation

Review URL: http://codereview.chromium.org/3061041
------------------------------------------------------------------------

Aug 12, 2010
#2 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55912 

------------------------------------------------------------------------
r55912 | mad@google.com | 2010-08-12 12:43:51 -0700 (Thu, 12 Aug 2010) | 7 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=55912&r2=55911

Add constant values for the webNavigation API.

for yzshen's http://codereview.chromium.org/3117011/show

BUG=50943
TEST=none
Review URL: http://codereview.chromium.org/3131014
------------------------------------------------------------------------

Aug 29, 2010
#3 galm...@gmail.com
I tried to work with webrequest and webnavigation listeners, it does not reproduce an error, but nothing working
Aug 29, 2010
#4 yzs...@google.com
Hi, galmika.

The APIs are still under development and haven't been ready yet. Thanks!
Sep 1, 2010
#5 galm...@gmail.com
Can you give some timeline for starting to test the API (in dev or cananry builds)?
Sep 2, 2010
#6 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58330 

------------------------------------------------------------------------
r58330 | jochen@chromium.org | 2010-09-02 00:32:32 -0700 (Thu, 02 Sep 2010) | 6 lines
Changed paths:
   D /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.cc
   D /trunk/src/chrome/browser/extensions/extension_web_navigation_api_constants.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api_constants.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api_constants.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webrequest_api_constants.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webrequest_api_constants.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=58330&r2=58329

Add api constants for webRequest and clean up webNavigation.

BUG=50943
TEST=none

Review URL: http://codereview.chromium.org/3315002
------------------------------------------------------------------------

Sep 3, 2010
#7 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=58469 

------------------------------------------------------------------------
r58469 | jochen@chromium.org | 2010-09-03 02:21:08 -0700 (Fri, 03 Sep 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=58469&r2=58468
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html?r1=58469&r2=58468

Add transition qualifiers to the web navigation api.

BUG=50943
TEST=none

Review URL: http://codereview.chromium.org/3354003
------------------------------------------------------------------------

Sep 8, 2010
#8 bugdroid1@gmail.com
------------------------------------------------------------------------
r58802 | jochen@chromium.org | Wed Sep 08 02:37:23 PDT 2010
Changed paths:
 A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation
 M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad/a.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/manifest.json
 M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
 M /trunk/src/chrome/common/extensions/api/extension_api.json
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/b.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/a.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/c.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad
 M /trunk/src/chrome/browser/extensions/extensions_service.cc
 M /trunk/src/chrome/common/page_transition_types.cc
 M /trunk/src/chrome/chrome_browser.gypi
 M /trunk/src/chrome/common/page_transition_types.h
 M /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
 A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3307013
------------------------------------------------------------------------
Sep 8, 2010
#9 bugdroid1@gmail.com
------------------------------------------------------------------------
r58807 | jochen@chromium.org | Wed Sep 08 03:13:57 PDT 2010
Changed paths:
 D /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
 M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
 D /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation
 M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
 M /trunk/src/chrome/common/extensions/api/extension_api.json
 M /trunk/src/chrome/browser/extensions/extensions_service.cc
 M /trunk/src/chrome/common/page_transition_types.cc
 M /trunk/src/chrome/chrome_browser.gypi
 D /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
 M /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
 M /trunk/src/chrome/common/page_transition_types.h
Revert 58802 - Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3307013

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3317013
------------------------------------------------------------------------
Sep 8, 2010
#10 bugdroid1@gmail.com
------------------------------------------------------------------------
r58809 | jochen@chromium.org | Wed Sep 08 04:20:36 PDT 2010
Changed paths:
 A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation
 M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad/a.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/manifest.json
 M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
 M /trunk/src/chrome/common/extensions/api/extension_api.json
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/b.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/a.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/c.html
 A /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad
 M /trunk/src/chrome/browser/extensions/extensions_service.cc
 M /trunk/src/chrome/common/page_transition_types.cc
 M /trunk/src/chrome/chrome_browser.gypi
 M /trunk/src/chrome/common/page_transition_types.h
 M /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
 A /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3369007
------------------------------------------------------------------------
Sep 8, 2010
#11 bugdroid1@gmail.com
------------------------------------------------------------------------
r58814 | jochen@chromium.org | Wed Sep 08 05:06:03 PDT 2010
Changed paths:
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html
Increase the delay in WebNavigationEvents test from 500ms to 1s.

BUG=50943
TEST=WebNavigationEvents doesn't fail
TBR=jochen@chromium.org

Review URL: http://codereview.chromium.org/3352011
------------------------------------------------------------------------
Sep 8, 2010
#12 bugdroid1@gmail.com
------------------------------------------------------------------------
r58815 | jochen@chromium.org | Wed Sep 08 05:22:19 PDT 2010
Changed paths:
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html
 M /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html
Revert 58814 - Increase the delay in WebNavigationEvents test from 500ms to 1s.

BUG=50943
TEST=WebNavigationEvents doesn't fail
TBR=jochen@chromium.org

Review URL: http://codereview.chromium.org/3352011

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3291017
------------------------------------------------------------------------
Sep 8, 2010
#13 bugdroid1@gmail.com
------------------------------------------------------------------------
r58816 | jochen@chromium.org | Wed Sep 08 05:29:47 PDT 2010
Changed paths:
 D /trunk/src/chrome/browser/extensions/extension_webnavigation_api.h
 M /trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html
 D /trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation
 M /trunk/src/chrome/browser/tab_contents/navigation_controller.cc
 M /trunk/src/chrome/common/extensions/api/extension_api.json
 M /trunk/src/chrome/browser/extensions/extensions_service.cc
 M /trunk/src/chrome/common/page_transition_types.cc
 M /trunk/src/chrome/chrome_browser.gypi
 D /trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc
 M /trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc
 M /trunk/src/chrome/common/page_transition_types.h
Revert 58809 - Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3369007

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3359013
------------------------------------------------------------------------
Sep 12, 2010
#14 a...@chromium.org
 Issue 29903  has been merged into this issue.
Cc: rafa...@chromium.org asarg...@chromium.org a...@chromium.org erik...@chromium.org mpcompl...@chromium.org
Sep 12, 2010
#15 a...@chromium.org
 Issue 30672  has been merged into this issue.
Sep 13, 2010
#16 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59212

------------------------------------------------------------------------
r59212 | jochen@chromium.org | Mon Sep 13 00:06:52 PDT 2010

Changed paths:
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation?r1=59212&r2=59211&pathrev=59212
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.cc?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad/a.html?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/manifest.json?r1=59212&r2=59211&pathrev=59212
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/experimental.webNavigation.html?r1=59212&r2=59211&pathrev=59212
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=59212&r2=59211&pathrev=59212
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/b.html?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/a.html?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/c.html?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad?r1=59212&r2=59211&pathrev=59212
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service.cc?r1=59212&r2=59211&pathrev=59212
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/page_transition_types.cc?r1=59212&r2=59211&pathrev=59212
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=59212&r2=59211&pathrev=59212
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/page_transition_types.h?r1=59212&r2=59211&pathrev=59212
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_apitest.cc?r1=59212&r2=59211&pathrev=59212
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=59212&r2=59211&pathrev=59212

Reland r54723. Implement the webNavigation.onCommitted event.

BUG=50943
TEST=ExtensionApiTest.WebNavigationEvents

Review URL: http://codereview.chromium.org/3310025
------------------------------------------------------------------------
Sep 14, 2010
#17 mikeperr...@gmail.com
Please see my writeup comments on this API at: https://groups.google.com/a/chromium.org/group/chromium-extensions/browse_thread/thread/17ea6efa15bfea0a

Note that in particular, it would be helpful if you were very specific on any urls or browser systems that would *not* be subject to WebRequest observance and/or modification, as these may present problems for security and privacy enhancing extensions.
Sep 14, 2010
#18 a...@chromium.org
 Issue 29314  has been merged into this issue.
Cc: joc...@chromium.org
Sep 16, 2010
#19 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59641

------------------------------------------------------------------------
r59641 | jochen@chromium.org | Thu Sep 16 05:41:15 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=59641&r2=59640&pathrev=59641
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=59641&r2=59640&pathrev=59641
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html?r1=59641&r2=59640&pathrev=59641
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/provisional_load_details.cc?r1=59641&r2=59640&pathrev=59641
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/provisional_load_details.h?r1=59641&r2=59640&pathrev=59641
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=59641&r2=59640&pathrev=59641
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=59641&r2=59640&pathrev=59641

Add the onBeforeNavigate and onErrorOccured events to the webNavigation API.

Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.

The frameId and the requestId fields are still unimplemented.

Also, there occur navigation events after an error is reported.

BUG=50943
TEST=WebNavigationEvents

Review URL: http://codereview.chromium.org/3436002
------------------------------------------------------------------------
Sep 16, 2010
#20 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59642

------------------------------------------------------------------------
r59642 | jochen@chromium.org | Thu Sep 16 06:00:33 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=59642&r2=59641&pathrev=59642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=59642&r2=59641&pathrev=59642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html?r1=59642&r2=59641&pathrev=59642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/provisional_load_details.cc?r1=59642&r2=59641&pathrev=59642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/provisional_load_details.h?r1=59642&r2=59641&pathrev=59642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=59642&r2=59641&pathrev=59642
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=59642&r2=59641&pathrev=59642

Revert 59641 - Add the onBeforeNavigate and onErrorOccured events to the webNavigation API.

Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.

The frameId and the requestId fields are still unimplemented.

Also, there occur navigation events after an error is reported.

BUG=50943
TEST=WebNavigationEvents

Review URL: http://codereview.chromium.org/3436002

TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3389012
------------------------------------------------------------------------
Sep 17, 2010
#21 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59777

------------------------------------------------------------------------
r59777 | jochen@chromium.org | Fri Sep 17 01:35:22 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=59777&r2=59776&pathrev=59777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=59777&r2=59776&pathrev=59777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html?r1=59777&r2=59776&pathrev=59777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/provisional_load_details.cc?r1=59777&r2=59776&pathrev=59777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/provisional_load_details.h?r1=59777&r2=59776&pathrev=59777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=59777&r2=59776&pathrev=59777
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=59777&r2=59776&pathrev=59777

Reland r59641. Add the onBeforeNavigate and onErrorOccured events to the webNavigation API.

Also, rewrite the onCommitted event such that AUTO_SUBFRAME events are also registered.

BUG=50943
TEST=WebNavigationEvents

Review URL: http://codereview.chromium.org/3383008
------------------------------------------------------------------------
Sep 21, 2010
#22 galm...@gmail.com
Is it possible to stop propagation of event (discontinue loading new url) when receiving webNavigation.onBeforeNavigate event?
Sep 21, 2010
#23 phistuck
Currently not. They are considering that for the future.
Oct 5, 2010
#24 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=61503

------------------------------------------------------------------------
r61503 | jochen@chromium.org | Tue Oct 05 05:50:07 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=61503&r2=61502&pathrev=61503
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframeFail?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/provisional_load_details.cc?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/provisional_load_details.h?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=61503&r2=61502&pathrev=61503
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframeFail/a.html?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/test.html?r1=61503&r2=61502&pathrev=61503
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframeFail/b.html?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=61503&r2=61502&pathrev=61503
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframeFail/d.html?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=61503&r2=61502&pathrev=61503
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/d.html?r1=61503&r2=61502&pathrev=61503
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/e.html?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_params.cc?r1=61503&r2=61502&pathrev=61503
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/f.html?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_params.h?r1=61503&r2=61502&pathrev=61503
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/g.html?r1=61503&r2=61502&pathrev=61503
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=61503&r2=61502&pathrev=61503

Implement the frame id required for the web navigation api.

BUG=50943
TEST=*.WebNavigationEvents

Review URL: http://codereview.chromium.org/3561008
------------------------------------------------------------------------
Oct 13, 2010
#25 mikey.be@gmail.com
Hi, I have a real need for this :)

My use case is that i need access to the Content-Type, Content-Encoding, and ETag header values for a resource.

It would also be of great value to hook into all transmissions too so I can add my Auth headers without the need of js processing on the resource itself :)
Oct 25, 2010
#26 athi...@google.com
Looks like there's a lot progress on this feature!  Is it released?  I can't tell from the logs.  If not, could you give us a time frame when it will be ready?

Athicha
Oct 28, 2010
#27 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=64210

------------------------------------------------------------------------
r64210 | jochen@chromium.org | Thu Oct 28 01:17:36 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=64210&r2=64209&pathrev=64210
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.cc?r1=64210&r2=64209&pathrev=64210
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/url_constants.h?r1=64210&r2=64209&pathrev=64210
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_unittest.cc?r1=64210&r2=64209&pathrev=64210
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation2/test.html?r1=64210&r2=64209&pathrev=64210
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=64210&r2=64209&pathrev=64210
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=64210&r2=64209&pathrev=64210
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=64210&r2=64209&pathrev=64210

Track in which frames navigation errors occurred and don't send further navigation events for them

BUG=50943
TEST=browser_tests:*.WebNavigationEvents*,unit_tests:FrameNavigationStateTest.*

Review URL: http://codereview.chromium.org/4136004
------------------------------------------------------------------------
Oct 29, 2010
#28 delfin.r...@gmail.com
We really need this API... any ETA? Thanks for working on it!
Oct 29, 2010
#29 a...@chromium.org
(No comment was entered for this change.)
Labels: Restrict-AddIssueComment-Commit
Nov 1, 2010
#30 lafo...@chromium.org
(No comment was entered for this change.)
Labels: -Dev-TestPlan-No Dev-QAReview-No
Nov 4, 2010
#31 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=65034

------------------------------------------------------------------------
r65034 | jochen@chromium.org | Thu Nov 04 02:21:08 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_unittest.cc?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation1/test.html?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation2/test.html?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_view.cc?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_view.h?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=65034&r2=65033&pathrev=65034
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=65034&r2=65033&pathrev=65034

Implement onDOMContentLoaded event of the webNavigation API.

BUG=50943
TEST=browser_tests:*.WebNavigationEvents*,unit_tests:FrameNavigationStateTest.*

Review URL: http://codereview.chromium.org/4381001
------------------------------------------------------------------------
Nov 5, 2010
#32 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=65182

------------------------------------------------------------------------
r65182 | jochen@chromium.org | Fri Nov 05 01:07:17 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation1/test.html?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation2/test.html?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_view.cc?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/web_page_view.h?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=65182&r2=65181&pathrev=65182
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=65182&r2=65181&pathrev=65182

Implement onCompleted event for the webNavigation API

BUG=50943
TEST=browser_tests:*.WebNavigationEvents*

Review URL: http://codereview.chromium.org/4448003
------------------------------------------------------------------------
Nov 18, 2010
#33 jochen@chromium.org
removing dev- labels since this is a feature bug. the resp. meta bugs are listed as blocked-on
Labels: -Dev-LegalReview-No -Dev-PrivacyReview-No -Dev-SecurityReview-No -Dev-UIReview-No -Dev-QAReview-No
Jan 21, 2011
#35 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=72163

------------------------------------------------------------------------
r72163 | jochen@chromium.org | Fri Jan 21 10:52:00 PST 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/notification_type.h?r1=72163&r2=72162&pathrev=72163
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_message_filter.cc?r1=72163&r2=72162&pathrev=72163
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation1/openTab/c.html?r1=72163&r2=72162&pathrev=72163
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.h?r1=72163&r2=72162&pathrev=72163
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation1/test.html?r1=72163&r2=72162&pathrev=72163
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation1/openTab/b.html?r1=72163&r2=72162&pathrev=72163
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation2/test.html?r1=72163&r2=72162&pathrev=72163
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation1/openTab/a.html?r1=72163&r2=72162&pathrev=72163
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_helper.cc?r1=72163&r2=72162&pathrev=72163
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_helper.h?r1=72163&r2=72162&pathrev=72163
 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/webnavigation/navigation1/openTab?r1=72163&r2=72162&pathrev=72163
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_webnavigation_api.cc?r1=72163&r2=72162&pathrev=72163

Implement the onBeforeRetarget event of the webNavigation API

TEST=none
BUG=50943

Review URL: http://codereview.chromium.org/6363002
------------------------------------------------------------------------
Jan 21, 2011
#36 jochen@chromium.org
the implementation is done. will refactor the api tests to be less brittle
Status: Fixed
Mar 10, 2013
#37 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-Internals -Feature-Extensions Cr-Internals Cr-Platform-Extensions
Blocking: -chromium:60100 -chromium:60101 -chromium:61934 chromium:60100 chromium:60101 chromium:61934
Sign in to add a comment

Powered by Google Project Hosting