My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 5087: Change keyboard language: Shortcut for "Debug JavaScript" also changes
1 person starred this issue and may be notified of changes. Back to list
 
Reported by xlyuan@chromium.org, Dec 03, 2008
1. Spun off  issue 4049 
2. Not sure if this issue will go away after we fix  issue 3696 , so file a
separated one for it

Build: 0.4.154.29 (Official Build 6138)
   OS: Any

Other Browsers:
  Safari: N/A
Firefox3: N/A
     IE7: N/A

Pre-steps:
Add both English keyboard and German keyboard on OS

Steps:
1. Launch English Chrome
2. Switch keyboard to English 
3. Observe the shortcut key for "Debug JavaScript"
4. Switch keyboard to German
5. Observe the shortcut key for "Debug JavaScript" again

Result:
Step3: Shortcut key is Alt+` 
Step5: Shortcut key is Alt+รถ

Expected:
We didn't change Chrome UI language, but the shortcut key changes when the
keyboard changed, it might confuse user. Is it better we use some locale
neutralized key and keep it consistent between different keyboards?

Notes:
It also happens when switch keyboard to French, Italian, Spanish, Russian



Comment 1 by jshin@chromium.org, Dec 04, 2008
chrome/browser/views/frame/browser_view.cc populates the accelerator table with AtlLoadAccelerators

'Fixing  issue 3696 ' will 'resolve' this issue, but I wonder what'd happen if we have  
'Ctrl-Y' and 'Ctrl-Z'  

Ooops. I missed Glen's comment in http://codereview.chromium.org/10652/show. I'll 
update my patch and nominate that for 1.0 (I think the fix is simple enough to be 
merged this late in the game). 
 
Cc: g...@chromium.org m...@chromium.org
Labels: Mstone-1.0
Comment 2 by jon@chromium.org, Dec 04, 2008
(No comment was entered for this change.)
Status: Available
Labels: Mstone-X Area-WebKit
Comment 3 by jshin@chromium.org, Dec 05, 2008
Fixed in r6438 ( http://src.chromium.org/viewvc/chrome?view=rev&revision=6438 , 
http://codereview.chromium.org/10652 )

Status: Fixed
Labels: -OS-All -Area-Misc -I18N -Area-WebKit OS-Windows Area-BrowserUI i18n
Comment 4 by thatan...@google.com, Dec 07, 2008
(No comment was entered for this change.)
Cc: thatan...@google.com
Comment 5 by xlyuan@chromium.org, Dec 08, 2008
Verified on branch 0.4.154.33 (Official Build 6493), fixed.

  Debug JavaScript -> Ctrl+Shift+L
JavaScript console -> Ctrl+Shift+J
Status: Verified
Sign in to add a comment

Powered by Google Project Hosting