| Issue 50714: | LANG is not set to UTF-8 on the chrome official linux builder | |
| 1 person starred this issue and may be notified of changes. | Back to list |
See http://chrome-master.mtv:8010/builders/chrome%20official%20linux/builds/1112/steps/unit_tests/logs/TestDownloadFilename LANG should be set to UTF-8. It is set correctly on the linux x64 builder, but not on the "chrome official linux" builder.
Jul 29, 2010
#1
evan@chromium.org
Jul 29, 2010
This is where the sensitivity comes from, DownloadManager::GenerateFileName.
It's not clear to me it's right to convert our translated string to the system native charset.
std::wstring default_name =
l10n_util::GetString(IDS_DEFAULT_DOWNLOAD_FILENAME);
#if defined(OS_WIN)
FilePath default_file_path(default_name);
#elif defined(OS_POSIX)
FilePath default_file_path(base::SysWideToNativeMB(default_name));
#endif
Jul 30, 2010
Over to jshin, who has been voted "most likely to be able to fix this bug." =)
Owner:
js...@chromium.org
Jul 30, 2010
I raised this issue a long time ago in the mailing list, but haven't followed up since. How about making Chrome only run in a UTF-8 locale and making SysNativeMBToWide and SysWideToNativeMB the same as UTF8ToWide and WideToUTF8? As for the failure at hand, I guess we just have to set the locale to a UTF-8 locale (e.g. en_US.UTF-8) directly instead of just checking the current locale and bailing out if it's not a UTF-8 locale.
Status:
Assigned
Mar 18, 2011
See http://chrome-master.mtv:8010/builders/chrome%20official%20linux/builds/1112/steps/unit_tests/logs/TestDownloadFilename LANG should be set to UTF-8. It is set correctly on the linux x64 builder, but not on the "chrome official linux" builder.
Labels:
-Area-BuildTools bulkmove Area-Build
Mar 9, 2013
(No comment was entered for this change.)
Labels:
-Area-Internals -Area-Build Cr-Internals Build
Blocking: -chromium:50469 chromium:50469 |
|
| ► Sign in to add a comment |