Issue 50659 - chromium - Menu probably not rebuilt when "you've been updated" dot appears - An open-source browser project to help move the web forward.

Issue 50659:	Menu probably not rebuilt when "you've been updated" dot appears
	4 people starred this issue and may be notified of changes.	Back to list

Status:	Verified
Owner:	rsesek@chromium.org
Closed:	Aug 2010
OS-Mac Area-UI Pri-1 Type-Bug OS-Mac ReleaseBlock-Stable Mstone-6 Verifier-Deepakg

Reported by project member thakis@chromium.org, Jul 29, 2010

I got the update dot, but didn't have the corresponding menu entry. rsesek says that the menu is probably not rebuilt for existing windows.

Seems like a blocker for the "you've been updated" feature.

Comment 1 by rsesek@chromium.org, Jul 30, 2010

(No comment was entered for this change.)

Status: Assigned
Labels: Mstone-6

Comment 2 by thakis@chromium.org, Jul 30, 2010

Got this today on another machine. I can confirm that when I open a new window, the new window's menu is correct.

Comment 3 by rsesek@chromium.org, Aug 2, 2010

(No comment was entered for this change.)

Status: Started

Comment 4 by pinkerton@chromium.org, Aug 2, 2010

(No comment was entered for this change.)

Labels: -Pri-2 Pri-1

Comment 5 by kerz@chromium.org, Aug 2, 2010

(No comment was entered for this change.)

Labels: -ReleaseBlock-Beta ReleaseBlock-Stable

Comment 6 by rsesek@chromium.org, Aug 9, 2010

CL out for review: http://codereview.chromium.org/3124002/show

Comment 7 by rsesek@chromium.org, Aug 10, 2010

Merged to 472.

Status: Fixed

Comment 8 by bugdroid1@gmail.com, Aug 10, 2010

Verified label updated by AutoAllocator, contact AmolK or KrisR for details

Labels: Verifier-Deepakg

Comment 9 by bugdroid1@gmail.com, Aug 10, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55568 

------------------------------------------------------------------------
r55568 | rsesek@chromium.org | 2010-08-10 08:47:34 -0700 (Tue, 10 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=55568&r2=55567
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/wrench_menu_controller.h?r1=55568&r2=55567
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/wrench_menu_controller.mm?r1=55568&r2=55567

[Mac] Insert the Update Chrome item to existing Wrench menus when notified.

BUG=50659
TEST=Wait for upgrade. Get yellow ball on Wrench menu. Open menu, see Update Chrome item.

Review URL: http://codereview.chromium.org/3124002
------------------------------------------------------------------------

Comment 10 by bugdroid1@gmail.com, Aug 10, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55585 

------------------------------------------------------------------------
r55585 | rsesek@chromium.org | 2010-08-10 10:59:47 -0700 (Tue, 10 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/toolbar_controller.mm?r1=55585&r2=55584
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/wrench_menu_controller.h?r1=55585&r2=55584
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/wrench_menu_controller.mm?r1=55585&r2=55584

Merge 55568 - [Mac] Insert the Update Chrome item to existing Wrench menus when notified.

BUG=50659
TEST=Wait for upgrade. Get yellow ball on Wrench menu. Open menu, see Update Chrome item.

Review URL: http://codereview.chromium.org/3124002

TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/3139003
------------------------------------------------------------------------

Comment 11 by deep...@chromium.org, Aug 26, 2010

Verified in 7.0.530.0.

Comment 12 by deep...@chromium.org, Sep 2, 2010

(No comment was entered for this change.)

Status: Verified

► Sign in to add a comment