| Issue 50575: | Mac: M6 UI. | |
| 6 people starred this issue and may be notified of changes. | Back to list |
Restricted
Sign in to add a comment
|
Reference bug for all remaining M6 theme work on Mac. See also issue 50107 .
Jul 28, 2010
#1
shess@chromium.org
Jul 29, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54188
------------------------------------------------------------------------
r54188 | shess@chromium.org | 2010-07-29 13:58:43 -0700 (Thu, 29 Jul 2010) | 32 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/Toolbar.xib?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.h?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/keyword_hint_decoration.mm?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=54188&r2=54187
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=54188&r2=54187
[Mac] First pass at final sizing of toolbar items.
Toolbar.xib changes:
- buttons from 31x27 to 29x29 so that the visual is 27x27.
- shift things left to take up opened space.
- omnibox to 29 pixels tall.
- wrench also to 29x29.
- all of that raised a single pixel to recenter.
- swap positions of home and reload.
Modify home-button-adjustment code to reflect rearranged
home/reload positions.
Increase Omnibox font size by one point to match increased field
height (and Windows Omnibox). Revise various font clients to
recognize this. Shift Omnibox baseline and other measurements to
account for increased height.
Shift globe/search icon in by one pixel so icons on both sides of
Omnibox are 4px from border. Matching shift in popup.
Fix EV-bubble to use appropriate green for text, rather than black.
Push out bubble to have a single-pixel space WRT Omnibox border.
Tighten corners to tuck into Omnibox corners. Handle different
lhs padding versus location icon (image should end up in same
spot, even though the bubble draws outside the image).
BUG=50575
TEST=none
Review URL: http://codereview.chromium.org/3046029
------------------------------------------------------------------------
Jul 30, 2010
(No comment was entered for this change.)
Labels:
Mstone-6 ForMerge ReleaseBlock-Beta
Jul 30, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54410
------------------------------------------------------------------------
r54410 | shess@chromium.org | 2010-07-30 16:43:00 -0700 (Fri, 30 Jul 2010) | 14 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/Toolbar.xib?r1=54410&r2=54409
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=54410&r2=54409
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm?r1=54410&r2=54409
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm?r1=54410&r2=54409
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm?r1=54410&r2=54409
[Mac] Un-tweak omnibox height and spacing and font.
Partial revert of http://codereview.chromium.org/3046029 .
Toolbar.xib change to make Omnibox 27px tall again.
Omnibox font back to system size, shift baselines to match, inset
location icon additional pixel to look good WRT text spacing, adjust
ev and keyword bubbles to match, adjust popup to match.
BUG=50765, 50575
TEST=See 50765
Review URL: http://codereview.chromium.org/2806098
------------------------------------------------------------------------
Aug 2, 2010
shess, are you done with this bug?
Aug 2, 2010
(No comment was entered for this change.)
Labels:
-ReleaseBlock-Beta ReleaseBlock-Stable
Aug 2, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54685
------------------------------------------------------------------------
r54685 | pkasting@chromium.org | 2010-08-02 18:53:35 -0700 (Mon, 02 Aug 2010) | 35 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/nibs/Toolbar.xib?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_unittest.mm?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/bubble_decoration.h?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/keyword_hint_decoration.mm?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/location_bar_view_mac.mm?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/toolbar_controller.mm?r1=54685&r2=54684
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=54685&r2=54684
Merge 54188 - [Mac] First pass at final sizing of toolbar items.
Toolbar.xib changes:
- buttons from 31x27 to 29x29 so that the visual is 27x27.
- shift things left to take up opened space.
- omnibox to 29 pixels tall.
- wrench also to 29x29.
- all of that raised a single pixel to recenter.
- swap positions of home and reload.
Modify home-button-adjustment code to reflect rearranged
home/reload positions.
Increase Omnibox font size by one point to match increased field
height (and Windows Omnibox). Revise various font clients to
recognize this. Shift Omnibox baseline and other measurements to
account for increased height.
Shift globe/search icon in by one pixel so icons on both sides of
Omnibox are 4px from border. Matching shift in popup.
Fix EV-bubble to use appropriate green for text, rather than black.
Push out bubble to have a single-pixel space WRT Omnibox border.
Tighten corners to tuck into Omnibox corners. Handle different
lhs padding versus location icon (image should end up in same
spot, even though the bubble draws outside the image).
BUG=50575
TEST=none
Review URL: http://codereview.chromium.org/3046029
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/3007025
------------------------------------------------------------------------
Aug 2, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54687
------------------------------------------------------------------------
r54687 | pkasting@chromium.org | 2010-08-02 18:54:41 -0700 (Mon, 02 Aug 2010) | 17 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/nibs/Toolbar.xib?r1=54687&r2=54686
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=54687&r2=54686
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm?r1=54687&r2=54686
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm?r1=54687&r2=54686
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/bubble_decoration.mm?r1=54687&r2=54686
Merge 54410 - [Mac] Un-tweak omnibox height and spacing and font.
Partial revert of http://codereview.chromium.org/3046029 .
Toolbar.xib change to make Omnibox 27px tall again.
Omnibox font back to system size, shift baselines to match, inset
location icon additional pixel to look good WRT text spacing, adjust
ev and keyword bubbles to match, adjust popup to match.
BUG=50765, 50575
TEST=See 50765
Review URL: http://codereview.chromium.org/2806098
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/3086006
------------------------------------------------------------------------
Aug 3, 2010
bugdroi1 hasn't caught up with checkins and merges, but at this point I consider this bug done. Top-of-my-mind things which slid: - omnibox 2px shorter than buttons (should be known). - location icon to text is not as tight as desired (*). - popup text aligns with field text. - RHS menu buttons don't align menu on RHS (**). (*) OS interaction, can be fixed but is a little more elaborate than I'm comfortable with for M-6. Issue 41786 has some discussion, I'll break out a separate bug at some point. (**) 10.6 has an API to manage it, but I don't have 10.6 on me.
Status:
Fixed
Cc: al...@google.com pkast...@chromium.org
Aug 3, 2010
Oh, sorry, meant to say: If you want me to cut you a Chromium.app build to look at or something, let me know.
Aug 3, 2010
Verified label updated by AutoAllocator, contact AmolK or KrisR for details
Labels:
Verifier-Ismail
Aug 3, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54782
------------------------------------------------------------------------
r54782 | shess@chromium.org | 2010-08-03 10:59:46 -0700 (Tue, 03 Aug 2010) | 21 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/Toolbar.xib?r1=54782&r2=54781
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_actions_overflow_Template.pdf
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h?r1=54782&r2=54781
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm?r1=54782&r2=54781
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm?r1=54782&r2=54781
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h?r1=54782&r2=54781
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=54782&r2=54781
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=54782&r2=54781
[Mac] Adjust toolbar spacing of browser actions for M6.
Toolbar.xib change brings browser-action container view out from under
Omnibox.
Push browser-action sizing code into controller to reduce exposed
constants. Make size consistent with other toolbar buttons. 4px
visual spacing from omnibox to first browser action (grippy in that
area), between browser actions, and last action to wrench menu.
browser_actions_overflow_Template.pdf resource for browser-action
chevron. Chevron same height as browser actions. Get rid of divider
between browser actions and wrench (future CL will integrate it into
chevron button). Chevron 4px from Omnibox or 2px from last browser
action, then 4px to wrench menu. Chevron button has hover like other
buttons.
BUG=50575
TEST=Browser-actions area still works right WRT spacing and rearranging and everything else.
Review URL: http://codereview.chromium.org/3012044
------------------------------------------------------------------------
Aug 3, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54838
------------------------------------------------------------------------
r54838 | shess@chromium.org | 2010-08-03 16:26:28 -0700 (Tue, 03 Aug 2010) | 29 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm?r1=54838&r2=54837
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/image_decoration.mm?r1=54838&r2=54837
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/keyword_hint_decoration.mm?r1=54838&r2=54837
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/page_action_decoration.h?r1=54838&r2=54837
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm?r1=54838&r2=54837
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/star_decoration.mm?r1=54838&r2=54837
Merge 54767 - [Mac] M6 Omnibox positioning changes.
3px from top and bottom of images to cell edges in popup. With this
change baselines worked out without tweaking.
Omnibox popup text wasn't quite aligned with field because previous
change used leading 'w' (regression). This change measured using
leading 'P'.
Adjust keyword-hint decoration spacing around the image. Also adjust
baseline to match font (regression).
Modify ImageDecoration to center the image horizontally, which allows
the decoration width to be independent of the image width.
PageActionDecoration uses this to pin the effective size at
|kPageActionIconMaxSize|.
Position page-action and bookmark popups so top border is at same gap
from Omnibox (2px) as Omnibox popup. The mocks actually show the
bookmark point as an additional px from the star "crotch", but I think
this is reasonable for M6.
BUG=50575, 50765
TEST=none. Everything still works?
Review URL: http://codereview.chromium.org/3015046
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/3017055
------------------------------------------------------------------------
Aug 3, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54839
------------------------------------------------------------------------
r54839 | shess@chromium.org | 2010-08-03 16:27:04 -0700 (Tue, 03 Aug 2010) | 12 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=54839&r2=54838
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.h?r1=54839&r2=54838
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/content_setting_decoration.mm?r1=54839&r2=54838
[Mac] Adjust browser-action and content-setting popup points
Adjust the browser-action popup point to leave the top border of the
window 2px below the bottom border of the Omnibox. This matches the
Omnibox popup, the bookmark popup, and page-action popups.
Likewise content-setting popup.
BUG=50575
TEST=The popup is spaced correctly.
Review URL: http://codereview.chromium.org/3054040
------------------------------------------------------------------------
Aug 3, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54840
------------------------------------------------------------------------
r54840 | shess@chromium.org | 2010-08-03 16:29:05 -0700 (Tue, 03 Aug 2010) | 24 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/nibs/Toolbar.xib?r1=54840&r2=54839
A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_actions_overflow_Template.pdf
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/browser_action_button.h?r1=54840&r2=54839
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/browser_action_button.mm?r1=54840&r2=54839
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm?r1=54840&r2=54839
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/browser_actions_controller.h?r1=54840&r2=54839
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=54840&r2=54839
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/chrome_dll.gypi?r1=54840&r2=54839
Merge 54782 - [Mac] Adjust toolbar spacing of browser actions for M6.
Toolbar.xib change brings browser-action container view out from under
Omnibox.
Push browser-action sizing code into controller to reduce exposed
constants. Make size consistent with other toolbar buttons. 4px
visual spacing from omnibox to first browser action (grippy in that
area), between browser actions, and last action to wrench menu.
browser_actions_overflow_Template.pdf resource for browser-action
chevron. Chevron same height as browser actions. Get rid of divider
between browser actions and wrench (future CL will integrate it into
chevron button). Chevron 4px from Omnibox or 2px from last browser
action, then 4px to wrench menu. Chevron button has hover like other
buttons.
BUG=50575
TEST=Browser-actions area still works right WRT spacing and rearranging and everything else.
Review URL: http://codereview.chromium.org/3012044
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/3076027
------------------------------------------------------------------------
Aug 3, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54843
------------------------------------------------------------------------
r54843 | shess@chromium.org | 2010-08-03 16:36:50 -0700 (Tue, 03 Aug 2010) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=54843&r2=54842
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button.h
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button.mm
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button_cell.h
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button_cell.mm
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/chevron_menu_button_unittest.mm
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=54843&r2=54842
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=54843&r2=54842
[Mac] Integrate divider into browser-action overflow chevron.
Divider shows when the mouse is not hovering.
BUG=50575
TEST=divider shows when the mouse is not hovering.
Review URL: http://codereview.chromium.org/3014049
------------------------------------------------------------------------
Aug 3, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54845
------------------------------------------------------------------------
r54845 | shess@chromium.org | 2010-08-03 16:46:13 -0700 (Tue, 03 Aug 2010) | 15 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=54845&r2=54844
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/content_setting_decoration.h?r1=54845&r2=54844
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/content_setting_decoration.mm?r1=54845&r2=54844
Merge 54839 - [Mac] Adjust browser-action and content-setting popup points
Adjust the browser-action popup point to leave the top border of the
window 2px below the bottom border of the Omnibox. This matches the
Omnibox popup, the bookmark popup, and page-action popups.
Likewise content-setting popup.
BUG=50575
TEST=The popup is spaced correctly.
Review URL: http://codereview.chromium.org/3054040
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/3041045
------------------------------------------------------------------------
Aug 3, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54846
------------------------------------------------------------------------
r54846 | shess@chromium.org | 2010-08-03 16:48:19 -0700 (Tue, 03 Aug 2010) | 11 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=54846&r2=54845
A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/chevron_menu_button.h
A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/chevron_menu_button.mm
A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/chevron_menu_button_cell.h
A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/chevron_menu_button_cell.mm
A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/extensions/chevron_menu_button_unittest.mm
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/chrome_browser.gypi?r1=54846&r2=54845
M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/chrome_tests.gypi?r1=54846&r2=54845
Merge 54843 - [Mac] Integrate divider into browser-action overflow chevron.
Divider shows when the mouse is not hovering.
BUG=50575
TEST=divider shows when the mouse is not hovering.
Review URL: http://codereview.chromium.org/3014049
TBR=shess@chromium.org
Review URL: http://codereview.chromium.org/3036040
------------------------------------------------------------------------
Oct 12, 2012
This issue has been closed for some time. No one will pay attention to new comments. If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels:
Restrict-AddIssueComment-Commit
Blockedon: -chromium:50107 chromium:50107
Mar 10, 2013
(No comment was entered for this change.)
Labels:
-Area-UI -Mstone-6 M-6 Cr-UI
Mar 13, 2013
(No comment was entered for this change.)
Labels:
-Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
|
||||||||||
| ► Sign in to add a comment | |||||||||||