The offending lines are in AutoFillDownloadManager::StartRequest():

  if (!request_url.compare(DISABLED_REQUEST_URL) && !is_testing_) {
    // We have it disabled - return true as if it succeeded, but do nothing.     
    return true;
  }

In branded builds, request_url is never equal to DISABLED_REQUEST_URL, so we never exit early.  We continue on to actually fetch the url, which leads to the crash.  We couldn't figure out what the intent of this code snippet was.  It sounds like we do not special-case unittests, so we should not be returning early in tests.  However, because the disabled url test triggers, we do in fact return early for non-branded tests.  Two possibilities come to mind:

1) We should be returning early for _all_ unittests.
2) We should never be returning early in unittests, in which case all of the non-branded tests are broken and do not do what we think they're doing.

I've written up a CL to disable all of the AutoFillManagerTest tests in branded builds, because crashy tests are worse than no tests.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54054 

------------------------------------------------------------------------
r54054 | rohitrao@chromium.org | 2010-07-28 15:53:09 -0700 (Wed, 28 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc?r1=54054&r2=54053

Disable AutoFillManagerTest tests in branded builds.

BUG=50537
TEST=Should not crash on official builds.
Review URL: http://codereview.chromium.org/3032034
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54088 

------------------------------------------------------------------------
r54088 | rohitrao@chromium.org | 2010-07-28 18:31:43 -0700 (Wed, 28 Jul 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autofill/autofill_manager_unittest.cc?r1=54088&r2=54087

Merge 54054 - Disable AutoFillManagerTest tests in branded builds.

BUG=50537
TEST=Should not crash on official builds.
Review URL: http://codereview.chromium.org/3032034

TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/2806089
------------------------------------------------------------------------

Fixes have been merged.  But I'm leaving this open while we investigate fixing the tests properly.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54340 

------------------------------------------------------------------------
r54340 | rohitrao@chromium.org | 2010-07-30 10:45:27 -0700 (Fri, 30 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc?r1=54340&r2=54339

Exclude AutoFillManagerTest.GetBillingSuggestionsAddress1 from running in branded builds.

BUG=50537
TEST=unit_tests should pass in branded builds.
Review URL: http://codereview.chromium.org/3068013
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54347 

------------------------------------------------------------------------
r54347 | rohitrao@chromium.org | 2010-07-30 11:19:17 -0700 (Fri, 30 Jul 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autofill/autofill_manager_unittest.cc?r1=54347&r2=54346

Merge 54340 - Exclude AutoFillManagerTest.GetBillingSuggestionsAddress1 from running in branded builds.

BUG=50537
TEST=unit_tests should pass in branded builds.
Review URL: http://codereview.chromium.org/3068013

TBR=rohitrao@chromium.org
Review URL: http://codereview.chromium.org/3026037
------------------------------------------------------------------------

(No comment was entered for this change.)

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=56435 

------------------------------------------------------------------------
r56435 | georgey@chromium.org | 2010-08-17 15:44:29 -0700 (Tue, 17 Aug 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.cc?r1=56435&r2=56434
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager.h?r1=56435&r2=56434
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autofill/autofill_manager_unittest.cc?r1=56435&r2=56434

AutoFillManagerTest.GetProfileSuggestionsEmptyValue crashes in official builds
BUG=50537
TEST=In the bug: unit test should work on any brand.

Review URL: http://codereview.chromium.org/3160022
------------------------------------------------------------------------

(No comment was entered for this change.)

Merging to 472 for additional coverage, particularly on branded builds.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=56553 

------------------------------------------------------------------------
r56553 | dhollowa@chromium.org | 2010-08-18 10:32:08 -0700 (Wed, 18 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autofill/autofill_manager.cc?r1=56553&r2=56552
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autofill/autofill_manager.h?r1=56553&r2=56552
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autofill/autofill_manager_unittest.cc?r1=56553&r2=56552

Merge 56435 - AutoFillManagerTest.GetProfileSuggestionsEmptyValue crashes in official builds
BUG=50537
TEST=In the bug: unit test should work on any brand.

Review URL: http://codereview.chromium.org/3160022

TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/3157025
------------------------------------------------------------------------

AutoFillManagerTest.GetProfileSuggestionsEmptyValue crashes.  I am able to reproduce this locally.  Email me if you need directions on how to set up a local official build.

Looks like it crashes on all platforms.

[96255:2307:0727/211853:1149669133686808:ERROR:/b/slave/chrome-official-mac/build/src/chrome/common/json_pref_store.cc(44)] Error reading Preferences: File doesn't exist. /var/folders/WQ/WQoFL9NVG1Wi1YGeJKauuU+++TI/-Tmp-/TestingProfilePath/TestPreferences: No such file or directory
[96255:2307:0727/211853:1149669134778865:FATAL:/b/slave/chrome-official-mac/build/src/chrome/common/net/url_fetcher.cc(157)] Check failed: request_context_getter_. We need an URLRequestContext!
[96255:2307:0727/211853:1149669134778865:FATAL:/b/slave/chrome-official-mac/build/src/chrome/common/net/url_fetcher.cc(157)] Check failed: request_context_getter_. We need an URLRequestContext!

This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

(No comment was entered for this change.)

(No comment was entered for this change.)