| Issue 50273: | Add "#pragma once" to all headers | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Restricted
Sign in to add a comment
|
See http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/53791dfe33d00bd9 Here's how I created the patch: hummer:src thakis$ find base -name '*.h' -a ! -path '*third_party*' -exec python tools/pragmaonce/pragmaonce.py {} \; Skipping base/windows_message_list.h : no include guard found hummer:src thakis$ time find gfx -name '*.h' -a ! -path '*third_party*' -exec python tools/pragmaonce/pragmaonce.py {} \; real 0m0.807s user 0m0.335s sys 0m0.321s hummer:src thakis$ time find net -name '*.h' -a ! -path '*third_party*' -exec python tools/pragmaonce/pragmaonce.py {} \; Skipping net/base/load_flags_list.h : no include guard found Skipping net/base/net_error_list.h : no include guard found Skipping net/base/net_log_event_type_list.h : no include guard found Skipping net/base/net_log_source_type_list.h : no include guard found Skipping net/base/sys_addrinfo.h : no include guard found Skipping net/base/test_certificate_data.h : no include guard found Skipping net/http/http_atom_list.h : no include guard found Skipping net/tools/spdyshark/moduleinfo.h : no include guard found real 0m8.127s user 0m3.586s sys 0m3.454s hummer:src thakis$ mvim net/base/load_flags_list.h hummer:src thakis$ mvim net/base/sys_addrinfo.h hummer:src thakis$ mvim net/base/test_certificate_data.h hummer:src thakis$ mvim net/tools/spdyshark/moduleinfo.h hummer:src thakis$ time find ipc -name '*.h' -a ! -path '*third_party*' -exec python tools/pragmaonce/pragmaonce.py {} \; Skipping ipc/ipc_sync_message_unittest.h : no include guard found real 0m0.480s user 0m0.207s sys 0m0.202s hummer:src thakis$ mvim ipc/ipc_sync_message_unittest.h hummer:src thakis$ time find skia -name '*.h' -a ! -path '*third_party*' -exec python tools/pragmaonce/pragmaonce.py {} \; Skipping skia/config/win/stdint.h : Broken include guard (SKIA_CONFIG_WIN_STDINT_H_, SKIA_CONFIG_WIN_STDINT_H) Skipping skia/ext/platform_canvas_win.h : no include guard found real 0m0.767s user 0m0.325s sys 0m0.316s hummer:src thakis$ mvim skia/config/win/stdint.h hummer:src thakis$ time find views -name '*.h' -a ! -path '*third_party*' -exec python tools/pragmaonce/pragmaonce.py {} \; real 0m4.224s user 0m1.782s sys 0m1.721s hummer:src thakis$ time find chrome -name '*.h' -a ! -path '*third_party*' -exec python tools/pragmaonce/pragmaonce.py {} \; Skipping chrome/app/chrome_dll_resource.h : Broken include guard (APSTUDIO_READONLY_SYMBOLS, _APS_NO_MFC) Skipping chrome/app/chrome_exe_resource.h : Broken include guard (APSTUDIO_READONLY_SYMBOLS, _APS_NO_MFC) Skipping chrome/browser/cocoa/base_bubble_controller.h : no include guard found Skipping chrome/browser/cocoa/bookmark_bar_folder_controller.h : no include guard found Skipping chrome/browser/cocoa/bookmark_bar_folder_hover_state.h : no include guard found Skipping chrome/browser/cocoa/bookmark_bar_folder_view.h : no include guard found Skipping chrome/browser/cocoa/bookmark_bubble_controller.h : no include guard found Skipping chrome/browser/cocoa/bookmark_button.h : no include guard found Skipping chrome/browser/cocoa/bookmark_drag_source.h : no include guard found Skipping chrome/browser/cocoa/bookmark_menu.h : no include guard found Skipping chrome/browser/cocoa/browser_frame_view.h : no include guard found Skipping chrome/browser/cocoa/bubble_view.h : no include guard found Skipping chrome/browser/cocoa/collected_cookies_mac.h : no include guard found Skipping chrome/browser/cocoa/content_blocked_bubble_controller.h : no include guard found Skipping chrome/browser/cocoa/content_exceptions_window_controller.h : no include guard found Skipping chrome/browser/cocoa/content_settings_dialog_controller.h : no include guard found Skipping chrome/browser/cocoa/cookie_details.h : no include guard found Skipping chrome/browser/cocoa/cookie_details_view_controller.h : no include guard found Skipping chrome/browser/cocoa/cookie_prompt_window_controller.h : no include guard found Skipping chrome/browser/cocoa/cookie_tree_node.h : no include guard found Skipping chrome/browser/cocoa/cookies_window_controller.h : no include guard found Skipping chrome/browser/cocoa/dock_icon.h : no include guard found Skipping chrome/browser/cocoa/download_item_button.h : no include guard found Skipping chrome/browser/cocoa/download_item_controller.h : no include guard found Skipping chrome/browser/cocoa/download_shelf_controller.h : no include guard found Skipping chrome/browser/cocoa/download_util_mac.h : no include guard found Skipping chrome/browser/cocoa/draggable_button.h : no include guard found Skipping chrome/browser/cocoa/edit_search_engine_cocoa_controller.h : no include guard found Skipping chrome/browser/cocoa/external_protocol_dialog.h : no include guard found Skipping chrome/browser/cocoa/find_bar_cocoa_controller.h : no include guard found Skipping chrome/browser/cocoa/find_bar_text_field.h : no include guard found Skipping chrome/browser/cocoa/find_bar_text_field_cell.h : no include guard found Skipping chrome/browser/cocoa/first_run_bubble_controller.h : no include guard found Skipping chrome/browser/cocoa/focus_tracker.h : no include guard found Skipping chrome/browser/cocoa/font_language_settings_controller.h : no include guard found Skipping chrome/browser/cocoa/fullscreen_window.h : no include guard found Skipping chrome/browser/cocoa/hover_close_button.h : no include guard found Skipping chrome/browser/cocoa/hyperlink_button_cell.h : no include guard found Skipping chrome/browser/cocoa/info_bubble_window.h : no include guard found Skipping chrome/browser/cocoa/infobar_container_controller.h : no include guard found Skipping chrome/browser/cocoa/infobar_controller.h : no include guard found Skipping chrome/browser/cocoa/infobar_test_helper.h : no include guard found Skipping chrome/browser/cocoa/keyword_editor_cocoa_controller.h : no include guard found Skipping chrome/browser/cocoa/l10n_util.h : no include guard found Skipping chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h : no include guard found Skipping chrome/browser/cocoa/location_bar/autocomplete_text_field_editor.h : no include guard found Skipping chrome/browser/cocoa/page_info_window_controller.h : no include guard found Skipping chrome/browser/cocoa/preferences_window_controller.h : no include guard found Skipping chrome/browser/cocoa/side_tab_strip_controller.h : no include guard found Skipping chrome/browser/cocoa/side_tab_strip_view.h : no include guard found Skipping chrome/browser/cocoa/simple_content_exceptions_window_controller.h : no include guard found Skipping chrome/browser/cocoa/styled_text_field.h : no include guard found Skipping chrome/browser/cocoa/styled_text_field_test_helper.h : no include guard found Skipping chrome/browser/cocoa/tab_view_picker_table.h : no include guard found Skipping chrome/browser/cocoa/theme_install_bubble_view.h : no include guard found Skipping chrome/browser/cocoa/translate/after_translate_infobar_controller.h : no include guard found Skipping chrome/browser/cocoa/translate/before_translate_infobar_controller.h : no include guard found Skipping chrome/browser/cocoa/translate/translate_message_infobar_controller.h : no include guard found Skipping chrome/browser/cocoa/web_drag_source.h : no include guard found Skipping chrome/browser/cocoa/web_drop_target.h : no include guard found Skipping chrome/browser/importer/firefox_importer_unittest_messages_internal.h : no include guard found Skipping chrome/browser/importer/importer_messages_internal.h : no include guard found Skipping chrome/common/devtools_messages_internal.h : no include guard found Skipping chrome/common/gpu_messages_internal.h : no include guard found Skipping chrome/common/nacl_messages_internal.h : no include guard found Skipping chrome/common/plugin_messages_internal.h : no include guard found Skipping chrome/common/render_messages_internal.h : no include guard found Skipping chrome/common/utility_messages_internal.h : no include guard found Skipping chrome/common/worker_messages_internal.h : no include guard found Skipping chrome/default_plugin/default_plugin_resources.h : no include guard found Skipping chrome/default_plugin/plugin_impl.h : no include guard found Skipping chrome/default_plugin/plugin_main.h : no include guard found Skipping chrome/installer/gcapi/resource.h : Broken include guard (APSTUDIO_READONLY_SYMBOLS, _APS_NEXT_RESOURCE_VALUE) Skipping chrome/installer/mini_installer/mini_installer_resource.h : Broken include guard (APSTUDIO_READONLY_SYMBOLS, _APS_NO_MFC) Skipping chrome/installer/setup/setup_resource.h : Broken include guard (APSTUDIO_READONLY_SYMBOLS, _APS_NEXT_RESOURCE_VALUE) Skipping chrome/installer/util/installer_util_unittests_resource.h : Broken include guard (APSTUDIO_READONLY_SYMBOLS, _APS_NEXT_RESOURCE_VALUE) Skipping chrome/test/automation/automation_messages_internal.h : no include guard found Skipping chrome/tools/profiles/thumbnail-inl.h : no include guard found Skipping chrome/translate_infobar.h : no include guard found real 0m51.457s user 0m22.829s sys 0m22.072s hummer:src thakis$ time find app -name '*.h' -a ! -path '*third_party*' -exec python tools/pragmaonce/pragmaonce.py {} \; Skipping app/test/data/resource.h : Broken include guard (APSTUDIO_READONLY_SYMBOLS, _APS_NEXT_RESOURCE_VALUE) real 0m1.915s user 0m0.821s sys 0m0.793s After that, I manually reverted the change to ipc/ipc_message_macros.h
Oct 12, 2012
This issue has been closed for some time. No one will pay attention to new comments. If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels:
Restrict-AddIssueComment-Commit
Mar 10, 2013
(No comment was entered for this change.)
Labels:
-Area-Internals Cr-Internals
|
||||||||
| ► Sign in to add a comment | |||||||||
The following revision refers to this bug: http://src.chromium.org/viewvc/chrome?view=rev&revision=53713 ------------------------------------------------------------------------ r53713 | thakis@chromium.org | 2010-07-26 15:46:25 -0700 (Mon, 26 Jul 2010) | 8 lines Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/skia/config/win/stdint.h?r1=53713&r2=53712 Fix include guard BUG=50273 TEST=none TBR=erg Review URL: http://codereview.chromium.org/3043022 ------------------------------------------------------------------------