| Issue 50266: | Fix a bunch of presubmit errors | |
| 3 people starred this issue and may be notified of changes. | Back to list |
Restricted
Sign in to add a comment
|
Here's what I got when uploading my "pragma once" patch:
hummer:src thakis$ EDITOR=emacs git cl upload
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/autocomplete/keyword_provider.h:50: Labels should always be indented at least one space. If this is a member-initializer list in a constructor, the colon should be on the line after the definition header. [whitespace/labels] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/automation/automation_extension_tracker.h:17: Single-argument constructors should be marked explicit. [runtime/explicit] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/automation/automation_provider_observers.h:640: Labels should always be indented at least one space. If this is a member-initializer list in a constructor, the colon should be on the line after the definition header. [whitespace/labels] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/bookmarks/recently_used_folders_combo_model.h:5: #ifndef header guard has wrong style, please use: CHROME_BROWSER_BOOKMARKS_RECENTLY_USED_FOLDERS_COMBO_MODEL_H_ [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/bookmarks/recently_used_folders_combo_model.h:41: #endif line should be "#endif // CHROME_BROWSER_BOOKMARKS_RECENTLY_USED_FOLDERS_COMBO_MODEL_H_" [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/browser_process_sub_thread.h:41: #endif line should be "#endif // CHROME_BROWSER_BROWSER_PROCESS_SUB_THREAD_H_" [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/extensions/extension_bookmark_helpers.h:35: #endif line should be "#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_BOOKMARK_HELPERS_H_" [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/geolocation/gps_location_provider_linux.h:32: Single-argument constructors should be marked explicit. [runtime/explicit] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/gtk/gtk_chrome_button.h:21: Extra space before ( in function call [whitespace/parens] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/gtk/gtk_chrome_button.h:23: Extra space before ( in function call [whitespace/parens] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/gtk/gtk_chrome_button.h:25: Extra space before ( in function call [whitespace/parens] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/gtk/gtk_chrome_link_button.h:27: Extra space before ( in function call [whitespace/parens] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/gtk/gtk_chrome_link_button.h:29: Extra space before ( in function call [whitespace/parens] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/gtk/gtk_chrome_link_button.h:31: Extra space before ( in function call [whitespace/parens] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/importer/mork_reader.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/net/chrome_network_delegate.h:31: #endif line should be "#endif // CHROME_BROWSER_NET_CHROME_NETWORK_DELEGATE_H_" [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/renderer_host/audio_sync_reader.h:5: #ifndef header guard has wrong style, please use: CHROME_BROWSER_RENDERER_HOST_AUDIO_SYNC_READER_H_ [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/renderer_host/audio_sync_reader.h:56: #endif line should be "#endif // CHROME_BROWSER_RENDERER_HOST_AUDIO_SYNC_READER_H_" [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/resources_util.h:5: #ifndef header guard has wrong style, please use: CHROME_BROWSER_RESOURCES_UTIL_H_ [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/resources_util.h:23: #endif line should be "#endif // CHROME_BROWSER_RESOURCES_UTIL_H_" [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/scoped_pref_update.h:24: #endif line should be "#endif // CHROME_BROWSER_SCOPED_PREF_UPDATE_H_" [build/header_guard] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/sync/engine/syncer_types.h:149: Single-argument constructors should be marked explicit. [runtime/explicit] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/sync/test_profile_sync_service.h:38: Labels should always be indented at least one space. If this is a member-initializer list in a constructor, the colon should be on the line after the definition header. [whitespace/labels] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/views/infobars/after_translate_infobar.h:28: Labels should always be indented at least one space. If this is a member-initializer list in a constructor, the colon should be on the line after the definition header. [whitespace/labels] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/common/plugin_messages.h:149: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/common/plugin_messages.h:407: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/default_plugin/plugin_install_job_monitor.h:19: Labels should always be indented at least one space. If this is a member-initializer list in a constructor, the colon should be on the line after the definition header. [whitespace/labels] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/test/automation/javascript_message_utils.h:121: Potential format string bug. Do StringPrintf("%s", format.c_str() instead. [runtime/printf] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/test/automation/javascript_message_utils.h:128: Potential format string bug. Do StringPrintf("%s", format.c_str() instead. [runtime/printf] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/test/automation/javascript_message_utils.h:137: Potential format string bug. Do StringPrintf("%s", format.c_str() instead. [runtime/printf] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/test/pyautolib/pyautolib.h:156: Missing spaces around = [whitespace/operators] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/test/pyautolib/pyautolib.h:158: Missing spaces around = [whitespace/operators] [4]
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/test/pyautolib/pyautolib.h:159: Missing spaces around = [whitespace/operators] [4]
Found a bad license header in these files:
app/app_paths.h \
app/app_switches.h \
chrome/browser/bookmarks/bookmark_service.h \
chrome/browser/chromeos/panels/panel_scroller.h \
chrome/browser/chromeos/panels/panel_scroller_container.h \
chrome/browser/chromeos/panels/panel_scroller_header.h \
chrome/browser/clipboard_dispatcher.h \
chrome/browser/importer/mork_reader.h \
chrome/browser/in_process_webkit/browser_webkitclient_impl.h \
chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h \
chrome/browser/in_process_webkit/dom_storage_namespace.h \
chrome/browser/views/chrome_views_delegate.h \
chrome/common/dom_storage_common.h \
chrome/common/extensions/user_script.h \
chrome/common/webkit_param_traits.h \
chrome/renderer/renderer_sandbox_support_linux.h \
chrome/renderer/renderer_webstoragenamespace_impl.h \
chrome/renderer/webmediaplayer_impl.h \
chrome/renderer/websharedworkerrepository_impl.h \
chrome/test/menu_model_test.h \
net/base/file_stream.h \
net/base/registry_controlled_domain.h \
net/ftp/ftp_ctrl_response_buffer.h \
net/ftp/ftp_directory_listing_buffer.h \
net/ftp/ftp_directory_listing_parser.h \
net/ftp/ftp_directory_listing_parser_ls.h \
net/ftp/ftp_directory_listing_parser_mlsd.h \
net/ftp/ftp_directory_listing_parser_netware.h \
net/ftp/ftp_directory_listing_parser_unittest.h \
net/ftp/ftp_directory_listing_parser_vms.h \
net/ftp/ftp_directory_listing_parser_windows.h \
net/ftp/ftp_network_layer.h \
net/ftp/ftp_network_session.h \
net/ftp/ftp_request_info.h \
net/ftp/ftp_response_info.h \
net/ftp/ftp_transaction.h \
net/ftp/ftp_transaction_factory.h \
net/http/http_chunked_decoder.h \
net/http/md4.h \
net/proxy/proxy_resolver_script.h \
net/tools/flip_server/other_defines.h \
net/tools/flip_server/string_piece_utils.h \
net/tools/spdyshark/packet-spdy.h \
views/controls/button/native_button_gtk.h \
views/controls/button/native_button_wrapper.h \
views/controls/button/radio_button.h \
views/controls/combobox/native_combobox_gtk.h \
views/controls/combobox/native_combobox_win.h \
views/controls/combobox/native_combobox_wrapper.h \
views/controls/native/native_view_host_wrapper.h \
views/controls/native_control_win.h \
views/controls/scrollbar/native_scroll_bar_wrapper.h \
views/controls/slider/native_slider_wrapper.h \
views/controls/table/native_table_gtk.h \
views/controls/table/native_table_wrapper.h \
views/views_delegate.h \
views/window/window.h
** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
base/ref_counted.h, line 113, 82 chars \
chrome/browser/bookmarks/bookmark_drag_data.h, line 100, 81 chars \
chrome/browser/child_process_security_policy.h, line 119, 83 chars \
chrome/browser/ime_input.h, line 227, 81 chars \
chrome/common/webkit_param_traits.h, line 16, 81 chars
Found line ending with white spaces in:
***************
chrome/common/font_descriptor_mac.h, line 22
chrome/common/font_descriptor_mac.h, line 28
chrome/installer/util/installer_util_unittests_resource.h, line 10
net/tools/fetch/http_server_response_info.h, line 15
***************
Changelist failed cpplint.py check.
That should probably all be fixed.
Jul 28, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=53956
------------------------------------------------------------------------
r53956 | tfarina@chromium.org | 2010-07-28 09:28:13 -0700 (Wed, 28 Jul 2010) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/font_descriptor_mac.h?r1=53956&r2=53955
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/installer/util/installer_util_unittests_resource.h?r1=53956&r2=53955
M http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/fetch/http_server_response_info.h?r1=53956&r2=53955
Fix line ending with white spaces in some files.
BUG=50266
TEST=None
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3046028
------------------------------------------------------------------------
Jul 28, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=53958
------------------------------------------------------------------------
r53958 | tfarina@chromium.org | 2010-07-28 09:48:10 -0700 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/ref_counted.h?r1=53958&r2=53957
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h?r1=53958&r2=53957
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/child_process_security_policy.h?r1=53958&r2=53957
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ime_input.h?r1=53958&r2=53957
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/webkit_param_traits.h?r1=53958&r2=53957
Fix lines longer than 80 characters.
BUG=50266
TEST=None
Review URL: http://codereview.chromium.org/3013038
------------------------------------------------------------------------
Jul 28, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=53974
------------------------------------------------------------------------
r53974 | tfarina@chromium.org | 2010-07-28 10:32:38 -0700 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/button/native_button_gtk.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/button/native_button_wrapper.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/button/radio_button.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/combobox/native_combobox_gtk.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/combobox/native_combobox_win.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/combobox/native_combobox_wrapper.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native/native_view_host_wrapper.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/native_control_win.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/scrollbar/native_scroll_bar_wrapper.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/slider/native_slider_wrapper.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/table/native_table_gtk.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/table/native_table_wrapper.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/views_delegate.h?r1=53974&r2=53973
M http://src.chromium.org/viewvc/chrome/trunk/src/views/window/window.h?r1=53974&r2=53973
views: Fix bad license headers found in some files
BUG=50266
TEST=None
Review URL: http://codereview.chromium.org/3017036
------------------------------------------------------------------------
Jul 29, 2010
(No comment was entered for this change.)
Labels:
not-extensions
Jul 29, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54020
------------------------------------------------------------------------
r54020 | tfarina@chromium.org | 2010-07-28 14:16:30 -0700 (Wed, 28 Jul 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/keyword_provider.h?r1=54020&r2=54019
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_extension_tracker.h?r1=54020&r2=54019
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/recently_used_folders_combo_model.h?r1=54020&r2=54019
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_bookmark_helpers.h?r1=54020&r2=54019
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/geolocation/gps_location_provider_linux.h?r1=54020&r2=54019
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/chrome_network_delegate.h?r1=54020&r2=54019
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/audio_sync_reader.h?r1=54020&r2=54019
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources_util.h?r1=54020&r2=54019
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/scoped_pref_update.h?r1=54020&r2=54019
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/engine/syncer_types.h?r1=54020&r2=54019
browser: Fix some presubmit errors.
BUG=50266
TEST=None
Review URL: http://codereview.chromium.org/3026031
------------------------------------------------------------------------
Jul 30, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54420
------------------------------------------------------------------------
r54420 | tfarina@chromium.org | 2010-07-30 18:24:44 -0700 (Fri, 30 Jul 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/test_profile_sync_service.h?r1=54420&r2=54419
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/infobars/after_translate_infobar.h?r1=54420&r2=54419
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/pyautolib/pyautolib.h?r1=54420&r2=54419
Fix presubmit errors part 2.
BUG=50266
TEST=None
Review URL: http://codereview.chromium.org/3064026
------------------------------------------------------------------------
Jul 31, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54450
------------------------------------------------------------------------
r54450 | tfarina@chromium.org | 2010-07-31 08:33:32 -0700 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_service.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/panels/panel_scroller.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/panels/panel_scroller_container.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/panels/panel_scroller_header.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/in_process_webkit/browser_webkitclient_impl.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/in_process_webkit/dom_storage_namespace.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/chrome_views_delegate.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/dom_storage_common.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/user_script.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/webkit_param_traits.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_sandbox_support_linux.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_webstoragenamespace_impl.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/webmediaplayer_impl.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/websharedworkerrepository_impl.h?r1=54450&r2=54449
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/menu_model_test.h?r1=54450&r2=54449
Fix bad license header under chrome/ directory.
BUG=50266
TEST=None
Review URL: http://codereview.chromium.org/2847091
------------------------------------------------------------------------
Jul 31, 2010
What we can do about these following files? They have third party copyright headers. chrome/browser/importer/mork_reader.h net/base/registry_controlled_domain.h net/http/http_chunked_decoder.h net/http/md4.h net/proxy/proxy_resolver_script.h net/tools/spdyshark/packet-spdy.h
Status:
Started
Jul 31, 2010
We need to talk to the people who checked them in and then probably move them to third_party. Needs to be decided on a case-by-case basis. Not sure what to do if the people who checked them in don't want to see them in third_party though. In that case, we probably need to ask chromium-dev for advice.
Aug 2, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54482
------------------------------------------------------------------------
r54482 | tfarina@chromium.org | 2010-07-31 16:10:07 -0700 (Sat, 31 Jul 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/app/app_paths.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/app/app_switches.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/base/file_stream.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_ctrl_response_buffer.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_buffer.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_parser.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_parser_ls.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_parser_mlsd.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_parser_netware.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_parser_unittest.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_parser_vms.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_parser_windows.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_network_layer.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_network_session.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_request_info.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_response_info.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_transaction_factory.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/flip_server/other_defines.h?r1=54482&r2=54481
M http://src.chromium.org/viewvc/chrome/trunk/src/net/tools/flip_server/string_piece_utils.h?r1=54482&r2=54481
Fix bad license header in app/ and net/ directories.
BUG=50266
TEST=None
Review URL: http://codereview.chromium.org/3013049
------------------------------------------------------------------------
Aug 2, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54486
------------------------------------------------------------------------
r54486 | tfarina@chromium.org | 2010-07-31 18:50:55 -0700 (Sat, 31 Jul 2010) | 19 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_chrome_button.h?r1=54486&r2=54485
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_chrome_link_button.h?r1=54486&r2=54485
gtk: Fix presubmit errors.
chrome/browser/gtk/gtk_chrome_button.h:21: Extra space before ( in function
call [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_button.h:23: Extra space before ( in function
call [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_button.h:25: Extra space before ( in function
call [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_link_button.h:27: Extra space before ( in
function call [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_link_button.h:29: Extra space before ( in
function call [whitespace/parens] [4]
chrome/browser/gtk/gtk_chrome_link_button.h:31: Extra space before ( in
function call [whitespace/parens] [4]
BUG=50266
TEST=None
Review URL: http://codereview.chromium.org/3064027
------------------------------------------------------------------------
Aug 2, 2010
I think the only thing left to do here are what we say in comment 9 and comment 10.
Aug 2, 2010
Brian for: chrome/browser/importer/mork_reader.h
Pamela for: net/base/registry_controlled_domain.h
Darin for: net/http/http_chunked_decoder.h, net/http/md4.h
net/proxy/proxy_resolver_script.h.
Mike for: net/tools/spdyshark/packet-spdy.h
Cc:
bry...@chromium.org p...@chromium.org da...@chromium.org mbel...@chromium.org
Aug 3, 2010
tfarina- not sure what you mean by comment 14. Surely you don't need to add pragma once to these non-interesting headers (like packet-spdy.h)?
Aug 3, 2010
Mike what I mean is that we are trying to fix the header files with bad license header. And this header file doesn't have the standard license header. Please see the comment 10 of Nico.
Aug 3, 2010
That file uses a format which is compatible with wireshark plugins, because we are pushing the code to the wireshark repository. The license mismatch is a bogus warning and should be removed from our presubmit warnings altogether.
Aug 3, 2010
Mike is correct. We should remove that directory (net/tools/spdyshark) from our lint checks. It doesn't even link into the Chrome build.
Aug 3, 2010
Evan, it should be added to _EXCLUDED_PATHS in Presubmit.py?
Aug 3, 2010
Yes.
Aug 3, 2010
registry_controlled_domain.h and .cc were originally written by me for Mozilla, then significantly rewritten by others (still for Mozilla), then pulled into our repository and significantly rewritten again by me. They're certainly not third-party files. On the other hand, it wouldn't be right to disregard their ancestry, either. We should check with our open-source license experts, but it looks to me like we could remove the Mozilla license section, as long as we add a "prominent notice" that it was forked from their source, and when. I'll ask around to confirm.
Aug 3, 2010
mork_reader was originally written by me for Mozilla, but I wasn't involved with pulling it into chromium or any changes afterwards. It might be a similar situation to what Pam mentioned for registry_controlled_domain.
Aug 3, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=54857
------------------------------------------------------------------------
r54857 | tfarina@chromium.org | 2010-08-03 18:25:42 -0700 (Tue, 03 Aug 2010) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/PRESUBMIT.py?r1=54857&r2=54856
Add net/tools/spdyshark/ to the presubmit exclude path list.
With that the lint doesn't complain about bad license header.
BUG=50266
TEST=None
Review URL: http://codereview.chromium.org/3080024
------------------------------------------------------------------------
Aug 4, 2010
Open-source license experts contacted. I'll report back when they reply.
Aug 19, 2010
Pam, any news on this from the open-source license guys?
Aug 21, 2010
Yes. Unfortunately the Mozilla tri-license and our BSD-style one are not compatible, so we need to keep the original licenses intact.
Oct 12, 2010
(No comment was entered for this change.)
Status:
Fixed
Owner: tfar...@chromium.org
Oct 12, 2012
This issue has been closed for some time. No one will pay attention to new comments. If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels:
Restrict-AddIssueComment-Commit
Mar 9, 2013
(No comment was entered for this change.)
Labels:
-Type-Cleanup -Pri-2 -Area-Internals Type-Bug Cr-Internals Pri-3
|
||||||||||
| ► Sign in to add a comment | |||||||||||
Labels: HelpWanted