My favorites ▼ | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 50107: Windows: M6 UI
14 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  pkasting@chromium.org
Closed:  Aug 2010
M-6

Blocking:
issue 50575

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Project Member Reported by pkasting@chromium.org, Jul 23, 2010 
Reference bug for all remaining M6 theme work on Windows.
Jul 26, 2010
#1 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53715 

------------------------------------------------------------------------
r53715 | pkasting@chromium.org | 2010-07-26 15:58:19 -0700 (Mon, 26 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=53715&r2=53714
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/base_tab.cc?r1=53715&r2=53714

Remove code to handle bogus themes.  We've had a theming system for a while and don't care about people who manually hack the DLLs.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3071002
------------------------------------------------------------------------
Jul 26, 2010
#2 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53732 

------------------------------------------------------------------------
r53732 | pkasting@chromium.org | 2010-07-26 18:00:27 -0700 (Mon, 26 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/app_resources.grd?r1=53732&r2=53731
   D /trunk/src/app/resources/resize_gripper.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=53732&r2=53731
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h?r1=53732&r2=53731
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=53732&r2=53731
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=53732&r2=53731
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_installed_bubble.cc?r1=53732&r2=53731
   A http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/resize_area.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/views/controls/resize_area.h
   D /trunk/src/views/controls/resize_gripper.cc
   D /trunk/src/views/controls/resize_gripper.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/views/views.gyp?r1=53732&r2=53731

Make the resize gripper invisible.

BUG=50107
TEST=Resize gripper nest to browser actions container should no longer appear
Review URL: http://codereview.chromium.org/3052011
------------------------------------------------------------------------
Jul 26, 2010
#3 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53733 

------------------------------------------------------------------------
r53733 | pkasting@chromium.org | 2010-07-26 18:00:51 -0700 (Mon, 26 Jul 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/omnibox_history_dark_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_history_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_http_dark_transparent.png
   D /trunk/src/chrome/app/theme/omnibox_http_transparent.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=53733&r2=53732
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.cc?r1=53733&r2=53732

Remove IDR_OMNIBOX_*_TRANSPARENT images.  The comments for why we need them are out-of-date -- the normal images no longer have white backgrounds, and we don't need an extra "transparent" set.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3075001
------------------------------------------------------------------------
Jul 26, 2010
#4 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53736 

------------------------------------------------------------------------
r53736 | pkasting@chromium.org | 2010-07-26 18:39:13 -0700 (Mon, 26 Jul 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/background_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/background_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/eula_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/eula_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/network_selection_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/network_selection_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/new_user_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/new_user_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/oobe_progress_bar.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/oobe_progress_bar.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/user_image_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/user_image_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/status/language_menu_button.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/status/language_menu_button.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_instructions_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_instructions_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/constrained_window_win.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/download_shelf_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/download_shelf_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_shelf.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_shelf.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/base_tab.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/base_tab.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_strip.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_strip.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/views/view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/views/view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/views/widget/root_view.cc?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/views/widget/root_view.h?r1=53736&r2=53735
   M http://src.chromium.org/viewvc/chrome/trunk/src/views/window/non_client_view.cc?r1=53736&r2=53735

Make theme change notifications auto-propagate through the view hierarchy, instead of forcing subclasses to manually call their superclass implementation.  This fixes some problems where not all views would get notified of a theme change.

Make naming for theme and locale changes consistent and clear.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/2878055
------------------------------------------------------------------------
Jul 26, 2010
#5 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53739 

------------------------------------------------------------------------
r53739 | pkasting@chromium.org | 2010-07-26 18:46:50 -0700 (Mon, 26 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=53739&r2=53738
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=53739&r2=53738

Cleanup: Remove dead code (was only called when we had app + page menus).  Nicer indenting.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3073002
------------------------------------------------------------------------
Jul 26, 2010
#6 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53740 

------------------------------------------------------------------------
r53740 | pkasting@chromium.org | 2010-07-26 18:47:01 -0700 (Mon, 26 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tab_icon_view.cc?r1=53740&r2=53739
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/base_tab.cc?r1=53740&r2=53739
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/base_tab.h?r1=53740&r2=53739
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab.cc?r1=53740&r2=53739

Make the throbber and tab close button correctly respond to theme changes.  This is partly using GetThemeProvider() instead of ResourceBundle::GetSharedInstance(), and partly not caching SkBitmaps (which we used to do long ago but stopped because it's pointless).

BUG=50107
TEST=Throbber responds to theme changes
Review URL: http://codereview.chromium.org/3064006
------------------------------------------------------------------------
Jul 26, 2010
#7 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53741 

------------------------------------------------------------------------
r53741 | pkasting@chromium.org | 2010-07-26 18:48:29 -0700 (Mon, 26 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc?r1=53741&r2=53740
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=53741&r2=53740
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h?r1=53741&r2=53740
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/custom_button.cc?r1=53741&r2=53740
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/custom_button.h?r1=53741&r2=53740

Cleanup: Rename gtk button state names to (a) match other platforms and (b) not be misleading (e.g. "depressed" where it should be "disabled").  Better indenting.  Inline a function that has only one caller for simplicity.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3029032
------------------------------------------------------------------------
Jul 27, 2010
#8 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53841 

------------------------------------------------------------------------
r53841 | pkasting@chromium.org | 2010-07-27 14:18:10 -0700 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=53841&r2=53840
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=53841&r2=53840
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container_browsertest.cc?r1=53841&r2=53840

Cleanup: Remove pointless GetInsets() override.  Simplify |container_size_| to just be |container_width_|.  Fix indenting/alignment, especially of function parameters.  L"" -> std::wstring().  Don't handle assertion violations (style guide/simplicity).  Reduce indenting via early-return or simpler-path-return.  Streamline code where possible.  Definition order should match declaration order.  EXPECT_STREQ -> EXPECT_EQ.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3076001
------------------------------------------------------------------------
Jul 27, 2010
#9 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53842 

------------------------------------------------------------------------
r53842 | pkasting@chromium.org | 2010-07-27 14:19:01 -0700 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/wrench_menu.cc?r1=53842&r2=53841

Mirror wrench menu corner alignment in RTL mode.

BUG=50107
TEST=Run chrome --lang=he, click the wrench; the button and dropdown should align on the left edge, not the right.
Review URL: http://codereview.chromium.org/3017033
------------------------------------------------------------------------
Jul 27, 2010
#12 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53869 

------------------------------------------------------------------------
r53869 | pkasting@chromium.org | 2010-07-27 17:03:26 -0700 (Tue, 27 Jul 2010) | 6 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_action.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_action_h.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_action_p.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_actions_overflow.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_actions_overflow_h.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_actions_overflow_p.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_actions_overflow_win.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_actions_overflow_win_h.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/browser_actions_overflow_win_p.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/keyword_search_magnifier.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/notification_wrench_p.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/star.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/star.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/star_lit.pdf
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/star_lit.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/tools_h.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/tools_p.png

Add new images for M6 theme changes.  This is done separately so that the code changes that use them can be run on the trybots.

TBR=ben
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3013037
------------------------------------------------------------------------
Jul 27, 2010
#13 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53886 

------------------------------------------------------------------------
r53886 | pkasting@chromium.org | 2010-07-27 18:06:56 -0700 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/balloon_wrench.png
   D /trunk/src/chrome/app/theme/balloon_wrench_hover.png
   D /trunk/src/chrome/app/theme/blocked_javascript.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/blocked_script.png
   D /trunk/src/chrome/app/theme/bubble_b_arrow.png
   D /trunk/src/chrome/app/theme/bubble_l_arrow.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_pointer_b.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_pointer_l.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_pointer_r.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_pointer_t.png
   D /trunk/src/chrome/app/theme/bubble_r_arrow.png
   D /trunk/src/chrome/app/theme/bubble_t_arrow.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ev_bubble_c.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ev_bubble_l.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ev_bubble_r.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/keyword_search_bubble_c.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/keyword_search_bubble_l.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/keyword_search_bubble_r.png
   D /trunk/src/chrome/app/theme/location_bar_keyword_search_c.png
   D /trunk/src/chrome/app/theme/location_bar_keyword_search_l.png
   D /trunk/src/chrome/app/theme/location_bar_keyword_search_r.png
   D /trunk/src/chrome/app/theme/locationbg_c.png
   D /trunk/src/chrome/app/theme/locationbg_l.png
   D /trunk/src/chrome/app/theme/locationbg_r.png
   D /trunk/src/chrome/app/theme/locationbg_readonly_center.png
   D /trunk/src/chrome/app/theme/locationbg_readonly_edge.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/notification_wrench.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/notification_wrench_h.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_c.png
   D /trunk/src/chrome/app/theme/omnibox_ev_bubble_background_c.png
   D /trunk/src/chrome/app/theme/omnibox_ev_bubble_background_l.png
   D /trunk/src/chrome/app/theme/omnibox_ev_bubble_background_r.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_l.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_popup_c.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_popup_edge.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_r.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=53886&r2=53885

Rename some resource files for clarity, or to fit better with upcoming theme resources.  Does not rename the identifiers yet, so as to minimize code change.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3035033
------------------------------------------------------------------------
Jul 27, 2010
#14 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53887 

------------------------------------------------------------------------
r53887 | pkasting@chromium.org | 2010-07-27 18:07:28 -0700 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=53887&r2=53886
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=53887&r2=53886

Swap reload and home back to how they were in Chrome <= 5.

BUG=50107
TEST=Reload should be left of home
Review URL: http://codereview.chromium.org/3056023
------------------------------------------------------------------------
Jul 27, 2010
#15 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53888 

------------------------------------------------------------------------
r53888 | pkasting@chromium.org | 2010-07-27 18:09:00 -0700 (Tue, 27 Jul 2010) | 5 lines
Changed paths:
   D /trunk/src/chrome/app/theme/back_mask.png
   D /trunk/src/chrome/app/theme/button_mask.png
   D /trunk/src/chrome/app/theme/forward_mask.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=53888&r2=53887
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=53888&r2=53887

Remove button masks for toolbar buttons, which will no longer be needed in the new theme.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3063011
------------------------------------------------------------------------
Jul 28, 2010
#16 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53993 

------------------------------------------------------------------------
r53993 | pkasting@chromium.org | 2010-07-28 12:21:40 -0700 (Wed, 28 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chromium_strings.grd?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/google_chrome_strings.grd?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_pack.cc?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration.mm?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/star_decoration.mm?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar/star_view.cc?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/notifications/balloon_view.cc?r1=53993&r2=53992
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_dll.gypi?r1=53993&r2=53992

Modified resources for M6 theme.  This doesn't actually modify layout yet, just images and identifier names.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3035034
------------------------------------------------------------------------
Jul 28, 2010
#17 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54015 

------------------------------------------------------------------------
r54015 | pkasting@chromium.org | 2010-07-28 13:59:20 -0700 (Wed, 28 Jul 2010) | 4 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/back.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/back_d.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/back_h.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/back_p.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/blocked_cookies.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/blocked_images.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/blocked_plugins.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/blocked_popups.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/blocked_script.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_b.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_bl.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_br.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_l.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_pointer_b.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_pointer_l.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_pointer_r.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_pointer_t.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_r.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_t.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_tl.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/bubble_tr.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/content_top_center.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/content_top_left_corner.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/content_top_left_corner_mask.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/content_top_right_corner.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/content_top_right_corner_mask.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ev_bubble_c.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ev_bubble_l.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/ev_bubble_r.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/forward.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/forward_d.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/forward_h.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/forward_p.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/home.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/home_h.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/home_p.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/keyword_search_bubble_c.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/keyword_search_bubble_l.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/keyword_search_bubble_r.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/notification_wrench.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/notification_wrench_h.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_c.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_history.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_history_dark.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_history_selected.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_http.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_http_dark.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_http_selected.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_valid.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_https_warning.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_l.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_more.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_more_dark.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_more_selected.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_r.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_search.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_search_dark.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_search_selected.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_star.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_star_dark.png?r1=54015&r2=54014
   D /trunk/src/chrome/app/theme/omnibox_star_lit.pdf
   D /trunk/src/chrome/app/theme/omnibox_star_lit.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/omnibox_star_selected.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/reload.png?r1=54015&r2=54014
   D /trunk/src/chrome/app/theme/reload_d.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/reload_h.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/reload_p.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/stop.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/stop_h.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/stop_p.png?r1=54015&r2=54014
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/tools.png?r1=54015&r2=54014

Meant this to go in r53993... here are the actual new binaries for the theme images.

BUG=50107
TEST=none
------------------------------------------------------------------------
Jul 28, 2010
#18 fabios4rulez 
there is a regression with the cursor position. In some cases it can overlap the reload/stop button. please see  issue 50605  for details.
Jul 29, 2010
#19 fabios4rulez 
also, the new home page button has extra pudding on the bottom part. Very annoying on dark themes. see issue 50667 for details
Jul 29, 2010
#21 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54049 

------------------------------------------------------------------------
r54049 | pkasting@chromium.org | 2010-07-28 15:41:05 -0700 (Wed, 28 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=54049&r2=54048
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=54049&r2=54048
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/wrench_menu.cc?r1=54049&r2=54048

Toolbar layout changes for M6 theme.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3033036
------------------------------------------------------------------------
Jul 29, 2010
#22 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54174 

------------------------------------------------------------------------
r54174 | pkasting@chromium.org | 2010-07-29 13:19:24 -0700 (Thu, 29 Jul 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=54174&r2=54173
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=54174&r2=54173
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=54174&r2=54173

Browser actions container layout changes for M6 theme.

In short, this:
* Eliminates the divider on the right (the new chevron has a built-in divider)
* Changes the padding between items (see updated comments in header for precise layout details)
* Updates the imagery for the new theme
* Makes the chevron respond to theme changes

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3057016
------------------------------------------------------------------------
Aug 2, 2010
#23 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54644 

------------------------------------------------------------------------
r54644 | pkasting@chromium.org | 2010-08-02 17:52:06 -0700 (Mon, 02 Aug 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached?r1=54644&r2=54643

Forgot to land this when I landed all the image resource changes.

TBR=erg
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3078018
------------------------------------------------------------------------
Aug 2, 2010
#24 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54654 

------------------------------------------------------------------------
r54654 | pkasting@chromium.org | 2010-08-02 18:05:45 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/generated_resources.grd?r1=54654&r2=54653
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/base_tab.cc?r1=54654&r2=54653

Merge 53715 - Remove code to handle bogus themes.  We've had a theming system for a while and don't care about people who manually hack the DLLs.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3071002

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3069020
------------------------------------------------------------------------
Aug 2, 2010
#25 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54660 

------------------------------------------------------------------------
r54660 | pkasting@chromium.org | 2010-08-02 18:14:37 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/app/resources/app_resources.grd?r1=54660&r2=54659
   D /branches/472/src/app/resources/resize_gripper.png
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=54660&r2=54659
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h?r1=54660&r2=54659
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/browser_actions_container.cc?r1=54660&r2=54659
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/browser_actions_container.h?r1=54660&r2=54659
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/extensions/extension_installed_bubble.cc?r1=54660&r2=54659
   A http://src.chromium.org/viewvc/chrome/branches/472/src/views/controls/resize_area.cc
   A http://src.chromium.org/viewvc/chrome/branches/472/src/views/controls/resize_area.h
   D /branches/472/src/views/controls/resize_gripper.cc
   D /branches/472/src/views/controls/resize_gripper.h
   M http://src.chromium.org/viewvc/chrome/branches/472/src/views/views.gyp?r1=54660&r2=54659

Merge 53732 - Make the resize gripper invisible.

BUG=50107
TEST=Resize gripper nest to browser actions container should no longer appear
Review URL: http://codereview.chromium.org/3052011

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3048043
------------------------------------------------------------------------
Aug 2, 2010
#26 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54661 

------------------------------------------------------------------------
r54661 | pkasting@chromium.org | 2010-08-02 18:16:22 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   D /branches/472/src/chrome/app/theme/omnibox_history_dark_transparent.png
   D /branches/472/src/chrome/app/theme/omnibox_history_transparent.png
   D /branches/472/src/chrome/app/theme/omnibox_http_dark_transparent.png
   D /branches/472/src/chrome/app/theme/omnibox_http_transparent.png
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/theme_resources.grd?r1=54661&r2=54660
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/gtk_theme_provider.cc?r1=54661&r2=54660

Merge 53733 - Remove IDR_OMNIBOX_*_TRANSPARENT images.  The comments for why we need them are out-of-date -- the normal images no longer have white backgrounds, and we don't need an extra "transparent" set.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3075001

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3052037
------------------------------------------------------------------------
Aug 2, 2010
#27 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54663 

------------------------------------------------------------------------
r54663 | pkasting@chromium.org | 2010-08-02 18:21:05 -0700 (Mon, 02 Aug 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/background_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/background_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/eula_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/eula_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/network_selection_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/network_selection_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/new_user_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/new_user_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/user_image_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/login/user_image_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/status/language_menu_button.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/status/language_menu_button.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/bookmark_bar_instructions_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/bookmark_bar_instructions_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/bookmark_bar_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/bookmark_bar_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/constrained_window_win.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/download_shelf_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/download_shelf_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/extensions/extension_shelf.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/extensions/extension_shelf.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/find_bar_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/find_bar_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/base_tab.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/base_tab.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/tab.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/tab.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/tab_strip.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/tab_strip.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/views/view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/views/view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/views/widget/root_view.cc?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/views/widget/root_view.h?r1=54663&r2=54662
   M http://src.chromium.org/viewvc/chrome/branches/472/src/views/window/non_client_view.cc?r1=54663&r2=54662

Merge 53736 - Make theme change notifications auto-propagate through the view hierarchy, instead of forcing subclasses to manually call their superclass implementation.  This fixes some problems where not all views would get notified of a theme change.

Make naming for theme and locale changes consistent and clear.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/2878055

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2878072
------------------------------------------------------------------------
Aug 2, 2010
#28 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54664 

------------------------------------------------------------------------
r54664 | pkasting@chromium.org | 2010-08-02 18:21:58 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.cc?r1=54664&r2=54663
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.h?r1=54664&r2=54663

Merge 53739 - Cleanup: Remove dead code (was only called when we had app + page menus).  Nicer indenting.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3073002

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3082015
------------------------------------------------------------------------
Aug 2, 2010
#29 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54665 

------------------------------------------------------------------------
r54665 | pkasting@chromium.org | 2010-08-02 18:22:54 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tab_icon_view.cc?r1=54665&r2=54664
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/base_tab.cc?r1=54665&r2=54664
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/base_tab.h?r1=54665&r2=54664
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/tabs/tab.cc?r1=54665&r2=54664

Merge 53740 - Make the throbber and tab close button correctly respond to theme changes.  This is partly using GetThemeProvider() instead of ResourceBundle::GetSharedInstance(), and partly not caching SkBitmaps (which we used to do long ago but stopped because it's pointless).

BUG=50107
TEST=Throbber responds to theme changes
Review URL: http://codereview.chromium.org/3064006

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3053037
------------------------------------------------------------------------
Aug 2, 2010
#30 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54666 

------------------------------------------------------------------------
r54666 | pkasting@chromium.org | 2010-08-02 18:23:44 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/back_forward_button_gtk.cc?r1=54666&r2=54665
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=54666&r2=54665
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/browser_toolbar_gtk.h?r1=54666&r2=54665
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/custom_button.cc?r1=54666&r2=54665
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/custom_button.h?r1=54666&r2=54665

Merge 53741 - Cleanup: Rename gtk button state names to (a) match other platforms and (b) not be misleading (e.g. "depressed" where it should be "disabled").  Better indenting.  Inline a function that has only one caller for simplicity.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3029032

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3076023
------------------------------------------------------------------------
Aug 2, 2010
#31 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54668 

------------------------------------------------------------------------
r54668 | pkasting@chromium.org | 2010-08-02 18:27:04 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/browser_actions_container.cc?r1=54668&r2=54667
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/browser_actions_container.h?r1=54668&r2=54667
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/browser_actions_container_browsertest.cc?r1=54668&r2=54667

Merge 53841 - Cleanup: Remove pointless GetInsets() override.  Simplify |container_size_| to just be |container_width_|.  Fix indenting/alignment, especially of function parameters.  L"" -> std::wstring().  Don't handle assertion violations (style guide/simplicity).  Reduce indenting via early-return or simpler-path-return.  Streamline code where possible.  Definition order should match declaration order.  EXPECT_STREQ -> EXPECT_EQ.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3076001

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3073018
------------------------------------------------------------------------
Aug 2, 2010
#32 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54669 

------------------------------------------------------------------------
r54669 | pkasting@chromium.org | 2010-08-02 18:27:37 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/wrench_menu.cc?r1=54669&r2=54668

Merge 53842 - Mirror wrench menu corner alignment in RTL mode.

BUG=50107
TEST=Run chrome --lang=he, click the wrench; the button and dropdown should align on the left edge, not the right.
Review URL: http://codereview.chromium.org/3017033

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3017051
------------------------------------------------------------------------
Aug 2, 2010
#33 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54670 

------------------------------------------------------------------------
r54670 | pkasting@chromium.org | 2010-08-02 18:28:48 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autofill/autofill_cc_infobar_win.cc?r1=54670&r2=54669
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/status/clock_menu_button.cc?r1=54670&r2=54669
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/status/language_menu_button.cc?r1=54670&r2=54669
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/chromeos/status/status_area_button.cc?r1=54670&r2=54669
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/extensions/browser_action_test_util_views.cc?r1=54670&r2=54669
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/wrench_menu.cc?r1=54670&r2=54669
   M http://src.chromium.org/viewvc/chrome/branches/472/src/views/controls/button/text_button.cc?r1=54670&r2=54669
   M http://src.chromium.org/viewvc/chrome/branches/472/src/views/controls/button/text_button.h?r1=54670&r2=54669

Merge 53847 - Add "pushed" as a state a TextButton can show (alongside "normal" and "hover").

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3058011

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3075017
------------------------------------------------------------------------
Aug 2, 2010
#35 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54672 

------------------------------------------------------------------------
r54672 | pkasting@chromium.org | 2010-08-02 18:32:54 -0700 (Mon, 02 Aug 2010) | 9 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_action.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_action_h.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_action_p.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_actions_overflow.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_actions_overflow_h.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_actions_overflow_p.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_actions_overflow_win.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_actions_overflow_win_h.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/browser_actions_overflow_win_p.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/keyword_search_magnifier.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/notification_wrench_p.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/star.pdf
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/star.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/star_lit.pdf
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/star_lit.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/tools_h.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/tools_p.png

Merge 53869 - Add new images for M6 theme changes.  This is done separately so that the code changes that use them can be run on the trybots.

TBR=ben
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3013037

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3018034
------------------------------------------------------------------------
Aug 2, 2010
#36 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54674 

------------------------------------------------------------------------
r54674 | pkasting@chromium.org | 2010-08-02 18:37:22 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   D /branches/472/src/chrome/app/theme/balloon_wrench.png
   D /branches/472/src/chrome/app/theme/balloon_wrench_hover.png
   D /branches/472/src/chrome/app/theme/blocked_javascript.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/blocked_script.png
   D /branches/472/src/chrome/app/theme/bubble_b_arrow.png
   D /branches/472/src/chrome/app/theme/bubble_l_arrow.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_pointer_b.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_pointer_l.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_pointer_r.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_pointer_t.png
   D /branches/472/src/chrome/app/theme/bubble_r_arrow.png
   D /branches/472/src/chrome/app/theme/bubble_t_arrow.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/ev_bubble_c.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/ev_bubble_l.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/ev_bubble_r.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/keyword_search_bubble_c.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/keyword_search_bubble_l.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/keyword_search_bubble_r.png
   D /branches/472/src/chrome/app/theme/location_bar_keyword_search_c.png
   D /branches/472/src/chrome/app/theme/location_bar_keyword_search_l.png
   D /branches/472/src/chrome/app/theme/location_bar_keyword_search_r.png
   D /branches/472/src/chrome/app/theme/locationbg_c.png
   D /branches/472/src/chrome/app/theme/locationbg_l.png
   D /branches/472/src/chrome/app/theme/locationbg_r.png
   D /branches/472/src/chrome/app/theme/locationbg_readonly_center.png
   D /branches/472/src/chrome/app/theme/locationbg_readonly_edge.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/notification_wrench.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/notification_wrench_h.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_c.png
   D /branches/472/src/chrome/app/theme/omnibox_ev_bubble_background_c.png
   D /branches/472/src/chrome/app/theme/omnibox_ev_bubble_background_l.png
   D /branches/472/src/chrome/app/theme/omnibox_ev_bubble_background_r.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_l.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_popup_c.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_popup_edge.png
   A http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_r.png
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/theme_resources.grd?r1=54674&r2=54673

Merge 53886 - Rename some resource files for clarity, or to fit better with upcoming theme resources.  Does not rename the identifiers yet, so as to minimize code change.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3035033

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3038044
------------------------------------------------------------------------
Aug 2, 2010
#37 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54675 

------------------------------------------------------------------------
r54675 | pkasting@chromium.org | 2010-08-02 18:38:01 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.cc?r1=54675&r2=54674
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.h?r1=54675&r2=54674

Merge 53887 - Swap reload and home back to how they were in Chrome <= 5.

BUG=50107
TEST=Reload should be left of home
Review URL: http://codereview.chromium.org/3056023

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3015047
------------------------------------------------------------------------
Aug 2, 2010
#38 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54676 

------------------------------------------------------------------------
r54676 | pkasting@chromium.org | 2010-08-02 18:38:52 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   D /branches/472/src/chrome/app/theme/back_mask.png
   D /branches/472/src/chrome/app/theme/button_mask.png
   D /branches/472/src/chrome/app/theme/forward_mask.png
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/theme_resources.grd?r1=54676&r2=54675
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.cc?r1=54676&r2=54675

Merge 53888 - Remove button masks for toolbar buttons, which will no longer be needed in the new theme.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3063011

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3066029
------------------------------------------------------------------------
Aug 2, 2010
#39 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54677 

------------------------------------------------------------------------
r54677 | pkasting@chromium.org | 2010-08-02 18:40:33 -0700 (Mon, 02 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/chromium_strings.grd?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/google_chrome_strings.grd?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/theme_resources.grd?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/browser_theme_pack.cc?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/browser_theme_provider.cc?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/selected_keyword_decoration.mm?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/cocoa/location_bar/star_decoration.mm?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/gtk/notifications/balloon_view_gtk.cc?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/location_bar/star_view.cc?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/notifications/balloon_view.cc?r1=54677&r2=54676
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/chrome_dll.gypi?r1=54677&r2=54676

Merge 53993 - Modified resources for M6 theme.  This doesn't actually modify layout yet, just images and identifier names.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3035034

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/2836083
------------------------------------------------------------------------
Aug 2, 2010
#40 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54679 

------------------------------------------------------------------------
r54679 | pkasting@chromium.org | 2010-08-02 18:45:55 -0700 (Mon, 02 Aug 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/back.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/back_d.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/back_h.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/back_p.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/blocked_cookies.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/blocked_images.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/blocked_plugins.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/blocked_popups.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/blocked_script.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_b.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_bl.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_br.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_l.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_pointer_b.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_pointer_l.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_pointer_r.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_pointer_t.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_r.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_t.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_tl.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/bubble_tr.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/content_top_center.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/content_top_left_corner.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/content_top_left_corner_mask.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/content_top_right_corner.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/content_top_right_corner_mask.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/ev_bubble_c.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/ev_bubble_l.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/ev_bubble_r.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/forward.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/forward_d.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/forward_h.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/forward_p.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/home.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/home_h.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/home_p.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/keyword_search_bubble_c.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/keyword_search_bubble_l.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/keyword_search_bubble_r.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/notification_wrench.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/notification_wrench_h.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_c.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_history.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_history_dark.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_history_selected.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_http.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_http_dark.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_http_selected.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_https_valid.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_https_warning.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_l.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_more.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_more_dark.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_more_selected.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_r.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_search.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_search_dark.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_search_selected.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_star.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_star_dark.png?r1=54679&r2=54678
   D /branches/472/src/chrome/app/theme/omnibox_star_lit.pdf
   D /branches/472/src/chrome/app/theme/omnibox_star_lit.png
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_star_selected.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/reload.png?r1=54679&r2=54678
   D /branches/472/src/chrome/app/theme/reload_d.png
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/reload_h.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/reload_p.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/stop.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/stop_h.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/stop_p.png?r1=54679&r2=54678
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/tools.png?r1=54679&r2=54678

Merge 54015 - Meant this to go in r53993... here are the actual new binaries for the theme images.

BUG=50107
TEST=none

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3032050
------------------------------------------------------------------------
Aug 2, 2010
#42 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54682 

------------------------------------------------------------------------
r54682 | pkasting@chromium.org | 2010-08-02 18:50:41 -0700 (Mon, 02 Aug 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.cc?r1=54682&r2=54681
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.h?r1=54682&r2=54681
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/wrench_menu.cc?r1=54682&r2=54681

Merge 54049 - Toolbar layout changes for M6 theme.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3033036

TBR=pkasting@chromium.org
------------------------------------------------------------------------
Aug 2, 2010
#43 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54683 

------------------------------------------------------------------------
r54683 | pkasting@chromium.org | 2010-08-02 18:51:28 -0700 (Mon, 02 Aug 2010) | 14 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/browser_actions_container.cc?r1=54683&r2=54682
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/browser_actions_container.h?r1=54683&r2=54682
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/browser/views/toolbar_view.cc?r1=54683&r2=54682

Merge 54174 - Browser actions container layout changes for M6 theme.

In short, this:
* Eliminates the divider on the right (the new chevron has a built-in divider)
* Changes the padding between items (see updated comments in header for precise layout details)
* Updates the imagery for the new theme
* Makes the chevron respond to theme changes

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3057016

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3015048
------------------------------------------------------------------------
Aug 2, 2010
#44 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54684 

------------------------------------------------------------------------
r54684 | pkasting@chromium.org | 2010-08-02 18:52:11 -0700 (Mon, 02 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached?r1=54684&r2=54683

Merge 54644 - Forgot to land this when I landed all the image resource changes.

TBR=erg
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3078018

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3018035
------------------------------------------------------------------------
Aug 3, 2010
#45 venkatar...@chromium.org 
Build: 6.0.472.21

Comments 2,9,14 have been verified.

PS: could not able to verify comment 16, as I don't notice any differences in UI.
Aug 6, 2010
#46 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=55255 

------------------------------------------------------------------------
r55255 | estade@chromium.org | 2010-08-06 10:47:19 -0700 (Fri, 06 Aug 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome/app/theme/omnibox_c.png?r1=55255&r2=55254

Merge 54145 - Update omnibox_c.png to remove garbage in middle.

TBR=estade
BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3056030

TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/3073034
------------------------------------------------------------------------
Aug 17, 2010
#47 pkasting@chromium.org 
This is done, any followup bugs can be separate
Status: Fixed
Oct 12, 2012
#48 bugdroid1@chromium.org 
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Blocking: -chromium:50575 chromium:50575
Mar 10, 2013
#49 bugdroid1@chromium.org 
(No comment was entered for this change.)
Labels: -Area-UI -Mstone-6 M-6 Cr-UI
Mar 13, 2013
#50 bugdroid1@chromium.org 
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
► Sign in to add a comment

Powered by Google Project Hosting