50k!

BTW, adding [animation_ orderOut:nil] in -animationComplete seems to do the trick.  -close is bad while the animation is running.  But cancelling the animation would be better.

Triage doesn't quite understand this bug but... all yours scott.

Bug is that when you close the window, the animation continues.  Without the underlying window.  So there's a thing animating along from nowhere to nowhere.

Animations that outlast their windows scare me, in that they are sometimes crashes waiting to happen.  Should we look harder at this for M6?

Thanks for the kick, Rohit.  I wanted to mention that I'm running on 10.5.

Also, the animation continues if I switch tabs (over the new tab).

The last part of my original comment was because for some reason the animation was feeling almost modal (like I couldn't do anything else while it was happening).  Today that isn't happening, so perhaps there was something up with my machine at the time.  Part of the CPU usage is because we schedule an animation for every popup, which is poor when the page tries to bring up a half-dozen popups.

(No comment was entered for this change.)

Robert,

I had been poking at this, but am going out-of-town, so can't really provide much color.  Anyhow, I had added this to animatable_image.mm:

- (void)cancelAnimation {
  NSView* view = [self contentView];
  CALayer* rootLayer = [view layer];
  for (CALayer* layer in [rootLayer sublayers]) {
    [layer removeAllAnimations];
  }
}

and called it as part of the cancel, to cancel the animation in addition to getting rid of the window.  I don't recall offhand if it was necessary-necessary, or just nice-to-have necessary.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=57996 

------------------------------------------------------------------------
r57996 | rsesek@chromium.org | 2010-08-31 08:24:17 -0700 (Tue, 31 Aug 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/animatable_image_unittest.mm?r1=57996&r2=57995
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/download_started_animation_mac.mm?r1=57996&r2=57995
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/popup_blocked_animation_mac.mm?r1=57996&r2=57995
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=57996&r2=57995

Change the conditions on which the popup blocked animation is shown to be more reliable.
This also prevents AnimatableImage from running after the window has been closed.

BUG=50000,50395
TEST=Get a blocked popup. Open it. Animation not shown.
TEST=Go to a page that creates a popup on document.unload. Close the tab. Animation not shown.

Review URL: http://codereview.chromium.org/3169030
------------------------------------------------------------------------

(No comment was entered for this change.)

Verified label updated by AutoAllocator, contact AmolK or KrisR for details

Verified in 7.0.513.0 (Official Build 58304) dev

This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

(No comment was entered for this change.)

(No comment was entered for this change.)