My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 48478: page_cycler_morejs failure on Vista Perf (dbg)
  Back to list
Status:  Fixed
Owner:  ana...@chromium.org
Closed:  Jul 2010
Cc:  bauerb@chromium.org, vandebo@chromium.org, thakis@chromium.org, tonyg@chromium.org, ana...@chromium.org, jam@chromium.org

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by cbentzel@chromium.org, Jul 7, 2010
This is failing due to a NOTREACHED() condition being triggered in CreateDummyWindowForActivation.

C:\b\slave\chromium-dbg-builder\build\src\chrome\test\ui\ui_test.cc(187): error: Value of: assertions.size()
  Actual: 8
Expected: expected_errors_
Which is: 0
The following error(s) occurred in the application during this test:

[3804:3500:433249546:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3752:3188:433263937:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3464:3444:433265156:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[2976:1764:433267437:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3920:3508:433282656:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3032:2348:433283703:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[940:2532:433285156:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3616:3172:433286843:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 
Jul 7, 2010
#1 cbentzel@chromium.org
Example run: http://build.chromium.org/buildbot/waterfall/builders/Vista%20Perf%20(dbg)/builds/25850/steps/page_cycler_morejs/logs/stdio

Unfortunately, there was no output for the test for a number of days, it only started emitting information this morning.

bauerb: I added you in case r51510 is a culprit.
thakis: I added you in case r51692 is a culprit
Cc: bau...@chromium.org vand...@chromium.org tha...@chromium.org to...@chromium.org
Jul 7, 2010
#2 thakis@chromium.org
How long was the test dead? Adding ananta for http://codereview.chromium.org/2752009 (june 15), http://codereview.chromium.org/2332004 (may 29)
Cc: ana...@chromium.org
Jul 7, 2010
#3 cbentzel@chromium.org
thakis: Test started emitting errors on July 7 at 07:35am. The test itself started failing on July 2 (when vandebo reported it).

Trying to figure out if I can see historical failures faster than clicking "next page" multiple times.
Jul 7, 2010
#4 vandebo@chromium.org
I tend to look at the build page (http://build.chromium.org/buildbot/waterfall/builders/Vista%20Perf%20(dbg)/builds/25850/) and binary search using the build number in the url.
Jul 7, 2010
#5 cbentzel@chromium.org
vandebo: Thanks for strategy.

http://build.chromium.org/buildbot/waterfall/builders/Vista%20Perf%20(dbg)/builds/27578/ is the first to show the problem (at ~11:00am July 2), but it may have happened earlier and be masked by the gclient issues which were introduced in 27539 (at 23:21 July 1)

 
Jul 7, 2010
#6 ana...@chromium.org
(No comment was entered for this change.)
Status: Assigned
Owner: ana...@chromium.org
Jul 7, 2010
#7 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=51831 

------------------------------------------------------------------------
r51831 | ananta@chromium.org | 2010-07-07 22:00:03 -0700 (Wed, 07 Jul 2010) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl_win.cc?r1=51831&r2=51830

Page cycler tests failed on Vista because our windowless plugin code fails to write the original flash windowless proc
in the window handle as a property via SetProp. Some debugging revealed that SetProp internally calls GlobalAddAtom which
fails at times with STATUS_NO_MEMORY. It appears that the flash plugin process runs out win32 heap quota at times.

To work around this we save away the original proc in a map.

This fixes bug https://code.google.com/p/chromium/issues/detail?id=48478

Bug=48478

Review URL: http://codereview.chromium.org/2897002
------------------------------------------------------------------------

Jul 8, 2010
#8 ana...@chromium.org
(No comment was entered for this change.)
Status: Fixed
Jul 8, 2010
#9 jam@chromium.org
I think this is still happening: 
http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests%20(dbg)(3)/builds/13315/steps/ui_tests/logs/DefaultPluginLoadTest

DefaultPluginUITest.DefaultPluginLoadTest: 
C:\b\slave\chromium-dbg-builder\build\src\chrome\test\ui\ui_test.cc(187): error: Value of: assertions.size()
  Actual: 1
Expected: expected_errors_
Which is: 0
The following error(s) occurred in the application during this test:

[2704:4756:2091056921:FATAL:webplugin_delegate_impl_win.cc(526)] Check failed: 0 != plugin_name_atom. 
C:\b\slave\chromium-dbg-builder\build\src\chrome\test\ui\ui_test.cc(206): error: Value of: actual_crashes
  Actual: 1
Expected: expected_crashes_
Which is: 0
Encountered an unexpected crash in the program during this test.



If the problem is with SetProp, it seems that all usage of it in that file should be fixed too?
Status: Assigned
Jul 8, 2010
#10 jam@chromium.org
(No comment was entered for this change.)
Cc: j...@chromium.org
Jul 12, 2010
#11 ana...@chromium.org
Problem has gone since the ui tests builder rebooted. Will keep a close look on whether this happens again.

Status: Fixed
Mar 18, 2011
#12 lafo...@chromium.org
This is failing due to a NOTREACHED() condition being triggered in CreateDummyWindowForActivation.

C:\b\slave\chromium-dbg-builder\build\src\chrome\test\ui\ui_test.cc(187): error: Value of: assertions.size()
  Actual: 8
Expected: expected_errors_
Which is: 0
The following error(s) occurred in the application during this test:

[3804:3500:433249546:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3752:3188:433263937:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3464:3444:433265156:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[2976:1764:433267437:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3920:3508:433282656:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3032:2348:433283703:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[940:2532:433285156:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false. 

[3616:3172:433286843:FATAL:webplugin_delegate_impl_win.cc(727)] Check failed: false.
Labels: -Area-BuildTools bulkmove Area-Build
Oct 12, 2012
#13 bugdroid1@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 9, 2013
#14 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-Build Build
Sign in to add a comment

Powered by Google Project Hosting