My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 48388: The default plug-in stopped working
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  bauerb@chromium.org
Closed:  Jul 2010
Cc:  jochen@chromium.org, jam@chromium.org, viettrun...@chromium.org, stuartmorgan@chromium.org, evan@chromium.org

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by thakis@chromium.org, Jul 6, 2010
What steps will reproduce the problem?
1. Go to e.g. http://www.adobe.com/shockwave/welcome/ (without having shockwave installed)

What is the expected output? What do you see instead?

The default plugin should get loaded. It doesn't.
Jul 6, 2010
#1 thakis@chromium.org
build/build-bisect.py says the regressing range is http://build.chromium.org/buildbot/perf/dashboard/ui/changelog.html?url=/trunk/src&range=51252:51258
Labels: Regression
Jul 6, 2010
#2 thakis@chromium.org
http://codereview.chromium.org/2858035 sounds like the most likely culprit.
Cc: bau...@chromium.org joc...@chromium.org
Jul 6, 2010
#3 thakis@chromium.org
(http://codereview.chromium.org/2858007 disabled the test that checks if the default plugin works :-/)

cc'd plugin folks: fyi.
Cc: j...@chromium.org viettrun...@chromium.org stuartmo...@chromium.org e...@chromium.org
Jul 6, 2010
#4 thakis@chromium.org
Regressions are p1. Assigning to bauerb for now, reassign to me if you can show that you CL is not the culprit :-)
Owner: bau...@chromium.org
Labels: -Pri-2 Pri-1
Jul 7, 2010
#6 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=51713 

------------------------------------------------------------------------
r51713 | bauerb@chromium.org | 2010-07-07 07:49:31 -0700 (Wed, 07 Jul 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/default_plugin_uitest.cc?r1=51713&r2=51712
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_list.cc?r1=51713&r2=51712

Fix a bug effectively disabling the default plugin.

Also, re-enable DefaultPluginUITest.DefaultPluginLoadTest.

BUG=48388,46662
TEST=DefaultPluginUITest.DefaultPluginLoadTest

Review URL: http://codereview.chromium.org/2854041
------------------------------------------------------------------------

Jul 7, 2010
#7 bauerb@chromium.org
(No comment was entered for this change.)
Status: Fixed
Cc: -bau...@chromium.org
Mar 18, 2011
#8 lafo...@chromium.org
<b>What steps will reproduce the problem?</b>
1. Go to e.g. http://www.adobe.com/shockwave/welcome/ (without having shockwave installed)

<b>What is the expected output? What do you see instead?</b>

The default plugin should get loaded. It doesn't.
Labels: -Regression bulkmove Type-Regression
Oct 12, 2012
#9 bugdroid1@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 9, 2013
#10 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-Internals -Type-Regression Cr-Internals Type-Bug-Regression
Sign in to add a comment

Powered by Google Project Hosting