| Issue 4714: | Browser crashes in FocusManager::OnNCDestroy in 154.23 | |
| 3 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Three similar reports in 154.23: http://go/crash/reportview? product=Chrome&version=0.4.154.23&signature=views::FocusManager::OnNCDestro y(HWND__+*)-A8C71A There are also a couple of reports in 154.22. One crashing stack: Thread 0 *CRASHED* (EXCEPTION_ACCESS_VIOLATION @0x028b8b70) 0x605bd96d [chrome.dll - focus_manager.cc:285] views::FocusManager::OnNCDestroy(HWND__ *) 0x605bd3b5 [chrome.dll - focus_manager.cc:162] views::FocusWindowCallback 0x75cbf8d1 [user32.dll + 0x0001f8d1] InternalCallWinProc 0x75cb1911 [user32.dll + 0x00011911] PostThreadMessageW 0x75cc0816 [user32.dll + 0x00020816] DispatchClientMessage 0x75cb148e [user32.dll + 0x0001148e] __fnNCDESTROY 0x773499cd [ntdll.dll + 0x000599cd] KiUserCallbackDispatcher 0x7734997f [ntdll.dll + 0x0005997f] KiUserApcDispatcher 0x77349b6a [ntdll.dll + 0x00059b6a] ExecuteHandler@20 0x772f9a46 [ntdll.dll + 0x00009a46] _EH4_GlobalUnwind 0x772f410d [ntdll.dll + 0x0000410d] LdrpGenericExceptionFilter 0x77349b98 [ntdll.dll + 0x00059b98] ExecuteHandler2@20 0x77349b6a [ntdll.dll + 0x00059b6a] ExecuteHandler@20 0x773499f6 [ntdll.dll + 0x000599f6] KiUserExceptionDispatcher 0x605bd96c [chrome.dll - focus_manager.cc:285] views::FocusManager::OnNCDestroy(HWND__ *) 0x605bd3b5 [chrome.dll - focus_manager.cc:162] views::FocusWindowCallback 0x75cbf8d1 [user32.dll + 0x0001f8d1] InternalCallWinProc 0x75cb1911 [user32.dll + 0x00011911] PostThreadMessageW 0x75cc0816 [user32.dll + 0x00020816] DispatchClientMessage 0x75cb148e [user32.dll + 0x0001148e] __fnNCDESTROY 0x773499cd [ntdll.dll + 0x000599cd] KiUserCallbackDispatcher 0x7734997f [ntdll.dll + 0x0005997f] KiUserApcDispatcher 0x604a1e4e [chrome.dll - download_item_view.cc:268] DownloadItemView::OnDownloadUpdated(DownloadItem *) 0x603099d6 [chrome.dll - download_manager.cc:175] DownloadItem::UpdateObservers() 0x6030c757 [chrome.dll - download_manager.cc:1233] DownloadManager::DangerousDownloadValidated(DownloadItem *) 0x604a2107 [chrome.dll - download_item_view.cc:335] DownloadItemView::ButtonPressed(views::NativeButton *) 0x605c3a56 [chrome.dll - native_button.cc:198] views::NativeButton::Clicked() 0x605c37b5 [chrome.dll - native_button.cc:111] views::NativeButton::OnCommand(unsigned int,int,HWND__ *) 0x605ccc6e [chrome.dll - native_control.cc:55] views::NativeControlContainer::ProcessWindowMessage(HWND__ *,unsigned int,unsigned int,long,long &,unsigned long) 0x60385acb [chrome.dll - atlwin.h:3073] ATL::CWindowImplBaseT<ATL::CWindow,ATL::CWinTraits<1073741824,0> >::WindowProc(HWND__ *,unsigned int,unsigned int,long) 0x75cbf8d1 [user32.dll + 0x0001f8d1] InternalCallWinProc 0x75cbf793 [user32.dll + 0x0001f793] UserCallWinProcCheckWow 0x75cc06f5 [user32.dll + 0x000206f5] CallWindowProcAorW 0x75cc069b [user32.dll + 0x0002069b] CallWindowProcW 0x605bd3a5 [chrome.dll - focus_manager.cc:187] views::FocusWindowCallback 0x75cbf8d1 [user32.dll + 0x0001f8d1] InternalCallWinProc 0x75cbf793 [user32.dll + 0x0001f793] UserCallWinProcCheckWow 0x75cc0a04 [user32.dll + 0x00020a04] SendMessageWorker 0x75cc0af9 [user32.dll + 0x00020af9] SendMessageW 0x74b1f94e [comctl32.dll + 0x0001f94e] Button_NotifyParent(tagBUTN *,unsigned int) 0x74b1f9b0 [comctl32.dll + 0x0001f9b0] Button_NotifyParent(tagBUTN *,unsigned int) 0x74b1fc96 [comctl32.dll + 0x0001fc96] AlterWindowStyle 0x75cbf8d1 [user32.dll + 0x0001f8d1] InternalCallWinProc 0x75cbf793 [user32.dll + 0x0001f793] UserCallWinProcCheckWow 0x75cc06f5 [user32.dll + 0x000206f5] CallWindowProcAorW 0x75cc069b [user32.dll + 0x0002069b] CallWindowProcW 0x605bd3a5 [chrome.dll - focus_manager.cc:187] views::FocusWindowCallback 0x75cbf8d1 [user32.dll + 0x0001f8d1] InternalCallWinProc 0x75cbf793 [user32.dll + 0x0001f793] UserCallWinProcCheckWow 0x75cc06f5 [user32.dll + 0x000206f5] CallWindowProcAorW 0x75cc069b [user32.dll + 0x0002069b] CallWindowProcW 0x605cd38e [chrome.dll - native_control.cc:364] views::NativeControl::NativeControlWndProc(HWND__ *,unsigned int,unsigned int,long) 0x75cbf8d1 [user32.dll + 0x0001f8d1] InternalCallWinProc 0x75cbf793 [user32.dll + 0x0001f793] UserCallWinProcCheckWow 0x75cc0007 [user32.dll + 0x00020007] DispatchMessageWorker 0x75cc005f [user32.dll + 0x0002005f] DispatchMessageW 0x605b52cf [chrome.dll - accelerator_handler.cc:29] views::AcceleratorHandler::Dispatch(tagMSG const &) 0x600b8859 [chrome.dll - message_pump_win.cc:248] base::MessagePumpWin::ProcessMessageHelper(tagMSG const &) 0x600b87f8 [chrome.dll - message_pump_win.cc:227] base::MessagePumpWin::ProcessNextWindowsMessage() 0x600b89fd [chrome.dll - message_pump_win.cc:356] base::MessagePumpForUI::DoRunLoop() 0x600b8546 [chrome.dll - message_pump_win.cc:95] base::MessagePumpWin::RunWithDispatcher(base::MessagePump::Delegate *,base::MessagePumpWin::Dispatcher *) 0x600abb81 [chrome.dll - message_loop.cc:187] MessageLoop::RunInternal() 0x600abafb [chrome.dll - message_loop.cc:175] MessageLoop::RunHandler() 0x600ac339 [chrome.dll - message_loop.cc:553] MessageLoopForUI::Run(base::MessagePumpWin::Dispatcher *) 0x6029ef01 [chrome.dll - browser_main.cc:564] BrowserMain(CommandLine &,int,sandbox::BrokerServices *) 0x600a3451 [chrome.dll - chrome_dll_main.cc:224] ChromeMain 0x00eb2b04 [chrome.exe - google_update_client.cc:93] google_update::GoogleUpdateClient::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *,wchar_t *,int,char const *,int *) 0x00eb2574 [chrome.exe - chrome_exe_main.cc:66] wWinMain |
||||||||||||||||||||||||||
,
Nov 24, 2008
After investigating, it seems we are crashing accessing the root_ member variable of the FocusManager. The pointer to the FocusManager seems OK, so I am assuming the object has been deleted already. We spent some time with Ananta looking at this and can't think of a case where that could possibly happen. The FocusManager gets deleted when the root window gets a WM_NCDESTROY. Before it deletes itself, it unsets the property on the window used to retrieve it. So once it is deleted, no code should be able to access the focus manager. |
|||||||||||||||||||||||||||
,
Nov 25, 2008
Issue 3895 has been merged into this issue.
Cc: jcam...@chromium.org b...@chromium.org
|
|||||||||||||||||||||||||||
,
Nov 25, 2008
I did some investigation on this and this can happen if we are calling DestroyWindow on a window being already destroyed in the destroy sequence. Check comments on the bug 3895 .
Cc: ana...@chromium.org
|
|||||||||||||||||||||||||||
,
Nov 26, 2008
In an attempt to mitigate potential crashers, I landed a change that makes sure the focus manager does not subclass a window more than once. Today the tab content's window is subclassed more than once, but it is OK as the second subclassing checks if the current WinProc is the same as the new one and does nothing if that's the case. However one could imagine a third-party application (anti-virus, assistive software...) subclassing the window after the focus manager. At that point subsequent subclassing by the focus manager would succeed, causing the stack of WinProc for the window to contain the focus manager's WinProc twice. Looking at the mini-dumps though, I only saw in once a suspicious loaded DLL (AhJsctNs.dll of Avast Antivirus) so I don't think it is going to help with this crasher. Furthermore, if the double subclassing was the problem, one would expect a stack trace like: FocusManager::WinProc ThirdPartyApp:WinProc FocusManager::WinProc ... which is not what we are seeing. |
|||||||||||||||||||||||||||
,
Dec 01, 2008
Fixed on the release branch with r6027. This will be in 154.30 or later.
Status: Fixed
|
|||||||||||||||||||||||||||
,
Dec 02, 2008
Issue 4832 has been merged into this issue. |
|||||||||||||||||||||||||||
,
Dec 02, 2008
Two variants in 0.4.154.29 (added for tracking purposes) The full crash report details can be found at: http://go/crash/reportdetail?reportid=3064910f32f4abed&product=Chrome&version=0.4.154.29&signature=views%3A%3AFocusManager%3A%3AOnNCDestroy(HWND__+*)-A776B8 Meta information: Report ID: 3064910f32f4abed Report Time: 2008/12/02 01:39:32, Tue Uptime: 5 sec Cumulative Uptime: 0 sec User Email: User Comments: Product Name: Chrome Product Version: 0.4.154.29 OS Name: Windows NT OS Version: 5.1.2600 Service Pack 3 CPU Architecture: x86 CPU Info: GenuineIntel family 15 model 1 stepping 2 plat: Win32 ptype: browser Stack Trace: Thread 0 *CRASHED* 0x0170d457 [chrome.dll] - focus_manager.cc:285 views::FocusManager::OnNCDestroy(HWND__ *) 0x0170ce9f [chrome.dll] - focus_manager.cc:162 views::FocusWindowCallback 0x7e418733 [user32.dll] +0x00008733 InternalCallWinProc 0x7e42bdf0 [user32.dll] +0x0001bdf0 __fnINOUTLPSCROLLINFO 0x7e428e9f [user32.dll] +0x00018e9f DispatchClientMessage 0x7e42b16e [user32.dll] +0x0001b16e __fnNCDESTROY 0x7c90e452 [ntdll.dll] +0x0000e452 KiUserCallbackDispatcher 0x0170cd7a [chrome.dll] - focus_manager.cc:119 views::RerouteMouseWheel 0x015e9c4a [chrome.dll] +0x003f9c4a InfoBarView::`scalar deleting destructor'(unsigned int) 0x014dd4fe [chrome.dll] - dom_ui_host.cc:30 DOMUIHost::~DOMUIHost() The full crash report details can be found at: http://go/crash/reportdetail?reportid=db048b8ef0cb1c97&product=Chrome&version=0.4.154.29&signature=views%3A%3AFocusManager%3A%3AOnNCDestroy(HWND__+*)-A8BCEE Meta information: Report ID: db048b8ef0cb1c97 Report Time: 2008/12/02 00:28:31, Tue Uptime: 5 sec Cumulative Uptime: 0 sec User Email: User Comments: Product Name: Chrome Product Version: 0.4.154.29 OS Name: Windows NT OS Version: 6.0.6001 Service Pack 1 CPU Architecture: x86 CPU Info: AuthenticAMD family 15 model 67 stepping 3 plat: Win32 ptype: browser Stack Trace: Thread 0 *CRASHED* 0x6834d457 [chrome.dll] - focus_manager.cc:285 views::FocusManager::OnNCDestroy(HWND__ *) 0x6834ce9f [chrome.dll] - focus_manager.cc:162 views::FocusWindowCallback 0x773bf8d1 [user32.dll] +0x0001f8d1 InternalCallWinProc 0x773b1911 [user32.dll] +0x00011911 PostThreadMessageW 0x773c0816 [user32.dll] +0x00020816 DispatchClientMessage 0x773b148e [user32.dll] +0x0001148e __fnNCDESTROY 0x775a99cd [ntdll.dll] +0x000599cd KiUserCallbackDispatcher 0x775a997f [ntdll.dll] +0x0005997f KiUserApcDispatcher 0x775a9b6a [ntdll.dll] +0x00059b6a ExecuteHandler@20 0x77559a46 [ntdll.dll] +0x00009a46 _EH4_GlobalUnwind 0x7755410d [ntdll.dll] +0x0000410d LdrpGenericExceptionFilter 0x775a9b98 [ntdll.dll] +0x00059b98 ExecuteHandler2@20 0x775a9b6a [ntdll.dll] +0x00059b6a ExecuteHandler@20 0x775a99f6 [ntdll.dll] +0x000599f6 KiUserExceptionDispatcher 0x6834d456 [chrome.dll] - focus_manager.cc:285 views::FocusManager::OnNCDestroy(HWND__ *) 0x6834ce9f [chrome.dll] - focus_manager.cc:162 views::FocusWindowCallback 0x773bf8d1 [user32.dll] +0x0001f8d1 InternalCallWinProc 0x773b1911 [user32.dll] +0x00011911 PostThreadMessageW 0x773c0816 [user32.dll] +0x00020816 DispatchClientMessage 0x773b148e [user32.dll] +0x0001148e __fnNCDESTROY 0x775a99cd [ntdll.dll] +0x000599cd KiUserCallbackDispatcher 0x775a997f [ntdll.dll] +0x0005997f KiUserApcDispatcher 0x6834752b [chrome.dll] - view.cc:715 views::View::ViewHierarchyChangedImpl(bool,bool,views::View *,views::View *) 0x683473ea [chrome.dll] - view.cc:665 views::View::PropagateRemoveNotifications(views::View *) 0x6834734c [chrome.dll] - view.cc:641 views::View::DoRemoveChildView(views::View *,bool,bool,bool) 0x683471e9 [chrome.dll] - view.cc:603 views::View::RemoveChildView(views::View *) 0x6822a18a [chrome.dll] - info_bar_view.cc:216 InfoBarView::Observe(NotificationType,NotificationSource const &,NotificationDetails const &) 0x67fbed75 [chrome.dll] - notification_service.cc:99 NotificationService::Notify(NotificationType,NotificationSource const &,NotificationDetails const &) 0x680b2b7c [chrome.dll] - navigation_controller.cc:1036 NavigationController::NotifyNavigationEntryCommitted(NavigationController::LoadCommittedDetails *) 0x680b1c01 [chrome.dll] - navigation_controller.cc:570 NavigationController::RendererDidNavigate(ViewHostMsg_FrameNavigate_Params const &,bool,NavigationController::LoadCommittedDetails *) 0x68090776 [chrome.dll] - web_contents.cc:938 WebContents::DidNavigate(RenderViewHost *,ViewHostMsg_FrameNavigate_Params const &) 0x680b6b6c [chrome.dll] - render_view_host.cc:813 RenderViewHost::OnMsgNavigate(IPC::Message const &) 0x680b6483 [chrome.dll] - render_view_host.cc:622 RenderViewHost::OnMessageReceived(IPC::Message const &) 0x6802bc86 [chrome.dll] - render_process_host.cc:598 RenderProcessHost::OnMessageReceived(IPC::Message const &) 0x680ee998 [chrome.dll] - task.h:312 RunnableMethod<history::HistoryBackend,void ( history::HistoryBackend::*)(std::vector<history::ImportedFavIconUsage,std::allocator<history::ImportedFavIconUsage> > const &),Tuple1<std::vector<history::ImportedFavIconUsage,std::allocator<history::ImportedFavIconUsage> > > >::Run() 0x67e3bfff [chrome.dll] - message_loop.cc:303 MessageLoop::RunTask(Task *) 0x67e3c03b [chrome.dll] - message_loop.cc:311 MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const &) 0x67e3c230 [chrome.dll] - message_loop.cc:403 MessageLoop::DoWork() 0x67e48ea2 [chrome.dll] - message_pump_win.cc:331 base::MessagePumpForUI::DoRunLoop() 0x67e48a43 [chrome.dll] - message_pump_win.cc:95 base::MessagePumpWin::RunWithDispatcher(base::MessagePump::Delegate *,base::MessagePumpWin::Dispatcher *) 0x67e3bd34 [chrome.dll] - message_loop.cc:187 MessageLoop::RunInternal() 0x67e3bcae [chrome.dll] - message_loop.cc:175 MessageLoop::RunHandler() 0x67e3c4ec [chrome.dll] - message_loop.cc:553 MessageLoopForUI::Run(base::MessagePumpWin::Dispatcher *) 0x6802f106 [chrome.dll] - browser_main.cc:559 BrowserMain(CommandLine &,int,sandbox::BrokerServices *) 0x67e33463 [chrome.dll] - chrome_dll_main.cc:224 ChromeMain 0x009f2ab9 [chrome.exe] - google_update_client.cc:93 google_update::GoogleUpdateClient::Launch(HINSTANCE__ *,sandbox::SandboxInterfaceInfo *,wchar_t *,int,char const *,int *) 0x009f2529 [chrome.exe] - chrome_exe_main.cc:66 wWinMain
Labels: Crash-0.4.154.29
|
|||||||||||||||||||||||||||
,
Dec 02, 2008
Three more variants in 0.4.154.29 (adding these client count of these crashers together puts this in the top 3 issues (excluding empty)). The full crash report details can be found at: http://go/crash/reportdetail?reportid=6861cabab3826f2b&product=Chrome&version=0.4.154.29&signature=views%3A%3AFocusManager%3A%3AOnNCDestroy(HWND__+*)-A640DD The full crash report details can be found at: http://go/crash/reportdetail?reportid=98a6e989a5cca745&product=Chrome&version=0.4.154.29&signature=views%3A%3AFocusManager%3A%3AOnNCDestroy(HWND__+*)-A5AFFB The full crash report details can be found at: http://go/crash/reportdetail?reportid=6979d9344add0694&product=Chrome&version=0.4.154.29&signature=views%3A%3AFocusManager%3A%3AOnNCDestroy(HWND__+*)-A5AF42 |
|||||||||||||||||||||||||||
,
Dec 08, 2008
Looks like we might be seeing this same issue again. I'm slipping this to 1.1 since my guess is that a CL will not make it into this release, given the current # of crashers we are seeing for this issue. http://go/crash/reportdetail? reportid=998b80d932a6b22e&product=Chrome&version=0.4.154.31&signature=views%3A%3AFocu sManager%3A%3AOnNCDestroy(HWND__+*)-A75FB7
Status: Assigned
Labels: -Mstone-1.0 Mstone-1.1 Crash-0.4.154.31 |
|||||||||||||||||||||||||||
,
Dec 17, 2008
Issue 5163 has been merged into this issue. |
|||||||||||||||||||||||||||
,
Dec 17, 2008
Looks like this crashers has a pretty storied history. +-----+---------------------------------------------------+-----------------+ | cnt | StackSignature | Product.Version | +-----+---------------------------------------------------+-----------------+ | 79 | views::FocusManager::OnNCDestroy(HWND__ *)-A75A4D | 1.0.154.36 | | 27 | views::FocusManager::OnNCDestroy(HWND__ *)-A8A083 | 1.0.154.36 | | 16 | views::FocusManager::OnNCDestroy(HWND__ *)-A62472 | 1.0.154.36 | | 12 | views::FocusManager::OnNCDestroy(HWND__ *)-A5929F | 1.0.154.36 | | 6 | views::FocusManager::OnNCDestroy(HWND__ *)-A592D7 | 1.0.154.36 | | 6 | views::FocusManager::OnNCDestroy(HWND__ *)-A59390 | 1.0.154.36 | | 3 | views::FocusManager::OnNCDestroy(HWND__ *)-A548E4 | 1.0.154.36 | | 3 | views::FocusManager::OnNCDestroy(HWND__ *)-A59307 | 1.0.154.36 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A9EDBE | 1.0.154.36 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A7FB3F | 1.0.154.36 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A90CAA | 1.0.154.36 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A54A62 | 1.0.154.36 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A97F05 | 1.0.154.36 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A54A92 | 1.0.154.36 | | 21 | views::FocusManager::OnNCDestroy(HWND__ *)-A7854F | 0.4.154.33 | | 6 | views::FocusManager::OnNCDestroy(HWND__ *)-A8CB85 | 0.4.154.33 | | 4 | views::FocusManager::OnNCDestroy(HWND__ *)-AA18C0 | 0.4.154.33 | | 3 | views::FocusManager::OnNCDestroy(HWND__ *)-A64F74 | 0.4.154.33 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A5BDD9 | 0.4.154.33 | | 23 | views::FocusManager::OnNCDestroy(HWND__ *)-A75FB7 | 0.4.154.31 | | 13 | views::FocusManager::OnNCDestroy(HWND__ *)-A629DC | 0.4.154.31 | | 12 | views::FocusManager::OnNCDestroy(HWND__ *)-A8A5ED | 0.4.154.31 | | 4 | views::FocusManager::OnNCDestroy(HWND__ *)-A5502C | 0.4.154.31 | | 370 | views::FocusManager::OnNCDestroy(HWND__ *)-A776B8 | 0.4.154.29 | | 149 | views::FocusManager::OnNCDestroy(HWND__ *)-A8BCEE | 0.4.154.29 | | 62 | views::FocusManager::OnNCDestroy(HWND__ *)-A640DD | 0.4.154.29 | | 58 | views::FocusManager::OnNCDestroy(HWND__ *)-A5AFFB | 0.4.154.29 | | 56 | views::FocusManager::OnNCDestroy(HWND__ *)-A5AF42 | 0.4.154.29 | | 42 | views::FocusManager::OnNCDestroy(HWND__ *)-A5AF0A | 0.4.154.29 | | 32 | views::FocusManager::OnNCDestroy(HWND__ *)-AA0A29 | 0.4.154.29 | | 20 | views::FocusManager::OnNCDestroy(HWND__ *)-A566FD | 0.4.154.29 | | 18 | views::FocusManager::OnNCDestroy(HWND__ *)-A5AF72 | 0.4.154.29 | | 13 | views::FocusManager::OnNCDestroy(HWND__ *)-A5B878 | 0.4.154.29 | | 9 | views::FocusManager::OnNCDestroy(HWND__ *)-A566CD | 0.4.154.29 | | 9 | views::FocusManager::OnNCDestroy(HWND__ *)-A99B70 | 0.4.154.29 | | 9 | views::FocusManager::OnNCDestroy(HWND__ *)-A5654F | 0.4.154.29 | | 6 | views::FocusManager::OnNCDestroy(HWND__ *)-A817AA | 0.4.154.29 | | 4 | views::FocusManager::OnNCDestroy(HWND__ *)-A3FF9C | 0.4.154.29 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A808C6 | 0.4.154.29 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A87754 | 0.4.154.29 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A81802 | 0.4.154.29 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A5672D | 0.4.154.29 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A92915 | 0.4.154.29 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A8DB02 | 0.4.154.29 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A554A4 | 0.4.154.29 | | 216 | views::FocusManager::OnNCDestroy(HWND__ *)-A71BA4 | 0.4.154.25 | | 66 | views::FocusManager::OnNCDestroy(HWND__ *)-A861DA | 0.4.154.25 | | 40 | views::FocusManager::OnNCDestroy(HWND__ *)-A5E5C9 | 0.4.154.25 | | 33 | views::FocusManager::OnNCDestroy(HWND__ *)-A5542E | 0.4.154.25 | | 20 | views::FocusManager::OnNCDestroy(HWND__ *)-A553F6 | 0.4.154.25 | | 15 | views::FocusManager::OnNCDestroy(HWND__ *)-A554E7 | 0.4.154.25 | | 10 | views::FocusManager::OnNCDestroy(HWND__ *)-A9405C | 0.4.154.25 | | 10 | views::FocusManager::OnNCDestroy(HWND__ *)-A9AF15 | 0.4.154.25 | | 5 | views::FocusManager::OnNCDestroy(HWND__ *)-A55D64 | 0.4.154.25 | | 5 | views::FocusManager::OnNCDestroy(HWND__ *)-A50BE9 | 0.4.154.25 | | 5 | views::FocusManager::OnNCDestroy(HWND__ *)-A50A3B | 0.4.154.25 | | 4 | views::FocusManager::OnNCDestroy(HWND__ *)-A5545E | 0.4.154.25 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A7AE0A | 0.4.154.25 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A50BB9 | 0.4.154.25 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A81C40 | 0.4.154.25 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A7BC96 | 0.4.154.25 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A7ADB2 | 0.4.154.25 | | 4 | views::FocusManager::OnNCDestroy(HWND__ *)-A780E4 | 0.4.154.23 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A57129 | 0.4.154.23 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A8C71A | 0.4.154.23 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A64B09 | 0.4.154.23 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A5B96E | 0.4.154.23 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A8C332 | 0.4.154.22 | | 2 | views::FocusManager::OnNCDestroy(HWND__ *)-A64721 | 0.4.154.22 | | 1 | views::FocusManager::OnNCDestroy(HWND__ *)-A5B586 | 0.4.154.22 | +-----+---------------------------------------------------+-----------------+ |
|||||||||||||||||||||||||||
,
Dec 18, 2008
(No comment was entered for this change.)
Labels: stable
|
|||||||||||||||||||||||||||
,
Dec 19, 2008
Moving all label:stable bugs to mstone:1.1 |
|||||||||||||||||||||||||||
,
Dec 23, 2008
Similar crash in 1.0.154.42 0012ea18 017fe50c 00000000 0012ea4c 0012ea30 ntdll!KiUserExceptionDispatcher+0xe (FPO: [2,0,0]) (CONTEXT @ 0012ea4c) 0012edb0 017fde70 01fa8680 002b081a 00000000 chrome_12e0000!views::FocusManager::OnNCDestroy+0x1d (CONV: thiscall) [c:\b\slave\chrome-official\build\src\chrome\views\focus_manager.cc @ 309] 0012ee60 7e418734 002b081a 00000082 00000000 chrome_12e0000!views::FocusWindowCallback+0x125 (CONV: stdcall) [c:\b\slave\chrome-official\build\src\chrome\views\focus_manager.cc @ 174] 0012ee8c 7e42bdf1 017fdd4b 002b081a 00000082 user32!InternalCallWinProc+0x28 0012eef4 7e428ea0 00000000 017fdd4b 002b081a user32!UserCallWinProcCheckWow+0xea (FPO: [Non-Fpo]) 0012ef48 7e42b16f 0078de38 00000082 00000000 user32!DispatchClientMessage+0xa3 (FPO: [Non-Fpo]) 0012ef78 7c90e453 0012ef88 00000018 0078de38 user32!__fnNCDESTROY+0x26 (FPO: [Non-Fpo]) 0012ef9c 7e42b1a8 018101c9 000b08b2 00000001 ntdll!KiUserCallbackDispatcher+0x13 (FPO: [0,0,0]) 0012f02c 017f980e 00000000 00cfe610 00cfd700 user32!NtUserDestroyWindow+0xc 0012f048 017f96cd 00000001 00000000 00cfe610 chrome_12e0000!views::View::ViewHierarchyChangedImpl+0x37 (CONV: thiscall) [c:\b\slave\chrome-official\build\src\chrome\views\view.cc @ 716] 0012f06c 017f962f 00cfe610 029e4c08 00cfd700 chrome_12e0000!views::View::PropagateRemoveNotifications+0x43 (FPO: [1,1,3]) (CONV: thiscall) [c:\b\slave\chrome-official\build\src\chrome\views\view.cc @ 665] 0012f128 017f94cc 00cfe610 00cfd700 00000001 chrome_12e0000!views::View::DoRemoveChildView+0xf1 (CONV: thiscall) [c:\b\slave\chrome-official\build\src\chrome\views\view.cc @ 642] 0012f140 016e1c35 00cfe610 00cfd700 0012f040 chrome_12e0000!views::View::RemoveChildView+0x13 (FPO: [2,0,0]) (CONV: thiscall) [c:\b\slave\chrome-official\build\src\chrome\views\view.cc @ 604] 0012f150 016e1eea 00cf8150 017efa0c 00cf8150 chrome_12e0000!InfoBarItemView::Close+0xa (FPO: [0,1,0]) (CONV: thiscall) [c:\b\slave\chrome-official\build\src\chrome\browser\views\info_bar_item_view.cc @ 148] 0012f158 017efa0c 00cf8150 017efab6 029e4c08 chrome_12e0000!InfoBarItemView::AnimationEnded+0x22 (FPO: [1,0,0]) (CONV: thiscall) [c:\b\slave\chrome-official\build\src\chrome\browser\views\info_bar_item_view.cc @ 269] 0012f160 017efab6 029e4c08 00000006 0012f21c chrome_12e0000!Animation::Stop+0x2b (FPO: [0,0,0]) (CONV: thiscall) [c:\b\slave\chrome-official\build\src\chrome\common\animation.cc @ 70] 0012f170 01548d3e 0012f4c0 012ec154 0012f4dc chrome_12e0000!Animation::Step+0x5a (CONV: thiscall) [c:\b\slave\chrome-official\build\src\chrome\common\animation.cc @ 110] 0012f178 012ec154 0012f4dc 0012f4dc 00000006 chrome_12e0000!base::BaseTimer<DownloadItem,1>::TimerTask::Run+0x16 (FPO: [0,0,0]) (CONV: thiscall) [c:\b\slave\chrome-official\build\src\base\timer.h @ 147] 0012f21c 012ec190 029e4c08 0012f4dc 012ec44b chrome_12e0000!MessageLoop::RunTask+0x7c (CONV: thiscall) [c:\b\slave\chrome-official\build\src\base\message_loop.cc @ 304] See bug #1558054 |
|||||||||||||||||||||||||||
,
Jan 12, 2009
(No comment was entered for this change.)
Labels: Mstone-2.0
|
|||||||||||||||||||||||||||
,
Jan 23, 2009
This crash appears to be alive and well on the trunk. See http://crash/search? query=Chrome+FocusManager::OnNCDestroy |
|||||||||||||||||||||||||||
,
Jan 26, 2009
Hey Jay, Just looking at this crasher on the Dev channel for 157.2 and 158.0. In 157.2 there are 123 reports (spread across different traces), out of the 11,666 that represents 1.0% of the crashes. This would put it in the top 10 issues there. http://crash/search?query=Chrome+2.0.157.2+views::FocusManager::OnNCDestroy(HWND__+*) In 158.0 there are 52 reports, out of 3610 that represents 1.5% of the crashers which puts it in the top 5. http://crash/search?query=Chrome+2.0.158.0+views::FocusManager::OnNCDestroy(HWND__+*) |
|||||||||||||||||||||||||||
,
Feb 03, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=9109
------------------------------------------------------------------------
r9109 | jcampan@chromium.org | 2009-02-03 15:20:59 -0800 (Tue, 03 Feb 2009) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/win_util.cc?r1=9109&r2=9108
M http://src.chromium.org/viewvc/chrome/trunk/src/base/win_util.h?r1=9109&r2=9108
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.cc?r1=9109&r2=9108
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc?r1=9109&r2=9108
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/native_control.cc?r1=9109&r2=9108
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/text_field.cc?r1=9109&r2=9108
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/widget_win.cc?r1=9109&r2=9108
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc?r1=9109&r2=9108
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/webwidget_host_win.cc?r1=9109&r2=9108
This CL adds macro used to track the creation and destruction
of HWNDs, in an attempt to detect potential double-delete.
A double-delete of a HWND might be responsible for the crasher
http://crbug.com/4714
Review URL: http://codereview.chromium.org/21018
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Feb 07, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=9161
------------------------------------------------------------------------
r9161 | jcampan@chromium.org | 2009-02-04 11:38:30 -0800 (Wed, 04 Feb 2009) | 7 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/stats_table.cc?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/base/time.cc?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/base/win_util.cc?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/base/win_util.h?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.cc?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/native_control.cc?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/text_field.cc?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/widget_win.cc?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc?r1=9161&r2=9160
M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/webwidget_host_win.cc?r1=9161&r2=9160
This CL adds macro used to track the creation and destruction
of HWNDs, in an attempt to detect potential double-delete.
A double-delete of a HWND might be responsible for the crasher
http://crbug.com/4714
Note: this CL was previously committed and reverted because it broke the sandbox integration module.
Review URL: http://codereview.chromium.org/21032
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Feb 10, 2009
Did you want to mark this as Fixed? |
|||||||||||||||||||||||||||
,
Feb 12, 2009
No, this is not fixed. The CL I landed is just a way to track double delete of HWNDs, which we think could cause that mysterious crasher. |
|||||||||||||||||||||||||||
,
Feb 25, 2009
Issue 7906 has been merged into this issue.
Cc: all-bugs...@chromium.org
|
|||||||||||||||||||||||||||
,
Feb 25, 2009
(No comment was entered for this change.)
Labels: -Mstone-2.0 Mstone-2.1
|
|||||||||||||||||||||||||||
,
Mar 26, 2009
We have not seen this crash in 169.1, 170, or 171. I propose that we close this as WONTFIX. Unless someone disagrees I will do that on April 1st.
Labels: Close20090401
|
|||||||||||||||||||||||||||
,
Apr 03, 2009
I believe this bug is now obsolete.
Status: WontFix
Labels: -Close20090401 |
|||||||||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||||||||