Issue 47074 - chromium - IE menu item "Page Setup", "Print", "Print Preview" are ALWAYS disabled - An open-source project to help move the web forward.

Issue 47074:	IE menu item "Page Setup", "Print", "Print Preview" are ALWAYS disabled
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	tommi@chromium.org
Closed:	Jul 2010
Type-Bug OS-Windows Pri-2 bulkmove Cr-ChromeFrame

Restricted

Only users with Commit permission may comment.

Reported by DanFabul...@gmail.com, Jun 21, 2010

ChromeFrame version: 5.0.375.62 (Official Build 48223) unknown
IE version: 6.0.2900.5512.xpsp_sp3_gdr.100216-1514

Related URL(s): http://sandbox.redfin.com/test.html

Steps to reproduce the issue:
0. Install Google Chrome Frame Beta.
1. Navigate to that test page (the page is also attached to this bug)
2. Click File menu.

Actual: The menu item "Page Setup", "Print" and "Print Preview" are disabled(grey and not clickable).

Expected: They should be enabled.  For pages rendered by IE itself,those menu items work fine.

Note that this bug is a bigger version of  issue #24034 .  That bug reports that the Print menu is disabled only when you use "gcf:" mode, but I'm reporting that the problem ALWAYS happens, even if you don't use "gcf:" mode.

test.html
151 bytes View Download

Jun 21, 2010

#1 DanFabul...@gmail.com

I note with some dismay that the documentation claims that the Print menu never works: http://www.chromium.org/developers/how-tos/chrome-frame-getting-started

Known Issues: Printing is not yet implemented. Using the right-click menu to print or pressing "Ctrl-p" from inside a page will open the Chrome printing dialog which functions correctly, however the main menu items for printing are not yet enabled.

Jun 21, 2010

#2 DanFabul...@gmail.com

I tried upgrading to the latest devchannel build; the Print menu is disabled there, too, ChromeFrame version: 6.0.437.3 (Official Build 50164) unknown

Jun 21, 2010

#3 DanFabul...@gmail.com

Alex Russell said at Google IO that this was supposed to work in the Beta: http://www.youtube.com/watch?v=Sfe2l8QKxPg#t=39m16s  Was he mistaken?

Jul 1, 2010

#4 DanFabul...@gmail.com

Alex clarified here that he was incorrect; this doesn't work in the beta.  http://groups.google.com/group/google-chrome-frame/browse_thread/thread/88c08923f76db620

Jul 6, 2010

#5 tommi@chromium.org

(No comment was entered for this change.)

Status: Assigned
Owner: slightly...@chromium.org

Jul 26, 2010

#6 tommi@chromium.org

(No comment was entered for this change.)

Owner: to...@chromium.org

Jul 27, 2010

#7 bugdroid1@gmail.com

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53786 

------------------------------------------------------------------------
r53786 | tommi@chromium.org | 2010-07-27 07:35:44 -0700 (Tue, 27 Jul 2010) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/ole_document_impl.h?r1=53786&r2=53785

Our InPlaceMenu implementation is only partially being used.
We had a leftover call to InPlaceMenuDestroy without creating a menu in the first place.
This caused us to delete IE's menu and fail the first check inside ieframe!CDocObjectHost::OnInitMenuPopup.
It took a while to figure this out and even longer to figure out why our menu was NULL in this case and not mshtml's.

I don't think that there are any bad side effects with this change but I ask the reviewer to check.

The visible change is that the Print menu item will become enabled and visible whereas Page Setup will be disabled and Print Preview will (correctly atm) not be visible for GCF documents.

BUG=24034, 47074
TEST=See description above and bug report.

Review URL: http://codereview.chromium.org/3034033
------------------------------------------------------------------------

Jul 27, 2010

#8 tommi@chromium.org

(No comment was entered for this change.)

Status: Fixed

Jul 29, 2010

#9 bugdroid1@gmail.com

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=54063 

------------------------------------------------------------------------
r54063 | ananta@chromium.org | 2010-07-28 16:04:09 -0700 (Wed, 28 Jul 2010) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/472/src/chrome_frame/ole_document_impl.h?r1=54063&r2=54062

Merge 53786 - Our InPlaceMenu implementation is only partially being used.
We had a leftover call to InPlaceMenuDestroy without creating a menu in the first place.
This caused us to delete IE's menu and fail the first check inside ieframe!CDocObjectHost::OnInitMenuPopup.
It took a while to figure this out and even longer to figure out why our menu was NULL in this case and not mshtml's.

I don't think that there are any bad side effects with this change but I ask the reviewer to check.

The visible change is that the Print menu item will become enabled and visible whereas Page Setup will be disabled and Print Preview will (correctly atm) not be visible for GCF documents.

BUG=24034, 47074
TEST=See description above and bug report.

Review URL: http://codereview.chromium.org/3034033

TBR=tommi@chromium.org
Review URL: http://codereview.chromium.org/2836074
------------------------------------------------------------------------

Mar 29, 2011

#10 lafo...@chromium.org

(No comment was entered for this change.)

Labels: -Area-ChromeFrame bulkmove Feature-ChromeFrame

Oct 12, 2012

#11 bugdroid1@chromium.org

This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.

Labels: Restrict-AddIssueComment-Commit

Mar 10, 2013

#12 bugdroid1@chromium.org

(No comment was entered for this change.)

Labels: -Feature-ChromeFrame Cr-ChromeFrame

► Sign in to add a comment