My favorites ▼ | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 46666: Tear off the dependency between 'browser' and 'renderer'
7 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Apr 2013
Cc:  thestig@chromium.org, maruel@chromium.org, jam@chromium.org, tfar...@chromium.org

Blocked on:
issue 21796

Blocking:
issue 4301


Sign in to add a comment
 
Project Member Reported by maruel@chromium.org, Jun 16, 2010 
This is necessary to reduce the dependency bloat the test projects have.
Jun 16, 2010
#1 maruel@chromium.org 
(No comment was entered for this change.)
Labels: Mstone-X
Jun 17, 2010
#2 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=50081 

------------------------------------------------------------------------
r50081 | thestig@chromium.org | 2010-06-17 01:39:29 -0700 (Thu, 17 Jun 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/DEPS?r1=50081&r2=50080
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_process_impl.cc?r1=50081&r2=50080

Remove the dependency from renderer on browser.

BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2852012
------------------------------------------------------------------------
Jun 17, 2010
#3 thestig@chromium.org 
I got http://codereview.chromium.org/2814012

Someone needs to fix chrome/browser/visitedlink_unittest.cc (not me) and we'll be done.
Status: Started
Cc: thes...@chromium.org
Jun 17, 2010
#4 thestig@chromium.org 
Bah, I was dreaming. I only looked in chrome/browser and forgot to grep recursively.
Jun 22, 2010
#7 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=50562 

------------------------------------------------------------------------
r50562 | thestig@chromium.org | 2010-06-22 18:18:39 -0700 (Tue, 22 Jun 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_database_helper.cc?r1=50562&r2=50561
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browsing_data_remover.cc?r1=50562&r2=50561
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/crash_recovery_browsertest.cc?r1=50562&r2=50561
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.cc?r1=50562&r2=50561
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_service.h?r1=50562&r2=50561
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profile_import_process_host.h?r1=50562&r2=50561
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_l10n_util.h?r1=50562&r2=50561
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_l10n_util_unittest.cc?r1=50562&r2=50561
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/sandbox_policy.cc?r1=50562&r2=50561

Cleanup: Remove some unneeded webkit/glue headers from chrome.

BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/2850021
------------------------------------------------------------------------
Jun 30, 2010
#9 erik...@chromium.org 
(No comment was entered for this change.)
Labels: not-extensions
Jul 21, 2010
#10 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53113 

------------------------------------------------------------------------
r53113 | thestig@chromium.org | 2010-07-20 16:02:11 -0700 (Tue, 20 Jul 2010) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=53113&r2=53112
   D /trunk/src/chrome/app/chrome_version_info.cc
   D /trunk/src/chrome/app/chrome_version_info.h
   D /trunk/src/chrome/app/chrome_version_info_posix.h.version
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_about_handler.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bug_report_util.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/diagnostics/recon_diagnostics.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/net_internals_ui.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/about_chrome_dialog.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details_mac.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/memory_details_win.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_log.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/safe_browsing/protocol_manager.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/sync_backend_host.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/upgrade_detector.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/about_chrome_view.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bug_report_view.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_exe.gypi?r1=53113&r2=53112
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_version_info.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_version_info.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_version_info_posix.h.version
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_glue.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/automation_proxy.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/reliability/page_load_test.cc?r1=53113&r2=53112
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/metrics_service.cc?r1=53113&r2=53112

Cleanup: Break another common->app dependency.

BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/3007008
------------------------------------------------------------------------
Jul 21, 2010
#11 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53132 

------------------------------------------------------------------------
r53132 | thestig@chromium.org | 2010-07-20 18:09:36 -0700 (Tue, 20 Jul 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/breakpad_linux.cc?r1=53132&r2=53131

Linux Official Build fix following r53113.

BUG=46666
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/2861070
------------------------------------------------------------------------
Jul 22, 2010
#12 bugdroid1@gmail.com 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=53439 

------------------------------------------------------------------------
r53439 | thestig@chromium.org | 2010-07-22 22:33:20 -0700 (Thu, 22 Jul 2010) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/DEPS?r1=53439&r2=53438

Update chrome/common/DEPS now that we broke the dependency on chrome/app.

BUG=46666
TEST=none
TBR=maruel
Review URL: http://codereview.chromium.org/3044016
------------------------------------------------------------------------
Aug 21, 2010
#13 anna...@chromium.org 
(No comment was entered for this change.)
Labels: not-sync
Sep 21, 2010
#14 maruel@chromium.org 
Self-assigning so it doesn't fall into oblivion.
Status: Available
Owner: maruelatchromium
Sep 21, 2010
#15 evan@chromium.org 
I heard akalin volunteered
Owner: aka...@chromium.org
Cc: maruelatchromium
Sep 21, 2010
#16 akalin@google.com 
I did, indeed.
Mar 18, 2011
#17 lafo...@chromium.org 
This is necessary to reduce the dependency bloat the test projects have.
Labels: -Area-BuildTools bulkmove Area-Build
Apr 19, 2011
#18 akalin@chromium.org 
(No comment was entered for this change.)
Owner: ---
Jan 6, 2012
#19 maruel@chromium.org 
John, I guess it's kind of impossible to achieve now, right? If so, it's probably better to just close this bug as WontFix.
Cc: jam@chromium.org
Labels: -Mstone-X -bulkmove
Mar 9, 2013
#20 bugdroid1@chromium.org 
(No comment was entered for this change.)
Labels: -Type-Cleanup -Pri-2 -Area-Internals -Tests -Area-Build Cr-Internals Pri-3 Type-Bug Cr-Tests Build
Blockedon: -chromium:21796 chromium:21796
Blocking: -chromium:4301 chromium:4301
Apr 12, 2013
#21 maruel@chromium.org 
I heard some excitement about this but I don't think it's feasible due to requiring on both sides V8 and other tight relationship between both. Also with the content refactor, it's much less a problem, as as a matter of fact, content is a much better layer than renderer ever was. As such, marking as won't fix.
Status: WontFix
Cc: tfar...@chromium.org
► Sign in to add a comment

Powered by Google Project Hosting