| Issue 46609: | startup_tests.Perf* often times out | |
| 7 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
What steps will reproduce the problem? 1. Run StartupTest.Perf*SeveralTabs or ShutdownTest.TwentyTabs* on a slow 10.6 machine 2. IPC messages might timeout. 3. What is the expected output? What do you see instead? I added some new tests which launch twenty tabs called "StartupTest.Perf*SeveralTabs". The problem existed before in "ShutdownTest.TwentyTabs*", but my new tests made it more frequent. These tests take a relatively long time to complete overall, and the WaitForInitialLoads IPC messages are timing out on one specific 10.6 bot (in other words, all 20 tabs are taking too long to finish loading in time): See http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Perf(2) Here's the 10.6 bot showing failures: http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Perf(2)/builds/4277/steps/startup_test/logs/stdio Here's the 10.5 bot: http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Perf(2)/builds/10159/steps/startup_test/logs/stdio
Jun 15, 2010
#1
path...@chromium.org
Cc:
thoma...@chromium.org
Jun 15, 2010
Pasting the messages inline so they don't get lost. [46478:20231:975595783502084:ERROR:/b/slave/chromium-rel-mac-builder/build/src/base/process_util_posix.cc(325)] parent WaitForMessage() failed: 0x10004003 (ipc/rcv) timed out /b/slave/chromium-rel-mac-builder/build/src/chrome/test/ui/ui_test.cc:264: Failure Value of: server_->WaitForInitialLoads() Actual: false Expected: true *RESULT shutdown: twentytabs-user-quit= [773.62,667.56,774.24,762.22,773.44,780.24,633.32,775.62,782.67,771.92,2744.40,772.17,642.72,664.15,658.78,783.33,660.21,646.06,632.19,764.59,] ms [ FAILED ] ShutdownTest.TwentyTabsUserQuit (81260 ms)
Labels:
GreenTreeTaskForce
Jun 16, 2010
Looks like my new test failed once on WinXP too: http://build.chromium.org/buildbot/waterfall/builders/XP%20Perf%20%28dbg%29/builds/22767/steps/startup_test/logs/stdio [ RUN ] StartupTest.PerfSeveralTabs C:\b\slave\chromium-dbg-builder\build\src\chrome\test\ui\ui_test.cc(264): error: Value of: server_->WaitForInitialLoads() Actual: false Expected: true RESULT warm: several_tabs= [6599.00,5746.00,10575.00,30286.00,6371.00,9472.00,10324.00,7226.00,14072.00,5562.00,9183.00,5906.00,7363.00,5859.00,20244.00,7038.00,10412.00,5886.00,5997.00,6107.00,] ms [ FAILED ] StartupTest.PerfSeveralTabs (235594 ms) I think this is just a problem with opening 20 tabs at once, and on any platform that will cause a lot of contention. I'm going to change my test to load 10 tabs instead since that's more manageable. I can think of two ways to fix this: The PerfRestoreSeveralTabs never seemed to fail, because there were some recent changes to session restore over to command line arguments that will limit the number of tabs that load at the same time. For shutdown tests, it should be possible to make those tests start with no tabs and open one tab at a time, since they don't care about startup time. I'll make another cl to do this.
Jun 16, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=50018
------------------------------------------------------------------------
r50018 | pathorn@chromium.org | 2010-06-16 12:49:57 -0700 (Wed, 16 Jun 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/startup/shutdown_test.cc?r1=50018&r2=50017
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/startup/startup_test.cc?r1=50018&r2=50017
Mark StartupTests.Perf*SeveralTabs and ShutdownTests.*TwentyTabs* as flaky on mac.
BUG=46609
TEST=startup_tests don't fail on mac
Review URL: http://codereview.chromium.org/2850006
------------------------------------------------------------------------
Jun 17, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=50174
------------------------------------------------------------------------
r50174 | pathorn@chromium.org | 2010-06-17 16:58:05 -0700 (Thu, 17 Jun 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/startup/shutdown_test.cc?r1=50174&r2=50173
Fix ShutdownTest flakiness by opening tabs one at a time.
BUG=46609
TEST=startup_tests should no longer flake out as much
Review URL: http://codereview.chromium.org/2809017
------------------------------------------------------------------------
Jun 17, 2010
PerfSeveralTabs uses 10 command line arguments, just like the old ShutdownTests, and it still flakes out on our mac 10.6 perf bot. The just-committed change fixed shutdown tests to not flake out because of this bug. However, it did not fix the underlying bug that passing a large number of command line arguments to chrome causes it to sometimes fail on mac (and very rarely on winxp). So this bug needs to stay open for the foreseeable future.
Summary:
startup_tests.PerfSeveralTabs often times out on OSX 10.6.
Jun 18, 2010
Strangely enough, even with the new ShutdownTest, AppendTab can also fail on this machine: http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Perf(2)/builds/4398/steps/startup_test/logs/stdio [47012:20231:1195256920139900:ERROR:/b/slave/chromium-rel-mac-builder/build/src/base/process_util_posix.cc(334)] parent WaitForMessage() failed: 0x10004003 (ipc/rcv) timed out /b/slave/chromium-rel-mac-builder/build/src/chrome/test/startup/shutdown_test.cc:62: Failure Value of: browser_proxy->AppendTab( net::FilePathToFileURL(test_cases[i])) Actual: false Expected: true I'd be curious what's happening when this command is failing? Is it just failing to open a tab, is it really taking a long time (command_execution_timeout is 30 seconds), or is the reply message somehow getting lost? While 30 seconds for opening a browser with 20 tabs might be understandable, timing out when opening a single tab shouldn't happen.
Jun 21, 2010
(No comment was entered for this change.)
Status:
Assigned
Jul 8, 2010
Issue 48546 has been merged into this issue.
Cc:
to...@chromium.org cbent...@chromium.org m...@chromium.org jer...@chromium.org
Jul 19, 2010
(No comment was entered for this change.)
Labels:
Mstone-X
Jul 30, 2010
(No comment was entered for this change.)
Labels:
-FlakyTest Tests-Flaky
Aug 23, 2010
The ipc/rcv timeouts are responsible for much of the Mac flaky redness. See also bug 52858 . Patrick, are you still actively looking at this? We really should figure this one out.
Cc:
phajdan...@chromium.org
Labels: -Pri-2 Pri-1
Aug 23, 2010
Happens most on mac, but it appears it's not specific to Mac. (Pulling in mstone since the frequence on the mac is increasting and the meta bug this blocks is mstone7) http://build.chromium.org/buildbot/waterfall/builders/XP%20Interactive%20Perf/builds/8142/steps/startup_test/logs/stdio : [ RUN ] StartupTest.PerfRestoreFewTabs .\test\ui\ui_test.cc(278): error: Value of: server_->WaitForInitialLoads() Actual: false Expected: true RESULT few_tabs: restore= [25056.00,435.00,444.00,475.00,457.00,459.00,450.00,453.00,455.00,452.00,461.00,431.00,463.00,470.00,416.00,453.00,458.00,439.00,458.00,459.00,] ms [ FAILED ] StartupTest.PerfRestoreFewTabs (37969 ms) http://build.chromium.org/buildbot/waterfall/builders/XP%20Interactive%20Perf/builds/8140/steps/startup_test/logs/stdio : [ RUN ] StartupTest.PerfFewTabs [3168:2328:0823/155125:1671995360:ERROR:scoped_temp_dir.cc(15)] ScopedTempDir unable to delete C:\DOCUME~1\CHROME~1\LOCALS~1\Temp\scoped_dir5325 .\test\ui\ui_test.cc(278): error: Value of: server_->WaitForInitialLoads() Actual: false Expected: true RESULT few_tabs: cmdline= [388.00,265.00,263.00,248.00,266.00,238.00,252.00,249.00,251.00,248.00,252.00,273.00,266.00,242.00,268.00,226.00,247.00,264.00,239.00,25055.00,] ms [ FAILED ] StartupTest.PerfFewTabs (33719 ms)
Summary:
startup_tests.Perf* often times out
Labels: -OS-Mac -Mstone-X OS-All Mstone-7
Aug 25, 2010
Copying a comment from Issue 52858 , since this is the older bug: A very large number of tests are now flaky because of this problem, to the point where I haven't been bothering to mark them as such. I've just been checking each failure manually, because that seemed less silly than marking 50% of our tests as flaky :) Does anyone have any ideas as to what could be causing this? Any guesses on where to start looking?
Aug 30, 2010
I've run startup_tests --gtest_filter=StartupTest.PerfFewTabs for several hours on both my 10.5 machine and on windows XP to reproduce this on my own, but I've had no success getting a timeout/failed test, so I don't have any ideas on how to track this down. Most importantly, is this a problem with the browser process, or are the automation IPC calls just entirely failing to connect, cascading to later failures? (then this error could happen to any ui test). Why does the failure seem more likely for larger tests?
Oct 5, 2010
Pat, do you still see this? A lot of the flakiness on Mac was fixed by Rohit, though his fix wouldn't have addressed flakiness on Windows.
Oct 12, 2010
Bulk moving to mstone 8, at this point work on m7 should effectively be closed. If something in this bulk edit is not actively being worked on, please change the mstone to m9.
Labels:
-Mstone-7 Mstone-8
Oct 19, 2010
Since we are passed the branch, moving all mstone-8 issues to mstone-9 for triage/punting
Labels:
-Mstone-8 Mstone-9
Nov 30, 2010
Moving all mstone:9 bugs that are not ReleaseBlockers to mstone:10
Labels:
-Mstone-9 Mstone-10 MovedFrom-9
Dec 1, 2010
PerfSeveralTabs has not passed on XP Perf (dbg) since at least Friday 11/26. There are a couple green runs here and there, but the vast majority (> 90%) end in test failures. I'll mark the test as flaky on OS_WIN as well. [ RUN ] StartupTest.PerfSeveralTabs .\test\ui\ui_test.cc(213): error: Value of: automation_proxy_->WaitForInitialLoads() Actual: false Expected: true .\test\ui\ui_test.cc(213): error: Value of: automation_proxy_->WaitForInitialLoads() Actual: false Expected: true RESULT several_tabs: cmdline= [19523.00,18356.00,21636.00,13398.00,15910.00,23377.00,15839.00,16627.00,24103.00,12455.00,25851.00,25854.00,23462.00,22501.00,13735.00,17319.00,18217.00,22036.00,18784.00,14423.00,] ms [ FAILED ] StartupTest.PerfSeveralTabs (442391 ms) [ RUN ] StartupTest.PerfRestoreSeveralTabs .\test\ui\ui_test.cc(213): error: Value of: automation_proxy_->WaitForInitialLoads() Actual: false Expected: true RESULT several_tabs: restore= [18213.00,6351.00,10792.00,7781.00,6596.00,9165.00,8290.00,8748.00,8033.00,4986.00,11381.00,4364.00,6396.00,6336.00,8452.00,6187.00,6689.00,9807.00,4896.00,7654.00,] ms RESULT several_tabs: restore-start= [275.00,261.00,269.00,263.00,259.00,268.00,267.00,259.00,262.00,268.00,272.00,283.00,292.00,269.00,270.00,279.00,267.00,269.00,278.00,258.00,] ms RESULT several_tabs: restore-first= [860.00,961.00,2384.00,1073.00,1157.00,1977.00,1611.00,1082.00,1061.00,763.00,939.00,1186.00,972.00,753.00,1087.00,1271.00,937.00,1073.00,770.00,1005.00,] ms RESULT several_tabs: restore-4= [4028.00,3214.00,8110.00,4236.00,3208.00,4646.00,4818.00,5423.00,4438.00,3553.00,5273.00,2729.00,3904.00,2871.00,3656.00,4863.00,3070.00,6933.00,2153.00,4267.00,] ms RESULT several_tabs: restore-all= [17957.00,6069.00,10542.00,7513.00,6330.00,8882.00,7915.00,8481.00,7765.00,4702.00,11052.00,4068.00,6114.00,6039.00,8169.00,5921.00,6406.00,9571.00,4583.00,7387.00,] ms [ FAILED ] StartupTest.PerfRestoreSeveralTabs (205270 ms)
Dec 1, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=67895
------------------------------------------------------------------------
r67895 | rohitrao@chromium.org | Wed Dec 01 12:31:28 PST 2010
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/startup/startup_test.cc?r1=67895&r2=67894&pathrev=67895
Mark StartupTest.PerfSeveralTabs as flaky on Win.
BUG=46609
TEST=Should turn green!
Review URL: http://codereview.chromium.org/5460001
------------------------------------------------------------------------
Jan 27, 2011
Move to M11 from M10, as we've now branched. If you believe this bug was moved in error, please come talk to me.
Labels:
-Mstone-10 Mstone-11 MovedFrom-10
Mar 9, 2011
rolling non releaseblocker mstone 11 bugs to mstone 12.
Labels:
-Mstone-11 MovedFrom-11 Mstone-12
Mar 18, 2011
<b>What steps will reproduce the problem?</b> 1. Run StartupTest.Perf*SeveralTabs or ShutdownTest.TwentyTabs* on a slow 10.6 machine 2. IPC messages might timeout. <b>3.</b> <b>What is the expected output? What do you see instead?</b> I added some new tests which launch twenty tabs called "StartupTest.Perf*SeveralTabs". The problem existed before in "ShutdownTest.TwentyTabs*", but my new tests made it more frequent. These tests take a relatively long time to complete overall, and the WaitForInitialLoads IPC messages are timing out on one specific 10.6 bot (in other words, all 20 tabs are taking too long to finish loading in time): See http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Perf(2) Here's the 10.6 bot showing failures: http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Perf(2)/builds/4277/steps/startup_test/logs/stdio Here's the 10.5 bot: http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Perf(2)/builds/10159/steps/startup_test/logs/stdio
Labels:
-GreenTreeTaskForce TaskForce-GreenTree
Jun 1, 2011
This bug was targeted for M12, but not fixed. Moving out to M14.
Labels:
-Mstone-12 MovedFrom12 Mstone-14
Jun 2, 2011
(No comment was entered for this change.)
Labels:
-MovedFrom12 MovedFrom-12
Oct 8, 2011
Putting this back out into Untriaged. It still affects startup tests on Windows and the previous owner is not available to look into this.
Status:
Untriaged
Owner: --- Cc: path...@chromium.org
Nov 8, 2011
(No comment was entered for this change.)
Labels:
Hotlist-Fixit
Feb 14, 2012
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=121942
------------------------------------------------------------------------
r121942 | evan@chromium.org | Tue Feb 14 13:35:25 PST 2012
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/perf/startup_test.cc?r1=121942&r2=121941&pathrev=121942
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/npapi_uitest.cc?r1=121942&r2=121941&pathrev=121942
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/layout_plugin_uitest.cc?r1=121942&r2=121941&pathrev=121942
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/dom_automation_browsertest.cc?r1=121942&r2=121941&pathrev=121942
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui/ppapi_uitest.cc?r1=121942&r2=121941&pathrev=121942
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/perf/feature_startup_test.cc?r1=121942&r2=121941&pathrev=121942
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/reliability/automated_ui_test_test.cc?r1=121942&r2=121941&pathrev=121942
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/automation_proxy_uitest.cc?r1=121942&r2=121941&pathrev=121942
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/automation/extension_proxy_uitest.cc?r1=121942&r2=121941&pathrev=121942
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/chrome_process_util_uitest.cc?r1=121942&r2=121941&pathrev=121942
Flakiness cleanup: disable flaky tests under chrome/test/
See https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/fcec09fc659f39a6
BUG=98071,109642,32293,60409,44617,62143,25039,72745,59441,59440,79175,69940,101591,46609,52858,102584,99604,96049,112821,96039,113406,81050,59327,30702,71904,44960,104380,111508,109258,111636,111355,111209,63239
Review URL: http://codereview.chromium.org/9358065
------------------------------------------------------------------------
Aug 2, 2012
(No comment was entered for this change.)
Status:
Assigned
Owner: jeremy@chromium.org
Nov 20, 2012
P1 bugs that have been moved 3+ times. Downgrading to P2
Labels:
-Pri-1 Pri-2
Blocking: -chromium:48151 -chromium:52858 chromium:48151 chromium:52858
Nov 20, 2012
Bugs that have been moved 5 or more times. Removing Mstone label.
Labels:
MstoneRemoved
Nov 20, 2012
Bugs that have been moved 5 or more times. Removing Mstone label.
Nov 20, 2012
Bugs that have been moved 5 or more times. Removing Mstone label.
Nov 20, 2012
Bugs that have been moved 5 or more times. Removing Mstone label.
Nov 20, 2012
Bugs that have been moved 5 or more times. Removing Mstone label.
Labels:
-Mstone-14
Nov 26, 2012
(No comment was entered for this change.)
Labels:
PriDowngrade
Mar 10, 2013
(No comment was entered for this change.)
Labels:
-Area-UI -Tests -Tests-Flaky -Stability-Performance Cr-Tests-Flaky Cr-UI Performance Cr-Tests
|
||||||||
| ► Sign in to add a comment | |||||||||