My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 45594: FindInPageControllerTest.ActivateLinkNavigatesPage and ExtensionApiTest.Bookmarks 'crashed'
2 people starred this issue and may be notified of changes. Back to list
Status:  Available
Owner:  ----
Cc:  j...@chromium.org, finnur@chromium.org


Sign in to add a comment
 
Project Member Reported by jshin@chromium.org, Jun 1, 2010
On XP Tests bot: the test didn't complete with the following rather 
short/cryptic  backtrace. I've just seen it once today, but it may have 
happened before. 

Note: Google Test filter = 
FindInPageControllerTest.ActivateLinkNavigatesPage
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from FindInPageControllerTest
[ RUN      ] FindInPageControllerTest.ActivateLinkNavigatesPage
Backtrace:
	RevokeDragDrop [0x77532BE5+144]
	Hunspell_create_key [0x004CF8E0+547648]
Jun 1, 2010
#1 jshin@chromium.org
(No comment was entered for this change.)
Labels: Feature-FindInPage
Jun 1, 2010
#2 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=48683 

------------------------------------------------------------------------
r48683 | jshin@chromium.org | 2010-06-01 17:24:35 -0700 (Tue, 01 Jun 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_bookmarks_apitest.cc?r1=48683&r2=48682
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/find_bar_host_browsertest.cc?r1=48683&r2=48682

Disable FindInPageControllerTest.ActivateLinkNavigatesPage and 
ExtensionApiTest.Bookmarks on Windows

BUG=45594,45595
TEST=Windows bot don't turn red with browser_test failure
TBR=jrg
Review URL: http://codereview.chromium.org/2433003
------------------------------------------------------------------------

Jun 22, 2010
#3 lafo...@chromium.org
(No comment was entered for this change.)
Status: Available
Labels: Mstone-X
Jun 30, 2010
#4 erik...@chromium.org
(No comment was entered for this change.)
Labels: not-extensions
Sep 20, 2010
#5 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=59930

------------------------------------------------------------------------
r59930 | finnur@chromium.org | Mon Sep 20 07:05:27 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/find_bar_host_browsertest.cc?r1=59930&r2=59929&pathrev=59930

Updating status on three tests:

Someone changed FindInPagePrematureEnd from DISABLED to FAILS. However, it is not expected to pass until we fix 11761 so we don't need to run it until then. Marking it back as DISABLED.

NoIncognitoPrepopulate was failing because the infrastructure was laggy (the simple act of launching a page in incognito could take up to a minute). I can no longer repro the error, so I think the problem is gone.

Back in June, ActivateLinkNavigatesPage got marked as DISABLED (because it crashed occasionally), with a bug filed against no-one, so I have no crashdump or try bot logs nor any idea what the state of it is. Marking as enabled to see if it is still a problem. It passes locally.

BUG=45594, 40948
TEST=These are tests.

Review URL: http://codereview.chromium.org/601044
------------------------------------------------------------------------
Summary: FindInPageControllerTest.ActivateLinkNavigatesPage 'crashed'
Sep 20, 2010
#6 finnur@chromium.org
This test is enabled again on Windows. If it starts crashing, I'll see if I can get a meaningful stack. Without one, there is nothing actionable here, since the Find feature I'm testing is working and it doesn't crash locally.

Erik, I left the Bookmark test as-is. I suspect in both cases the crash is something transient not related to the feature being tested, but probably better if you make the call for the Bookmark test (blame list has your name on it).
Summary: FindInPageControllerTest.ActivateLinkNavigatesPage and ExtensionApiTest.Bookmarks 'crashed'
Labels: -Feature-FindInPage -not-extensions Tests
Mar 10, 2013
#7 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI -Tests Cr-Tests Cr-UI
Sign in to add a comment

Powered by Google Project Hosting