My favorites | Sign in
Project Home Downloads Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 45147: Update available notification (Mac)
10 people starred this issue and may be notified of changes. Back to list
 
Reported by project member mark@chromium.org, May 26, 2010
From  bug 27941 .

I’m interested in the backend work here, but not so much in the UI.
Comment 1 by mark@chromium.org, May 26, 2010
(No comment was entered for this change.)
Cc: pinker...@chromium.org
Comment 2 by thakis@chromium.org, May 26, 2010
(No comment was entered for this change.)
Labels: Mstone-6
Comment 3 by kr...@chromium.org, Jun 2, 2010
Brian - we need to know what we are going to have UI wise.
Status: Assigned
Owner: m...@chromium.org
Cc: -m...@chromium.org fin...@chromium.org br...@chromium.org j...@chromium.org
Labels: -Pri-2 Pri-1 Area-Internals Internals-Install
Comment 4 by thakis@chromium.org, Jun 2, 2010
krisr: Page and Tools menu will be unified and then default to on on OS X as well since it's only one button. That 
button will show a yellow light, like on windows.
Comment 5 by br...@chromium.org, Jun 2, 2010
The plan described by thakis the plan as I know it.
Comment 6 by thakis@chromium.org, Jun 2, 2010
(No comment was entered for this change.)
Blockedon: 37925
Comment 7 by fin...@chromium.org, Jun 2, 2010
Hmm... I don't understand why this is blocked on 37925...? The same would have applied 
to Windows and the Windows version is checked in already.
Comment 8 by thakis@chromium.org, Jun 2, 2010
'cause mac doesn't show wrench/tools buttons by default, but windows does.
Comment 9 by fin...@chromium.org, Jun 2, 2010
I see. I guess I should say that the development of the feature is not gated on that 
since you can turn it on while developing and then once we make it on by default it 
just works... (maybe that's the plan already?)
Comment 10 by bugdroid1@gmail.com, Jul 15, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=52524 

------------------------------------------------------------------------
r52524 | mark@chromium.org | 2010-07-15 13:46:36 -0700 (Thu, 15 Jul 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/keystone_glue.h?r1=52524&r2=52523
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/keystone_glue.mm?r1=52524&r2=52523
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/upgrade_detector.cc?r1=52524&r2=52523
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=52524&r2=52523
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_installer_util.gypi?r1=52524&r2=52523

Make UpgradeDetector work on the Mac.

This is the backend work only. There's no UI yet.

BUG=45147
TEST=manual
Review URL: http://codereview.chromium.org/3032001
------------------------------------------------------------------------

Comment 11 by mark@chromium.org, Jul 15, 2010
Backend done. Over to Rob for uiuiui.
Owner: rse...@chromium.org
Cc: m...@chromium.org
Comment 12 by rsesek@chromium.org, Jul 16, 2010
(No comment was entered for this change.)
Status: Started
Comment 13 by bugdroid1@gmail.com, Jul 19, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=52911 

------------------------------------------------------------------------
r52911 | rsesek@chromium.org | 2010-07-19 09:14:47 -0700 (Mon, 19 Jul 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_shutdown.cc?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/menu_controller.mm?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/restart_browser.mm?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=52911&r2=52910
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/wrench_menu_model.cc?r1=52911&r2=52910

[Mac] Implement the update available notification in the wrench menu.

The changes to restart_browser.mm also affect the sheet displayed in the About
window. Note that the badge on the wrench menu looks bad.

BUG=45147
TEST=difficult

Review URL: http://codereview.chromium.org/2856042
------------------------------------------------------------------------

Comment 14 by rsesek@chromium.org, Jul 19, 2010
(No comment was entered for this change.)
Status: Fixed
Comment 15 by bugdroid1@gmail.com, Aug 2, 2010
Verifier Updated by AutoAllocator, contact AmolK or KrisR for questions
Labels: Verifier-Srikanth
Comment 16 by srikan...@chromium.org, Aug 2, 2010
The Change not visible on Mac Google Chrome	6.0.472.18 (Official Build 54489) dev
Testing steps :
1. Point chrome ticket to update(+1) , verify from about menu update available .
check for the notification on wrench menu.

Comment 17 by rsesek@chromium.org, Aug 2, 2010
The notification is on a timer. I believe it's currently set to 24 hours before it gets shown.
Comment 18 by kr...@chromium.org, Aug 5, 2010
(No comment was entered for this change.)
Labels: -Verifier-Srikanth Verifier-Srikanthk
Comment 19 by srikan...@chromium.org, Aug 6, 2010
Platform:
  Hostname: testings-mac-mini-3.local
  Mac OS X Version 10.6.4 (Build 10F569)
  Processor: 4 Intel 2.66 GHz
  RAM: 2048 MB

Chrome:
  Chrome version: 6.0.484.0 r54715  <<<Release/Debug>>>
  QuickTime Player: 7.6.6
  QuickTime PlayerX: 114

Status: Verified
Comment 20 by stuartmorgan@chromium.org, Aug 16, 2010
 Issue 45370  has been merged into this issue.
Comment 21 by rsesek@chromium.org, Oct 27, 2010
 Issue 52402  has been merged into this issue.
Sign in to add a comment

Powered by Google Project Hosting