| Issue 40233: | "Uninstall" functionality failed for extensions from page action icons context menu | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Restricted
Sign in to add a comment
|
Platform: Hostname: ismail-macbookpro15.local Mac OS X Version 10.5.8 (Build 9L31a) Processor: 2 Intel 2.33 GHz RAM: 2048 MB Chrome: Chrome version: 5.0.366.0 r43169 <<<Release>>> QuickTime Player: 7.6.4 QuickTime PlayerX: <unknown> Flash Player: 10.0.45.2 What steps will reproduce the problem? 1. Install "Flash block" https://chrome.google.com/extensions/detail/gofhjkjmkpinhpoiabjplobcaignabnl?hl=en 2. Open any flash sites, extension Icon sits in omnibox 3. Right click on extension icon to get context menu , Choose "Uninstall" Actual: Does nothing, Uninstall failed. Expected: Should get a "Confirm Uninstallation" dialog and get Uninstalled successfully. Note: Same extension can be successfully uninstalled via chrome://extensions page with out any issues.
Jul 30, 2010
We kind of shouldn't have menu items which don't work.
Labels:
Mstone-7
Aug 17, 2010
(No comment was entered for this change.)
Status:
Assigned
Owner: andyb...@chromium.org
Aug 18, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=56532
------------------------------------------------------------------------
r56532 | andybons@chromium.org | 2010-08-18 09:04:47 -0700 (Wed, 18 Aug 2010) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.h?r1=56532&r2=56531
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/location_bar/page_action_decoration.mm?r1=56532&r2=56531
[Mac] Retain a reference within a scoped_nsobject of a Page Action's context menu.
The problem was that the menu was being dealloc'd upon selection of the 'Uninstall' option, which asynchonously loads the extension's icon. Upon deallocation, the ImageTracker was also being destructed and the loading cancelled, leaving OnImageLoad to never be called.
BUG=40233
TEST=see bug for repro steps. should be able to uninstall page actions through their context menus.
Review URL: http://codereview.chromium.org/3148018
------------------------------------------------------------------------
Aug 18, 2010
(No comment was entered for this change.)
Status:
Fixed
Aug 18, 2010
Verified label updated by AutoAllocator, contact AmolK or KrisR for details
Labels:
Verifier-Srikanthk
Aug 24, 2010
Platform: Hostname: testings-mac-mini-3.local Mac OS X Version 10.6.4 (Build 10F569) Processor: 4 Intel 2.66 GHz RAM: 2048 MB Chrome: Chrome version: 7.0.503.0 r57033 <<<Release/Debug>>> QuickTime Player: 7.6.6 QuickTime PlayerX: 114
Status:
Verified
Oct 12, 2012
This issue has been closed for some time. No one will pay attention to new comments. If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels:
Restrict-AddIssueComment-Commit
Mar 10, 2013
(No comment was entered for this change.)
Labels:
-Area-UI -Feature-Extensions -Mstone-7 Cr-Platform-Extensions M-7 Cr-UI
Mar 13, 2013
(No comment was entered for this change.)
Labels:
-Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
|
||||||||||
| ► Sign in to add a comment | |||||||||||
Cc: miran...@chromium.org