My favorites | Sign in
Project Home Downloads Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 36798: Update mac tabstrip to support mini-tabs
7 people starred this issue and may be notified of changes. Back to list
 
Reported by project member sky@chromium.org, Feb 25, 2010
The mac tabstrip needs to be updated to support mini-tabs. See the patches 
in 32845 for specifics.
Comment 1 by mikesm...@chromium.org, Feb 26, 2010
(No comment was entered for this change.)
Labels: Mstone-5 ReleaseBlock-Stable
Comment 2 by mikesm...@chromium.org, Feb 26, 2010
(No comment was entered for this change.)
Status: Assigned
Owner: pinker...@chromium.org
Comment 3 by marceloc...@gmail.com, Mar 9, 2010
Any update for this one ? As I can see it is already working on linux and windows.

Cheers
Comment 5 by pinkerton@chromium.org, Mar 19, 2010
re-requesting triage.
Status: Untriaged
Owner: ---
Cc: pinker...@chromium.org
Comment 6 by mikesm...@chromium.org, Mar 19, 2010
No Mac team anymore - can you take care of this. Thanks!
Status: Assigned
Owner: s...@chromium.org
Labels: UI-Needed
Comment 7 by sky@chromium.org, Mar 19, 2010
I will not have time to do this before M5.
Status: Available
Owner: ---
Comment 8 by rsesek@chromium.org, Mar 20, 2010
(No comment was entered for this change.)
Status: Started
Owner: rse...@chromium.org
Comment 9 by br...@chromium.org, Mar 22, 2010
wrong use of ui-needed (that's for mocks). Ben's looking for an owner.
Labels: -UI-Needed
Comment 10 by sky@chromium.org, Mar 22, 2010
rsesek has a patch out for review that fixes this:)
Comment 11 by mikesm...@chromium.org, Mar 23, 2010
(No comment was entered for this change.)
Labels: -Pri-2 -ReleaseBlock-Stable Pri-1 ReleaseBlock-Beta
Comment 12 by bugdroid1@gmail.com, Mar 24, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=42548 

------------------------------------------------------------------------
r42548 | rsesek@chromium.org | 2010-03-24 15:33:08 -0700 (Wed, 24 Mar 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_controller.h?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_controller.mm?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_controller.h?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_controller.mm?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.h?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/defaults.cc?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/defaults.h?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service.cc?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/session_service_unittest.cc?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sessions/tab_restore_service_unittest.cc?r1=42548&r2=42547
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_menu_model.cc?r1=42548&r2=42547

[Mac] Re-enable pinned tabs; add support for mini-tabs and phantom tabs.

This CL rewires the old support for pinned tabs to support mini-tabs. This also
removes the kEnablePinnedTabs browser default now that all platforms support it.
Note that pinning is now only accessible through the context menu; drag-to-pin
has been removed.

BUG=36798, 32845
TEST=Right-click and pin two tabs. Test dragging on and off and around the tab strip.
TEST=Cmd+W a pinned tab and it should go phantom (renderer closes down) and the tab is made alpha.

Review URL: http://codereview.chromium.org/1119005
------------------------------------------------------------------------

Comment 13 by rsesek@chromium.org, Mar 24, 2010
(No comment was entered for this change.)
Status: Fixed
Comment 14 by deep...@chromium.org, Mar 30, 2010
Verified in 5.0.365.0 (Official Build 43016)
Status: Verified
Sign in to add a comment

Powered by Google Project Hosting