My favorites | Sign in
Project Home Downloads Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 36775: Option-clicking a link should bypass "Save As" dialog
5 people starred this issue and may be notified of changes. Back to list
 
Reported by sung...@gmail.com, Feb 25, 2010
Chrome Version: 5.0.335.0 dev
OS version: OS X 10.6.2

Behavior in Safari 3.x/4.x (if applicable):
Option-clicking a link downloads the resource without opening up a save-as dialog

Behavior in Firefox 3.x (if applicable):
Firefox also downloads an option-clicked link without a save-as dialog.

What steps will reproduce the problem?
1. Click on a link with the option key activated.

What is the expected result?
On other OS X browsers, pressing option when clicking a link forces download of the resource 
with no confirmation, enabling the user to quickly download lists of resources.

What happens instead?
On Google Chrome, option-clicking a link brings up a "Save as" dialog, which is extremely slow, 
and also duplicates the function of the "Save Link As..." contextual menu item.

Comment 1 by mega...@gmail.com, Feb 25, 2010
Google Chrome doesn't have a default download folder until you set one, so I'm not sure 
how you would expect this to work. :P

Once you set one, it skips the Save As dialog all the time, no need for an Option 
modifier.
Comment 2 by sung...@gmail.com, Feb 25, 2010
@megazzt

Chrome downloads a resource if it, or a plugin, has not registered itself as a handler for that MIME type.

If Chrome does know how to open a resource, like the attached picture, it does not download the resource, but 
in fact opens it. If you want to download the picture then, on OS X you typically either:

a) Right click, and choose "Save Link As..."
or
b) option-click the picture
this is mah job.jpeg
34.7 KB   View   Download
Comment 3 by rohi...@chromium.org, Feb 26, 2010
5.0.338.0 (Official Build 40104) dev

Mac Safari works as mentioned in the bug.
Status: Untriaged
Cc: kr...@chromium.org rohi...@chromium.org
Comment 4 by mikesm...@chromium.org, Feb 26, 2010
Is this cross plat? thanks
Status: Assigned
Owner: kr...@chromium.org
Comment 5 by sung...@gmail.com, Feb 26, 2010
Alt-click on Firefox also bypasses the save dialog on Windows 7. I don't know about Safari on windows, but I 
would assume so.
Comment 6 by kr...@chromium.org, Feb 26, 2010
(No comment was entered for this change.)
Labels: -Area-Undefined Area-UI OS-All
Comment 7 by srikan...@chromium.org, Mar 31, 2010
Repeatable on 
Google Chrome	5.0.365.0 (Official Build 43016) unknown
WebKit	533.3
V8	2.2.0
Comment 8 by ism...@chromium.org, May 18, 2010
Retested on TOT
Chrome version: 6.0.401.1 r47052  <<<Release>>>

Reproducible.
Cc: ism...@chromium.org
Comment 9 by kr...@chromium.org, May 18, 2010
(No comment was entered for this change.)
Status: Untriaged
Owner: ---
Comment 10 by rsesek@chromium.org, May 18, 2010
 Issue 44422  has been merged into this issue.
Comment 11 by lafo...@chromium.org, May 18, 2010
(No comment was entered for this change.)
Status: WontFix
Comment 12 by sung...@gmail.com, May 18, 2010
>No comment was entered for this change.)
>Status: WontFix

That's disappointing. This along with having no means to close the download bar with the keyboard makes 
downloading a very clunky experience on Chrome.
Comment 13 by evan@chromium.org, Jun 7, 2010
I suspect closing this might have been a misclick.  Perhaps a Mac expert has an 
opinion on UI consistency (see comment #2).  Especially if this bypasses the download 
dialog on browsers that normally prompt, it seems reasonable to me to match that.
Status: Untriaged
Owner: pinker...@chromium.org
Comment 14 by mikesm...@chromium.org, Jun 7, 2010
was a mis-click
Status: Available
Labels: Mstone-6 HelpWanted
Comment 15 by jer...@chromium.org, Jun 22, 2010
(No comment was entered for this change.)
Owner: jer...@chromium.org
Cc: pinker...@chromium.org
Comment 16 by jer...@chromium.org, Jul 11, 2010
(No comment was entered for this change.)
Status: Started
Comment 18 by jer...@chromium.org, Jul 14, 2010
(No comment was entered for this change.)
Status: Fixed
Comment 19 by jer...@chromium.org, Jul 14, 2010
(Whoops, patch is lgtmed but hasn't landed yet, reseting status till patch does land)
Status: Started
Comment 20 by bugdroid1@gmail.com, Jul 18, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=52848 

------------------------------------------------------------------------
r52848 | jeremy@chromium.org | 2010-07-18 03:45:28 -0700 (Sun, 18 Jul 2010) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_file_manager.cc?r1=52848&r2=52847
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_manager.cc?r1=52848&r2=52847
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/history/download_types.h?r1=52848&r2=52847
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/download_resource_handler.cc?r1=52848&r2=52847
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc?r1=52848&r2=52847
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h?r1=52848&r2=52847
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.cc?r1=52848&r2=52847

Option-click to download should not display "Save As" UI.

The download manager has a concept of a request originating from the "Save As..." contextual menu v.s. a direct download request from the renderer, however this was't hooked up.

The Download Manager uses boolean variables named "save_as" in various locations to track whether a download originated via a contextual menu selection (in which case the save panel should be displayed) or via a renderer request (in which case no UI should be displayed).

This CL contains 3 distinct changes:

1. DownloadFileManager::OnDownloadURL() is where downloads originating from the contextual menu are dispatched, set save_as to true if the download starts here.

2. ResourceMessageFilter::OnDownloadURL() is where downloads originating from the renderer are dispatched (e.g. option-click), don't display UI for these.

3. The "save_as" variable in the DownloadCreateInfo structure doesn't really reflect the origin of the request but whether the Save panel should be displayed. This can happen for example on a name collision or if the default download location isn't writeable regardless of the action that initiated the download.  Renamed the variable and added documentation to this effect.

BUG=36775
TEST=Option-click an image, the image should be saved without prompting the user for a download locate.  Save an image via the "Save As..." context menu, you should be prompted for the save location.

Review URL: http://codereview.chromium.org/2927006
------------------------------------------------------------------------

Comment 21 by jer...@chromium.org, Jul 18, 2010
(No comment was entered for this change.)
Status: Fixed
Comment 22 by sung...@gmail.com, Jul 18, 2010
Huzzah. Thanks for patching this in jeremy.
Comment 23 by ism...@chromium.org, Jul 20, 2010
Chrome version: 6.0.471.0 r52878
Status: Verified
Comment 25 by donarnul...@gmail.com, Jul 22, 2010
I hope Google fixes this problem: 
http://code.google.com/p/chromium/issues/detail?id=35532
Sign in to add a comment

Powered by Google Project Hosting