My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 360042: Consider using single user-set brightness level instead of separate ones for AC and battery
2 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by derat@chromium.org, Apr 4, 2014
powerd currently maintains two user-specified panel backlight brightness levels, one used while on AC power and one for battery. The former is always greater-than-or-equal-to the latter: if you hold the brightness-up key while on battery power, the stored AC brightness is also increased as soon as the battery brightness would exceed it.

I'm not sure that it makes sense to track two separate levels after the user has started adjusting the brightness -- that's a clear sign that they have a strong preference for a specific brightness. I run into this frequently when I adjust the brightness to the lowest level while on battery power in a dark room and then get blinded when we jump to 80% after I plug in the charger.

I propose preserving the existing default percentages (63% and 80% for battery and AC, I think) but only switching between them automatically if the user hasn't touched the brightness keys since the system booted. After the user adjusts the brightness, we should just track their requests as a single level instead of keeping a separate level for each power source.

(The policy being tracked at issue 310429 would still support separate AC and battery levels, of course.)
Apr 15, 2014
#1 bartfab@chromium.org
I think that separate brightness settings for AC and battery are a useful feature *if* these get persisted across reboots. You can make the screen bright while working on your desk and have it automatically dim whenever you unplug the power adapter. But this kind of micro-management only really makes sense if the settings will be preserved across reboots. If you have to re-adjust brightness after every boot anyway, I agree that there is not much value in managing two separate settings and having Daniel blinded when he plugs in his AC adapter.
Apr 20, 2014
#2 derat@chromium.org
(No comment was entered for this change.)
Status: Started
Apr 21, 2014
#3 bugdro...@chromium.org
Project: chromiumos/platform/power_manager
Branch : master
Author : Daniel Erat <derat@chromium.org>
Commit : ab17d5bd19d4bd57fcf3fe0bbc11f2266b4c42c7

Code-Review  0 : Daniel Erat, chrome-internal-fetch
Code-Review  +2: Chris Masone
Commit-Queue 0 : Chris Masone, chrome-internal-fetch
Commit-Queue +1: Daniel Erat
Verified     0 : Chris Masone, chrome-internal-fetch
Verified     +1: Daniel Erat
Change-Id      : I4ec6975fa058f66d8d3eaea503df122073653fc6
Reviewed-at    : https://chromium-review.googlesource.com/195819

power: Use one user-set brightness level for battery and AC.

When the user adjusts the brightness because it's too bright
or too dim, they probably don't want us to change it later
just becuase they plugged or unplugged their charger.
Instead of tracking separate user-set brightness levels to
use while on battery and AC power, make powerd use the same
level for both.

The default brightness level still differs between the two
power sources, and Chrome is able to request different
levels via policies that it sends to powerd.

BUG=chromium:360042
TEST=manually checked that brightness doesn't change when
     plugging or unplugging charger after manually setting
     the brightness; also updated existing tests

powerd/policy/internal_backlight_controller.cc
powerd/policy/internal_backlight_controller_unittest.cc
Apr 21, 2014
#4 arsc...@chromium.org
We shouldn't make changes like this without looking at the power impact, as this is going to increase power usage on battery. 

+Sameer for thoughts.
Cc: sna...@chromium.org
Apr 21, 2014
#5 derat@chromium.org
The default levels are unchanged; this change only affects users who have adjusted the brightness to the level that they want.
Apr 22, 2014
#6 tbroch@chromium.org
According to stats Power.UserBrightnessAdjustmentsPerSessionOnBattery & Power.UserBrightnessAdjustmentsPerSessionOnAC no more than 15% of current users adjust their backlight setting during a session.  

Of those making the change on battery most (12%) make adjustment to 100% brightness ( Power.BacklightLevelOnBattery )

This change will likely help those who appear to already be keeping brightness at 100% avoid raising it manually when transitioning from AC to battery.

As for power impact operating at 100% (vs 63%) on 200nit display is roughly 1W or 16% decrease in battery life for a 6Wavg system.
Apr 23, 2014
#7 derat@chromium.org
(No comment was entered for this change.)
Status: Fixed
Sep 17, 2014
#8 kr...@chromium.org
37 is now stable.
Status: Verified
Sign in to add a comment

Powered by Google Project Hosting