| Issue 34855: | Alpha in theme frame images rendered as black | |
| 4 people starred this issue and may be notified of changes. | Back to list |
Restricted
Sign in to add a comment
|
What steps will reproduce the problem? 1. Install attached CRX 2. See black background instead of a fully transparent one What is the expected output? What do you see instead? The background should be transparent.
Feb 9, 2010
Not a regression. Investigated, and it seems that even when drawing raw alpha=0 during paint in browser_frame_view, you get black. Either I'm missing something or it's plain unpossible. Either way, punting for now.
Cc:
dmacl...@chromium.org
Feb 9, 2010
I was missing something. Fixed.
Status:
Fixed
Feb 9, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=38514
------------------------------------------------------------------------
r38514 | avi@chromium.org | 2010-02-09 13:55:21 -0800 (Tue, 09 Feb 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=38514&r2=38513
Allow opacity in themes.
BUG=http://crbug.com/34855
TEST=as in bug
Review URL: http://codereview.chromium.org/600021
------------------------------------------------------------------------
Feb 9, 2010
Have to roll this back due to major Ts hit. If we can figure out how to do this without a speed regression... Not going to be M5.
Status:
Assigned
Feb 9, 2010
Avi please also take a look here: https://code.google.com/p/chromium/issues/detail?id=24693 I think the decision from UI folks was that we don't support transparency in themes.
Feb 9, 2010
So an artist made a theme with transparency and now all transparency is disallowed? :(
Feb 9, 2010
dmaclach turned the window transparent accidentally a while ago and a) startup perf suffered and b) mouse scroll events also scrolled the window behind the chrome window. if you re-enable transparency, check that you don't regress either of those
Feb 10, 2010
dmac claims UX says no. Closing; if you want to push this through get UX to approve and re-open.
Status:
WontFix
Oct 12, 2012
This issue has been closed for some time. No one will pay attention to new comments. If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels:
Restrict-AddIssueComment-Commit
Mar 10, 2013
(No comment was entered for this change.)
Labels:
-Feature-Themes -Mstone-5 M-5 Cr-UI-Browser-Themes
Mar 13, 2013
(No comment was entered for this change.)
Labels:
-Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
|
||||||||||
| ► Sign in to add a comment | |||||||||||
Owner: a...@chromium.org
Labels: Mstone-5 ReleaseBlock-stable