My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 34466: Translate infobars on OS X
6 people starred this issue and may be notified of changes. Back to list
 
Reported by jeremy@chromium.org, Feb 03, 2010
This bug is for tracking implementation of the translate infobars on OS X.
Comment 1 by pinkerton@chromium.org, Feb 04, 2010
(No comment was entered for this change.)
Labels: -Pri-2 Pri-1 PlatformParity Mstone-5
Comment 2 by karen@chromium.org, Feb 04, 2010
(No comment was entered for this change.)
Labels: m5-priority
Comment 3 by jshin@chromium.org, Feb 08, 2010
(No comment was entered for this change.)
Labels: i18n
Comment 4 by laforge@chromium.org, Feb 16, 2010
(No comment was entered for this change.)
Labels: -Area-Feature Area-UI
Comment 5 by bugdroid1@chromium.org, Feb 16, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=39206 

------------------------------------------------------------------------
r39206 | jeremy@chromium.org | 2010-02-16 23:49:53 -0800 (Tue, 16 Feb 2010) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/l10n_util.cc?r1=39206&r2=39205
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/l10n_util.h?r1=39206&r2=39205
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobars_delegates.cc?r1=39206&r2=39205
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobars_delegates.h?r1=39206&r2=39205
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/infobars/translate_infobars.cc?r1=39206&r2=39205

Translate: Move label parsing logic into common code.

* Add a string16 & Cocoa version of GetStringF().
* Move logic for parsing translate infobar label into translate_infobars_delegates.
* Make views variant of translate infobars use new code.

BUG=34466
TEST=Translate infobars should continue to workon Windows.

Review URL: http://codereview.chromium.org/597042
------------------------------------------------------------------------

Comment 6 by bugdroid1@chromium.org, Feb 25, 2010
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=40034 

------------------------------------------------------------------------
r40034 | jeremy@chromium.org | 2010-02-25 10:53:38 -0800 (Thu, 25 Feb 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/InfoBar.xib?r1=40034&r2=40033
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.cc?r1=40034&r2=40033
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/hover_close_button.mm?r1=40034&r2=40033
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/infobar_controller.h?r1=40034&r2=40033
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/translate_infobar.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/translate_infobar.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/translate/translate_infobars_delegates.cc?r1=40034&r2=40033
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/infobars/translate_infobars.cc?r1=40034&r2=40033
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=40034&r2=40033

Translate Infobars for OS X.

Infobars.xib changes - Connect and fix class for close button since the translate infobar needs to know where it is to position the "Options" menu to it's left.

BUG=34466
TEST=Translate infobars should continue to workon Windows.

Review URL: http://codereview.chromium.org/594056
------------------------------------------------------------------------

Comment 7 by jeremy@chromium.org, Feb 25, 2010
Mac Translate infobars are in, we'll track any further issues that might come up separately.
Status: Fixed
Comment 8 by rohitbm@chromium.org, Mar 01, 2010
5.0.340.0 (Official Build 40236) dev
Status: Verified
Sign in to add a comment

Powered by Google Project Hosting