(No comment was entered for this change.)

When I wrote the new theme code, I assumed that the IDR numbers were static and that 
there was a non-changing one-to-one mapping that would stay that way forever. This 
appears to have been a false assumption.

While this looks like a Linux bug, this is probably a cross-platform one.

I have no idea what the quick issue there is to fix the dev release, and I haven no 
idea how long the real long-term fix for this will take. 

r37458 fixes this individual case so we can do a dev channel.

Making a general fix so this never happens again will take more work.

(No comment was entered for this change.)

 Issue 33633  has been merged into this issue.

 Issue 33408  has been merged into this issue.

(No comment was entered for this change.)

 Issue 33805  has been merged into this issue.

r37609 seems to cause another theme issue, because new resources
were inserted in the middle of theme_resources.grd, not at the end.

r37609 had been merged to 249 branch at r37610 already.

 Issue 34022  has been merged into this issue.

 Issue 34005  has been merged into this issue.

 Issue 33926  has been merged into this issue.

 Issue 34047  has been merged into this issue.

Theoretically fixed permanently in r37722.

And merged into the 307 branch as of r37760.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37458 

------------------------------------------------------------------------
r37458 | erg@google.com | 2010-01-28 15:24:01 -0800 (Thu, 28 Jan 2010) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=37458&r2=37457

Very temporary fix for theme bug where adding more resources invalidates the ThemePack so we can release a dev channel.

Move new resources to the end so they don't modify current IDR ids that are now baked into BrowserThemePacks.

BUG=33416
TEST=Themes from previous dev channel work.

Review URL: http://codereview.chromium.org/551196
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37722 

------------------------------------------------------------------------
r37722 | erg@google.com | 2010-02-01 11:04:54 -0800 (Mon, 01 Feb 2010) | 12 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_pack.cc?r1=37722&r2=37721
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_pack_unittest.cc?r1=37722&r2=37721
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached?r1=37722&r2=37721

Don't store IDR ids in ThemePack files as they change whenever the grd is modified.

Instead, add an association table at the top of browser_theme_pack.cc that maps
the JSON string name and IDR# to a stable constant that won't change between
releases.

The ThemePack version number has been bumped to two, forcing a rebuild.

BUG=33416
TEST=none

Review URL: http://codereview.chromium.org/548207
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37760 

------------------------------------------------------------------------
r37760 | erg@google.com | 2010-02-01 14:54:32 -0800 (Mon, 01 Feb 2010) | 14 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/browser_theme_pack.cc?r1=37760&r2=37759
   M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/browser_theme_pack_unittest.cc?r1=37760&r2=37759
   M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/test/data/profiles/complex_theme/Default/Extensions/mblmlcbknbnfebdfjnolmcapmdofhmme/1.1/Cached?r1=37760&r2=37759

Merge 37722 - Don't store IDR ids in ThemePack files as they change whenever the grd is modified.

Instead, add an association table at the top of browser_theme_pack.cc that maps
the JSON string name and IDR# to a stable constant that won't change between
releases.

The ThemePack version number has been bumped to two, forcing a rebuild.

BUG=33416
TEST=none

Review URL: http://codereview.chromium.org/548207

TBR=erg@google.com
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37852 

------------------------------------------------------------------------
r37852 | erg@google.com | 2010-02-02 10:46:20 -0800 (Tue, 02 Feb 2010) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=37852&r2=37851

Revert "Very temporary fix for theme bug where adding more..." (r37458).

Now that we have a proper fix (r37722), we should revert this short term hack
(which didn't work in the end anyway).

BUG=33416
TEST=none

Review URL: http://codereview.chromium.org/562015
------------------------------------------------------------------------

 Issue 33655  has been merged into this issue.

 Issue 33346  has been merged into this issue.

I've seen every platform with bugs duped here; I assume it's OS-All?

 Issue 33694  has been merged into this issue.

Adding OS-Mac for verification tracking only

 Issue 34460  has been merged into this issue.

(No comment was entered for this change.)

Verified on Mac version 5.0.307.5 (Official Build 37950) dev.

Issue not reproducible with 5.0.307.5 (Official Build 37950) dev on linux

 Issue 34709  has been merged into this issue.

Verified on all releases now.

 Issue 34109  has been merged into this issue.

 Issue 34049  has been merged into this issue.

Chrome 5.0.307.1 (Official Build 37331) dev

<b>What steps will reproduce the problem?</b>
1. Install Chrome 4.0.302.3(Official Build 36935) dev [latest dev channel 
release build]
2. Install any theme 
3. Overinstall Chrome 5.0.307.1 (Official Build 37331) dev 
4. Open New tab page

What is the expected output? 
no layout issue

What do you see instead?
New tab page layout and repaint issues. 
Screenshot_ntp : If you have any theme installed and launch ntp
Screenshot_ntp2 : If you have any theme installed and then install classic 
theme.

Above issue &quot;not&quot; reproducible if it is a fresh install or if no theme is 
installed or if under options &gt;personal stuff - use classic theme button is 
clicked.

<b>Please use labels and text to provide additional information.</b>
Screenshots: