| Issue 33248: | Cookie dialog is slow and makes it hard to select cookies | |
| 4 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Chrome Version : 5.0.307.0 (37196) What steps will reproduce the problem? 1. Open Cookie dialog 2. Type something into the search box (e.g. "asdf") 3. Hit cmd-a 4. Hit delete 5. Click the disclosure triangle of any page in the list 6. Click on the cookie that's revealed What is the expected result? After 4., the cookie list should be displayed immediately. After 6, that cookie should be selected. What happens instead? After 4., there's a noticable pause (1s or so). After 6, the disclosure triangles closes again and no cookie is selected.
,
Jan 28, 2010
Issue 33411 has been merged into this issue.
Cc: kr...@chromium.org rohi...@chromium.org tha...@chromium.org rse...@chromium.org
,
Jan 28, 2010
Issue 33411 had a sample attached.
,
Jan 31, 2010
Did some testing. It looks like building and maintaing the large Cocoa model is what's eating up time.
Labels: Jank
,
Jan 31, 2010
Then maybe the "wrong cookie selected" part can be addressed first? :-)
,
Feb 1, 2010
(No comment was entered for this change.)
Status: Fixed
,
Feb 1, 2010
It's now faster, but it still selects the wrong cookie on click every now and then. Repro: 1. Have my set of cookies 2. Search for "ap" (screenie 1) 3. Reveal "developer.apple.com" (screenie 2) 4. Click "developer.apple.com" Expected: Should be selected Actual: Another cookie opens and is selected instead (screenie 3). (Also, why is no data shown for localstorage?)
Status: Assigned
,
Feb 2, 2010
(No comment was entered for this change.)
Cc: pinker...@chromium.org
Labels: -Jank
,
Feb 2, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=37695
------------------------------------------------------------------------
r37695 | rsesek@chromium.org | 2010-02-01 08:11:27 -0800 (Mon, 01 Feb 2010) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookie_tree_node.h?r1=37695&r2=37694
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookie_tree_node.mm?r1=37695&r2=37694
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookies_window_controller.mm?r1=37695&r2=37694
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm?r1=37695&r2=37694
[Mac] Reduce jank in the cookie manager by lazily creating child nodes for the UI.
Also selects the first cookie node whene expanding an origin node.
BUG=33248
TEST=With a lot of cookies in your profile: Chromium-->Preferences-->Under the Hood-->Show cookies... Filter by a domain, expand the domain and the first cookie should be selected. Clear the filter and list should reappear speadily.
Review URL: http://codereview.chromium.org/554151
------------------------------------------------------------------------
,
Feb 2, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=37853
------------------------------------------------------------------------
r37853 | rsesek@chromium.org | 2010-02-02 10:49:20 -0800 (Tue, 02 Feb 2010) | 11 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/cookie_tree_node.h?r1=37853&r2=37852
M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/cookie_tree_node.mm?r1=37853&r2=37852
M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/cookies_window_controller.mm?r1=37853&r2=37852
M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/cookies_window_controller_unittest.mm?r1=37853&r2=37852
Merge 37695 - [Mac] Reduce jank in the cookie manager by lazily creating child nodes for the UI.
Also selects the first cookie node whene expanding an origin node.
BUG=33248
TEST=With a lot of cookies in your profile: Chromium>Preferences>Under the Hood>Show cookies... Filter by a domain, expand the domain and the first cookie should be selected. Clear the filter and list should reappear speadily.
Review URL: http://codereview.chromium.org/554151
TBR=rsesek@chromium.org
Review URL: http://codereview.chromium.org/561023
------------------------------------------------------------------------
,
Feb 2, 2010
Issue 34301 has been merged into this issue. |
|||||||||||||||||||||||||
| ► Sign in to add a comment | ||||||||||||||||||||||||||
Cc: j...@chromium.org
Labels: ReleaseBlock-Beta